microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.2k stars 28.86k forks source link

"Replace (Enter)" button breaks #164674

Open red-candle opened 1 year ago

red-candle commented 1 year ago

Type: Bug

"editor.find.cursorMoveOnType": false breaks the behaviour of the "Replace (Enter)" button (or pressing Enter in the Replace field). It now has to be clicked/"entered" twice before a replace is made. The first input merely performs a Next Match.

All I wanted to do is prevent this program from automatically leaving the view while I'm typing in the search field. :(

VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:18.074Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-8365U CPU @ 1.60GHz (8 x 1896)| |GPU Status|2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|15.81GB (8.38GB free)| |Process Argv|--disable-gpu --enable-use-zoom-for-dsf --crash-reporter-id 05c61087-ca98-4d16-9b3c-01f4053cbdb7| |Screen Reader|no| |VM|0%|
Extensions (8) Extension|Author (truncated)|Version ---|---|--- vscode-docker|ms-|1.22.2 python|ms-|2022.16.1 vscode-pylance|ms-|2022.10.30 jupyter|ms-|2022.9.1202862440 jupyter-keymap|ms-|1.0.0 jupyter-renderers|ms-|1.0.10 vscode-jupyter-cell-tags|ms-|0.1.6 vscode-jupyter-slideshow|ms-|0.1.5
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492:30256859 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263cf:30335440 vscorecescf:30445987 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30410667 cppdebug:30492333 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 azure-dev_surveyone:30548225 pyindex848:30577860 nodejswelcome1:30587005 fc301958:30595537 ```
amunger commented 9 months ago

The first enter might make sense because it needs to show which instance will be replaced, but every subsequent replacement requires two presses of the enter key. It seems like replacing an instance should just select the next instance.