search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.2k stars 29.29k forks source link

GitHub for VSCode not properly unlinked until VSCode restart #164868

Open Causevha opened 2 years ago

Causevha commented 2 years ago

Type: Bug

  1. Link GitHub to VSCode via GitHub for VSCode
  2. Unlink it via Account button (above cogwheel,bottom left) -> Select Github User -> Unlink account
  3. Try to clone a repository. It's still possible to select repositories from the previously linked GitHub account.

Restarting VSCode seems to be the only thing that fully unlinks it, which assumingly can be dangerous.

VS Code version: Code 1.72.2 (d045a5eda657f4d7b676dedbfa7aab8207f8a075, 2022-10-12T22:15:18.074Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3392)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: unavailable_off
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|15.94GB (12.35GB free)| |Process Argv|--crash-reporter-id 037ea8ec-fc9c-4c22-8cbd-1370e713e758| |Screen Reader|no| |VM|67%|
Extensions (23) Extension|Author (truncated)|Version ---|---|--- path-intellisense|chr|2.8.1 vscode-eslint|dba|2.2.6 jquerysnippets|don|0.0.1 vscode-html-css|ecm|1.13.1 prettier-vscode|esb|9.9.0 auto-close-tag|for|0.5.14 vscode-language-pack-de|MS-|1.72.10120946 python|ms-|2022.16.1 vscode-pylance|ms-|2022.10.40 jupyter|ms-|2022.9.1202862440 jupyter-keymap|ms-|1.0.0 jupyter-renderers|ms-|1.0.10 vscode-jupyter-cell-tags|ms-|0.1.6 vscode-jupyter-slideshow|ms-|0.1.5 live-server|ms-|0.4.3 autodocstring|njp|0.6.1 npm-install|ore|0.0.1 vscode-css-peek|pra|4.2.0 LiveServer|rit|5.7.9 altv-vscode-docs|stu|2.0.9 JavaScriptSnippets|xab|1.8.0 material-theme|zhu|3.15.6 html-css-class-completion|Zig|1.20.0 (1 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscorecescf:30445987 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vscaac:30438847 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 azure-dev_surveyone:30548225 pyindex848:30577860 nodejswelcome1:30587005 fc301958:30595537 2e4cg342:30596373 ```
lszomoru commented 2 years ago

@TylerLeonhardt, is this an issue with the GitHub auth extension, or the GitHub extension?

TylerLeonhardt commented 2 years ago

@lszomoru you need to listen to the event in the GitHub extension: https://code.visualstudio.com/api/references/vscode-api#authentication image

Nothing I can really do in the GH auth extension because once I give you a session, I can't really "revoke it" since it's just an object.

lszomoru commented 2 years ago

@TylerLeonhardt, thanks for the clarifications.