microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.58k stars 29.03k forks source link

Remove the default scroll bar in the extensions' tip modal. #166171

Closed langyo closed 1 year ago

langyo commented 1 year ago

Does this issue occur when all extensions are disabled?: No

Steps to Reproduce: image

  1. Switch to the extension bar.
  2. Try to hover some items. Some one may not show the default scroll bar, but the problem is exists.

image I have tried to fix it. It seems caused by the visual bug from the issue #158921. The scroll bar will show when the content is too long.

This solution is great, but it causes another little bug in the screenshot.

I think it's unwise to remove the overflow-y: auto tag, so I tried another way, just add 1px to the tag max-height:

image

I'll make a PR after this issue has submitted.

n0099 commented 1 year ago

I can't reproduce this srollbar for all extensions in the list: image

langyo commented 1 year ago

I can't reproduce this srollbar for all extensions in the list: image

This bug is not 100% recurring.

Some extensions' descriptions may just exceed the calculatedmax-height.

n0099 commented 1 year ago

I can't reproduce this srollbar for all extensions in the list:

This bug is not 100% recurring.

Some extensions' descriptions may just exceed the calculatedmax-height.

What's ur testing extension id?

langyo commented 1 year ago

I can't reproduce this srollbar for all extensions in the list:

This bug is not 100% recurring. Some extensions' descriptions may just exceed the calculatedmax-height.

What's ur testing extension id?

ms-dotnettools.vscode-dotnet-runtime
formulahendry.auto-close-tag
steoates.autoimport
formulahendry.auto-rename-tag
manasxx.background-cover
BazelBuild.vscode-bazel
michelemelluso.code-beautifier
alefragnani.Bookmarks
ms-vscode.cpptools-extension-pack
ms-vscode.cpptools-themes
ms-dotnettools.csharp
taiyuuki.chinese-color
Pivotal.vscode-manifest-yaml
twxs.cmake
SPGoding.datapack-language-server
ms-azuretools.vscode-docker
cschlosser.doxdocgen
dsznajder.es7-react-js-snippets
miguelsolorio.fluent-icons
tombonnike.vscode-status-bar-format-toggle
donjayamanne.githistory
ms-vscode.hexeditor
ms-toolsai.vscode-jupyter-cell-tags
ms-toolsai.jupyter-keymap
ms-toolsai.vscode-jupyter-slideshow
ritwickdey.LiveServer
ms-vscode.makefile-tools
DavidAnson.vscode-markdownlint
unifiedjs.vscode-mdx
roerohan.mongo-snippets-for-node-js
bmewburn.vscode-intelephense-client
ms-vscode.powershell
esbenp.prettier-vscode
rvest.vs-code-prettier-eslint
mechatroner.rainbow-csv
mskelton.react-emotion-snippets
ms-vscode-remote.remote-ssh-edit
jRichardeau.vscode-vsproj
ms-vscode.vscode-selfhost-test-provider
ms-kubernetes-tools.vscode-kubernetes-tools

These extensions have the problem on my machine.

n0099 commented 1 year ago

ms-dotnettools.vscode-dotnet-runtime michelemelluso.code-beautifier

image image

langyo commented 1 year ago

ms-dotnettools.vscode-dotnet-runtime michelemelluso.code-beautifier

image image

Maybe it's related to high-resolution screen.

I'm sure it's an accidental problem, but it still exists.

If you have the conditions, try adjusting the screen resolution scale to 150%.

n0099 commented 1 year ago

there should be some bugs when doing sub pixel sampling whether it's related to windows DPI settings. can you reproduce this regularly without changing DPI?

Tyriar commented 1 year ago

Caused by https://github.com/Microsoft/vscode/pull/164093

@rzhao271 can you please have a look at this?