search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.31k stars 29.31k forks source link

Compound keyboard shortcuts should be delimited by commas #16770

Closed mousetraps closed 4 years ago

mousetraps commented 7 years ago

Testing #16560

Would help improve readability. This goes for watermark, docs, and command palette. For example:

  1. Ctrl+K Ctrl+M -> Ctrl+K, Ctrl+M
  2. Ctrl+K M -> Ctrl+K, M

Also note that this is scheme is consistent with almost every other editor out there. We also seem to do this for some commands, but not others. E.g. image

alexdima commented 7 years ago

@mousetraps We use the comma in that view to render multiple different keybindings.

i.e. Close Notification Messages is bound to Escape and to Shift+Escape

while View: Close All Editors is bound only to Ctrl+K Ctrl+W

Should we render chords using some fancy Unicode character between the two pieces? e.g.

Maybe you have some ideas?

mousetraps commented 7 years ago

@alexandrudima interesting - a couple different ideas then:

  1. "or" or "and" to render multiple different keybindings
  2. It seems to me that the multiple keybindings would be intended less for learnability, and more to assist with muscle memory, so how about choosing only one of the mappings to display in quickopen, and being more verbose in docs?

E.g. Option 2 is what VS goes for (and iirc WebStorm as well) image

image

alexdima commented 7 years ago

@bpasero We could simply show only one keybinding in the F1 list, not sure why we're showing all of them.

bpasero commented 7 years ago

Fine by me, if someone wants to step in and do it. @mousetraps ?

bpasero commented 7 years ago

Fyi, command pallette is no longer showing multiple keybindings.

giuscri commented 5 years ago

As I understand this, this should be closed