search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.76k stars 28.18k forks source link

Markdown tip on statusbar panel uses different background color for backtick-marked text #167917

Open gjsjohnmurray opened 1 year ago

gjsjohnmurray commented 1 year ago

I am using Dark+ theme.

image

Maybe this is intentional, but I thought I'd check.

VS Code version: Code - Insiders 1.74.0-insider (493a541735b84de36b628750ba716a430669cb7f, 2022-12-02T05:21:11.264Z) OS version: Windows_NT x64 10.0.22621 Modes: Sandboxed: Yes

VSCodeTriageBot commented 1 year ago

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

gjsjohnmurray commented 1 year ago

Do you need more info from me? If so, what?

jrieken commented 1 year ago

This is just a screen shot. Repro steps? Yes, status bar items support markdown hovers in case that's the question

gjsjohnmurray commented 1 year ago

Repro steps:

  1. Clone https://github.com/gjsjohnmurray/vscode-extension-samples/tree/show-167917
  2. Open statusbar-sample folder.
  3. Build and run.
  4. In Extension Development Host window use File\New Text File
  5. Enter a few lines and select at least one of them.
  6. Hover over the statusbar panel which the sample adds:

image

Observer that when color theme is "Dark +" the monospaced phrases in the tip (backtick-marked and #167917) have a different background color compared to the rest of the tip.

jrieken commented 1 year ago

https://github.com/gjsjohnmurray/vscode-extension-samples/blob/show-167917/statusbar-sample/src/extension.ts#L38 tells me that markdown rendering is wanted, e.g this isn't an accidental MD rendering. I believe the background style (for inline code) is also wanted but I let @daviddossett confirm

daviddossett commented 1 year ago

I think it's correct that text within backticks gets a special rendering. Just like it would like this.

I don't however know where these styles are coming from. At a glance, it looks to me like the background should be lighter, not darker, at least in the default dark theme.