microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.24k stars 28.87k forks source link

Context menu layout of the right positioned Side Bar #167941

Open Dblm0 opened 1 year ago

Dblm0 commented 1 year ago

Type: Bug

Both Accounts and Manage actions, placed on right positioned Side Bar, triggers context menu, which overlays the bar. This layout differs from the default left position. It also differs from win10 version, where layout behavior seems to be mirrored.

This king of layout lead to the problem, where Check for Updates... item is being selected automatically. Only moving cursor to the top of the action allows user to list the context menu.

VS Code version: Code 1.73.1 (6261075646f055b99068d3688932416f2346dd3b, 2022-11-09T03:54:53.913Z) OS version: Linux x64 5.19.0-kali2-amd64 Modes: Sandboxed: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-7940X CPU @ 3.10GHz (8 x 3095)| |GPU Status|2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: disabled_off| |Load (avg)|1, 0, 0| |Memory (System)|15.60GB (13.67GB free)| |Process Argv|--unity-launch --crash-reporter-id 52460bc4-75e5-4872-91d2-295a9b65a464| |Screen Reader|no| |VM|100%| |DESKTOP_SESSION|lightdm-xsession| |XDG_CURRENT_DESKTOP|XFCE| |XDG_SESSION_DESKTOP|lightdm-xsession| |XDG_SESSION_TYPE|x11|
Extensions (11) Extension|Author (truncated)|Version ---|---|--- jupyter-keymap|ms-|1.0.0 vscode-jupyter-cell-tags|ms-|0.1.6 vscode-jupyter-slideshow|ms-|0.1.5 cmake-tools|ms-|1.12.27 cpptools|ms-|1.12.4 hexeditor|ms-|1.9.9 LiveServer|rit|5.7.9 rust-analyzer|rus|0.3.1301 even-better-toml|tam|0.19.0 errorlens|use|3.6.0 vscode-icons|vsc|12.0.1 (3 theme extensions excluded)
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263cf:30335440 vscorecescf:30445987 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vsclangdf:30486550 c4g48928:30535728 dsvsc012cf:30540253 azure-dev_surveyone:30548225 pyindex848:30577860 nodejswelcome1:30587005 2e4cg342:30602488 gswce1:30612156 iaj6b796:30613358 dbltrim-noruby:30604474 89544117:30613380 ```

screen record

gjsjohnmurray commented 1 year ago

Maybe Linux-specific as I can't repro it on Windows.

sbatten commented 1 year ago

This repros with native menus, I can look into a workaround, but we have several issues about electron not avoid the mouse when drawing menus.

Dblm0 commented 1 year ago

It works on Windows, because it uses custom style by default. To reproduce the same behavior, user can change the Title Bar Style setting in Window category to native value.

bpasero commented 1 year ago

Curious if people could try if they can still reproduce this using our latest insider. You can give our preview releases a try from: https://code.visualstudio.com/insiders/

And if it still reproduces, configure "window.experimental.nativeContextMenuLocation": true in settings and check again.

Thanks 🙏

Dblm0 commented 1 year ago

Can reproduce it with 1.81.0 insiders on following platforms:

Need to mention that on Windows 11 Build 22621 it's not reproducible, even with 1.73.1 version