Should not be possible to open 683 instances of VS Code in one user action

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

164.05k stars 29.21k forks source link

Should not be possible to open 683 instances of VS Code in one user action #16882

Closed mousetraps closed 7 years ago

mousetraps commented 7 years ago

Testing #15811

Steps to Reproduce:

select all the directories in the VS Code node_modules folder
drag into file view

watch (5 min) 🍿 as VS Code transforms itself into a winning game of FreeCell

Eventually VS Code will crash

Video: https://youtu.be/ZTtuOdMqzJY

VSCode Version: Code - Insiders 1.8.0-insider (7499a9f3c565f4fbe5205e30c8664e5a5a11ae94, 2016-12-06T16:16:15.865Z)
OS Version: Windows_NT ia32 10.0.14965

roblourens commented 7 years ago

Well I can't think of anything better to do for 5 minutes.

mousetraps commented 7 years ago

@roblourens yeah, well it's between locking up your computer and coming up with more BuzzFeed style headlines. Tough call.

opus-2 commented 7 years ago

I laughed.

bpasero commented 7 years ago

Since there is a fixed limit of memory VSCode can claim, you likely hit the out of memory case quickly in this setup. I am sure opening 683 instances of other applications can cause similar behaviour.

roblourens commented 7 years ago

Maybe vscode could ask to confirm before opening 683 instances, since someone could be trying to add folders to a "project", not knowing that we'll open a new instance for each one.

opus-2 commented 7 years ago

I believe this is not about the software, it's called humour. ;-)

Em 08/12/2016 07:08, Benjamin Pasero escreveu:

Since there is a fixed limit of memory VSCode can claim, you likely hit the out of memory case quickly in this setup. I am sure opening 683 instances of other applications can cause similar behaviour.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Microsoft/vscode/issues/16882#issuecomment-265689879, or mute the thread https://github.com/notifications/unsubscribe-auth/AXUDfx1W1Tcn-HY_F5ryNF3mtXmWAk3Xks5rF8kngaJpZM4LHUWn.

mousetraps commented 7 years ago

It was a far-fetched example for sure, but there were a lot of things that went wrong here that are totally addressable on our end.

you shouldn't be able to open 600 instances of anything in one user action.
we are overloading a single perceived user action - dragging a folder into VSCode should probably copy those into the project, as we do with files, not open up new instances.
the visual indicator said "move" / "copy", not "open new instance"
if we have a drag into editor to open instance option, would probably be reasonable to allow for only one at a time.
any long-running action (eg whether it be opening 600 instances or otherwise) should be cancellable

bpasero commented 7 years ago

Verify: dropping > 20 folders brings up a dialog like this: