search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
161.87k stars 28.45k forks source link

Annoying scroll snapping for failing test output #169018

Closed dmartin closed 1 year ago

dmartin commented 1 year ago

Type: Bug

Behaviour

Expected vs. Actual

Expected: The peek panels displaying failing test output function similarly to those created by "Peek Definition" etc. in that they don't affect scroll position.

Actual: If any part of the failing test output is partially visible, the scroll position snaps so that the entire output is displayed.

Steps to reproduce:

  1. Run a failing test
  2. Scroll so that its output is partially visible on screen

https://user-images.githubusercontent.com/1657652/207134438-ad3a4f71-e475-4295-83f7-d660647faf29.mov

Diagnostic data

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

``` XXX ```

User Settings

``` envFile: "" languageServer: "Pylance" linting • cwd: "" • mypyArgs: "" • mypyEnabled: true formatting • provider: "black" testing • cwd: "" • promptToConfigure: false • pytestArgs: "" • pytestEnabled: true • pytestPath: "" terminal • activateEnvironment: false ```

Extension version: 2022.20.0 VS Code version: Code 1.74.0 (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:43:37.594Z) OS version: Darwin x64 22.1.0 Modes: Sandboxed: No Remote OS version: Linux x64 5.15.49-linuxkit

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (12 x 2900)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|5, 3, 3| |Memory (System)|32.00GB (2.63GB free)| |Process Argv|--crash-reporter-id b1f4d68b-46f1-434e-8b39-8279d73a412b| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|Dev Container: picoCTF platform| |OS|Linux x64 5.15.49-linuxkit| |CPUs|Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz (10 x 2904)| |Memory (System)|15.63GB (11.11GB free)| |VM|0%|
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 azure-dev_surveyone:30548225 vscccc:30610679 pyindex848:30577860 nodejswelcome1cf:30587006 282f8724:30602487 gswce1:30612156 iaj6b796:30613358 dbltrim-noruby:30604474 f6dab269:30613381 fim-prod:30623723 ```
connor4312 commented 1 year ago

Thanks for the issue report. I'm having some trouble reproducing it. Are you able to share your full set of user settings? (Please feel free to exclude any private info that may be in there, mostly interested in toggles that might be affecting the editor...)

dmartin commented 1 year ago

Unfortunately, I haven't been able to reproduce it today either. It probably makes sense to close this unless there's a reliable way to make it happen.

I'll still include my settings below just in case they might prove helpful to someone debugging in the future.

Settings ```json { "[python]": { "editor.defaultFormatter": "ms-python.black-formatter", "editor.formatOnSave": true, "editor.codeActionsOnSave": [ "source.fixAll.unusedImports", "source.organizeImports" ], "editor.rulers": [ 88 ] }, "black-formatter.importStrategy": "fromEnvironment", "editor.accessibilitySupport": "off", "editor.dragAndDrop": false, "editor.emptySelectionClipboard": false, "editor.find.seedSearchStringFromSelection": false, "editor.fontSize": 14, "editor.guides.bracketPairs": "active", "editor.hover.above": false, "editor.inlayHints.enabled": "onUnlessPressed", "editor.minimap.enabled": false, "editor.multiCursorModifier": "ctrlCmd", "editor.multiCursorPaste": "full", "editor.renderControlCharacters": true, "editor.renderWhitespace": "all", "editor.snippetSuggestions": "none", "editor.stickyScroll.enabled": true, "editor.suggest.insertMode": "replace", "editor.suggest.localityBonus": true, "editor.suggest.showSnippets": false, "editor.tabCompletion": "on", "editor.wordWrap": "wordWrapColumn", "editor.wordWrapColumn": 200, "eslint.format.enable": true, "explorer.autoReveal": false, "explorer.compactFolders": false, "explorer.confirmDelete": false, "explorer.confirmDragAndDrop": false, "explorer.openEditors.visible": 0, "files.hotExit": "onExitAndWindowClose", "files.insertFinalNewline": true, "files.trimTrailingWhitespace": true, "flake8.importStrategy": "fromEnvironment", "git.autoRepositoryDetection": "subFolders", "git.closeDiffOnOperation": true, "git.ignoreLegacyWarning": true, "git.mergeEditor": true, "git.openDiffOnClick": false, "githubIssues.assignWhenWorking": false, "githubIssues.ignoreUserCompletionTrigger": [ "python", "markdown", "rust" ], "githubIssues.queries": [ { "label": "My Issues", "query": "default" }, { "label": "Open Issues", "query": "state:open repo:${owner}/${repository} sort:created-desc" }, { "label": "Created Issues", "query": "author:${user} state:open repo:${owner}/${repository} sort:created-desc" } ], "githubIssues.useBranchForIssues": "off", "githubPullRequests.queries": [ { "label": "Waiting For My Review", "query": "is:open review-requested:${user}" }, { "label": "Assigned To Me", "query": "is:open assignee:${user}" }, { "label": "Created By Me", "query": "is:open author:${user}" } ], "gitlens.advanced.messages": { "suppressGitVersionWarning": true }, "gitlens.codeLens.scopes": [ "document" ], "gitlens.showWelcomeOnInstall": false, "go.toolsManagement.autoUpdate": true, "isort.importStrategy": "fromEnvironment", "jupyter.askForKernelRestart": false, "koverage.sufficientCoverageThreshold": 100, "markdown.links.openLocation": "beside", "markdown.validate.enabled": true, "notebook.cellToolbarLocation": { "default": "right", "jupyter-notebook": "left" }, "notebook.output.textLineLimit": 10000, "problems.showCurrentInStatus": true, "python.analysis.diagnosticMode": "workspace", "python.analysis.inlayHints.functionReturnTypes": true, "python.analysis.inlayHints.variableTypes": true, "python.analysis.memory.keepLibraryAst": true, "python.analysis.typeCheckingMode": "off", "python.formatting.provider": "black", "python.languageServer": "Pylance", "python.linting.flake8Enabled": false, "python.linting.mypyEnabled": true, "python.linting.pylintEnabled": false, "python.showStartPage": false, "python.terminal.activateEnvironment": false, "python.testing.autoTestDiscoverOnSaveEnabled": true, "python.testing.promptToConfigure": false, "python.testing.pytestEnabled": true, "python.testing.pytestPath": "", "python.testing.unittestEnabled": false, "rewrap.wholeComment": false, "rust-analyzer.diagnostics.disabled": [ "unresolved-macro-call" ], "rust-analyzer.hover.actions.implementations.enable": false, "rust-analyzer.lens.enable": false, "rust-analyzer.lens.forceCustomCommands": false, "rust-analyzer.lens.implementations": false, "rust-analyzer.lens.implementations.enable": false, "rust-analyzer.lens.run.enable": false, "rust-analyzer.procMacro.enable": false, "scm.autoReveal": false, "scm.defaultViewMode": "tree", "scm.diffDecorationsIgnoreTrimWhitespace": "true", "search.quickOpen.includeSymbols": true, "search.searchEditor.doubleClickBehaviour": "openLocationToSide", "svg.preview.boundingBox": true, "terminal.integrated.confirmOnExit": "hasChildProcesses", "terminal.integrated.confirmOnKill": "always", "terminal.integrated.copyOnSelection": true, "terminal.integrated.fontSize": 14, "terminal.integrated.macOptionClickForcesSelection": true, "terminal.integrated.scrollback": 10000, "terminal.integrated.shellIntegration.enabled": true, "terminal.integrated.tabs.focusMode": "singleClick", "todo-tree.filtering.includeHiddenFiles": true, "todo-tree.general.tags": [ "BUG", "FIXME", "TODO", "XXX", "@TODO", "[ ]", "[x]", "todo" ], "todo-tree.tree.showScanModeButton": false, "window.commandCenter": true, "window.newWindowDimensions": "inherit", "workbench.editor.decorations.badges": true, "workbench.editor.decorations.colors": true, "workbench.editor.limit.excludeDirty": true, "workbench.editor.limit.value": 5, "workbench.editor.untitled.hint": "hidden", "workbench.editorAssociations": { "*.ipynb": "jupyter-notebook" }, "workbench.startupEditor": "newUntitledFile" } ```
Installed extensions ```text Asuka.insertnumbers be5invis.toml DavidAnson.vscode-markdownlint dbaeumer.vscode-eslint eamodio.gitlens EditorConfig.EditorConfig eriklynd.json-tools esbenp.prettier-vscode fabiospampinato.vscode-diff Gruntfuggly.todo-tree ms-azuretools.vscode-docker ms-python.black-formatter ms-python.flake8 ms-python.isort ms-python.python ms-python.vscode-pylance ms-toolsai.jupyter ms-toolsai.jupyter-keymap ms-toolsai.jupyter-renderers ms-toolsai.vscode-jupyter-cell-tags ms-toolsai.vscode-jupyter-slideshow ms-vscode.live-server ramyaraoa.show-offset rohit-gohri.format-code-action Rubymaniac.vscode-paste-and-indent rust-lang.rust-analyzer ryanluker.vscode-coverage-gutters stkb.rewrap streetsidesoftware.code-spell-checker tenninebt.vscode-koverage timonwong.shellcheck ```
connor4312 commented 1 year ago

Hm, thanks. I don't repro either with this settings. I'll go ahead and close this then, maybe it was fixed in the recovery release. Please let me know if you see it again.