search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.49k stars 28.97k forks source link

Can `package.nls.*.json` in a sub directory? #169150

Open shalldie opened 1 year ago

shalldie commented 1 year ago

Can package.nls.*.json in a sub directory?

I wan to put them in a sub directory, there's to be too many files at root.

TylerLeonhardt commented 1 year ago

Today, the package.nls.*.json files can't be put anywhere else... however, I would like to leverage the l10n property of the package.json (which is used for the l10n VS Code API) to enable folks to put their package.nls.*.json files there.

When doing that, maybe we also rename it to package.l10n.json and package.l10n.*.json so that everything is consistent (of course we would have backwards compatibility)

shalldie commented 1 year ago

Sounds great, I like it ! Is it an idea or a work in progress?

TylerLeonhardt commented 1 year ago

It's just an idea for now. I've got some other work that is higher up on my list but we'll leave this issue open as a reminder of this work

anzory commented 1 year ago

Hi all. Is it true that if VSCode does not have any localization (e.g. Albanian), it means that it will not appear in env.language, and that it is useless to create bundle.l10n.sq.json bundle - it will not be accepted by l10n anyway?

TylerLeonhardt commented 1 year ago

@anzory yes that is correct. An Albanian language pack would need to be created to set VS Code to Albanian and then extensions would be able to support this language.