search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.49k stars 29.37k forks source link

Terminal starts always bash even zsh is set to default #169654

Closed tianyl closed 1 year ago

tianyl commented 1 year ago

On macOS terminal starts always bash shell even zsh is set to default. See attached video

https://user-images.githubusercontent.com/905199/208710053-302881c1-e875-4740-a23c-808634f878f2.mov

meganrogge commented 1 year ago

When vscode starts up, we run $SHELL -ilc to source the environment in which to create the terminal. This only happens when you open VS Code from the dock.

Can you try to reproduce the issue when you:

close all windows and open it from the dock close all windows and run code from an external terminal to launch it

tianyl commented 1 year ago

I reproduced this issue.

If I run VS Code from the dock VS Code tries to start Bash shell. If I write ”open /Applications/Visual Studio Code.app” to my terminal VS Code indeed will launch zsh.

On 6. Jan 2023, at 17.26, Megan Rogge @.***> wrote:

When vscode starts up, we run $SHELL -ilc to source the environment in which to create the terminal. This only happens when you open VS Code from the dock.

Can you try to reproduce the issue when you:

close all windows and open it from the dock close all windows and run code from an external terminal to launch it

— Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/169654#issuecomment-1373777744, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG4737ZI5KTMO44D2F6NI3WRA2TFANCNFSM6AAAAAATEU7ZQU. You are receiving this because you authored the thread.

meganrogge commented 1 year ago

/duplicate #170563

vscodenpa commented 1 year ago

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!