microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.59k stars 29.03k forks source link

In explorer view, find box covers top result when filtering #169756

Closed TommyNorthAL closed 1 year ago

TommyNorthAL commented 1 year ago

Type: Bug

+Have a list of files in explorer view +Enter Ctrl-F, a search term that includes at least one file, and press the filter button on the right of the search box +The top result will be covered by the search box, the search bar movement button will not give relief unless you increase the size of the explorer pane to allow the search bar to slide to right of file name

VS Code version: Code 1.74.1 (1ad8d514439d5077d2b0b7ee64d2ce82a9308e5a, 2022-12-14T10:30:51.966Z) OS version: Windows_NT x64 10.0.22621 Modes: Sandboxed: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9900K CPU @ 3.60GHz (16 x 3600)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|31.86GB (25.12GB free)| |Process Argv|. --crash-reporter-id 3ba9e61e-82b4-46a7-a074-3a02ac6ada1f| |Screen Reader|no| |VM|67%|
Extensions (5) Extension|Author (truncated)|Version ---|---|--- linter-gfortran|for|3.2.0 cpptools|ms-|1.13.8 hexeditor|ms-|1.9.9 powershell|ms-|2022.12.1 brightscript|Rok|2.38.3
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vstes627:30244334 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 azure-dev_surveyone:30548225 pyindex848:30577860 nodejswelcome1:30587005 2e4cg342:30602488 gswce1:30612156 iaj6b796:30613358 89544117:30613380 fim-prod:30623723 ```
vscodenpa commented 1 year ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

TommyNorthAL commented 1 year ago

Upgrade to very latest version did not change issue, I was already at 1.74.1

lramos15 commented 1 year ago

What is your expected fix here? We allow moving the search within that top region to help reveal the file names? Would you expect that there is some sort of blank row at the top just for the search bar?

TommyNorthAL commented 1 year ago

To have it as a separate top line, or to be able to dismiss it; when I am working a project with several source files and a number of ancillary files, it is handy to be able to see just the source files I am editing without having to scroll thru the whole list.

From: Logan Ramos @.> Sent: Wednesday, December 21, 2022 10:14 To: microsoft/vscode @.> Cc: Tommy Thomas @.>; Author @.> Subject: Re: [microsoft/vscode] In explorer view, find box covers top result when filtering (Issue #169756)

What is your expected fix here? We allow moving the search within that top region to help reveal the file names? Would you expect that there is some sort of blank row at the top just for the search bar?

- Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fvscode%2Fissues%2F169756%23issuecomment-1361598902&data=05%7C01%7C%7C36ffab38087c4bb8417208dae36e4f06%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638072360152939116%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pu6FdRCxe%2BxxfjrTe%2BKpSof%2BIaloXusRdNvgycE2r%2B4%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACXVE3EJXFKUSLCW5THLL3DWOMUC3ANCNFSM6AAAAAATFYSIHI&data=05%7C01%7C%7C36ffab38087c4bb8417208dae36e4f06%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638072360152939116%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gSK9K1jJmFYCJd5iRH%2FOHjM5OV%2Fe5gwCY6h5qiuVtsM%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

gjsjohnmurray commented 1 year ago

You should already be able to drag it down one row to reveal the first row.

TommyNorthAL commented 1 year ago

It appears from the comments that this is working the way it was intended, I had not tried filtering before and the behavior was unexpected, so I thought it was odd. I am content to work with it like it is, and will gladly close this issue if desired.