[json] improve (or remove) warning when schema download is disabed

[jwverzijden]

Type: Bug

I open any package.json and see a warning. I have disabled this feature in the past, it is still disabled in the settings but its somewhat turned back on. In fact the warning even mentions that the feature is disabled.

Please remove the warning if the feature is disabled. At the moment the only way to 'hide' this warning is to enable the feature again.

Problems loading reference 'https://json.schemastore.org/package': 
  Unable to load schema from 'https://json.schemastore.org/package': 
    Downloading schemas is disabled through setting 'json.schemaDownload.enable'.

VS Code version: Code 1.74.0 (5235c6bb189b60b01b1f49062f4ffa42384f8c91, 2022-12-05T16:47:18.476Z) OS version: Linux x64 6.0.6-76060006-generic Modes: Sandboxed: No

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|1, 1, 1| |Memory (System)|15.18GB (6.16GB free)| |Process Argv|--unity-launch| |Screen Reader|no| |VM|0%| |DESKTOP_SESSION|pop| |XDG_CURRENT_DESKTOP|Unity| |XDG_SESSION_DESKTOP|pop| |XDG_SESSION_TYPE|x11|

Extensions (7)

Extension|Author (truncated)|Version ---|---|--- esp-idf-extension|esp|1.5.1 todo-tree|Gru|0.0.220 better-cpp-syntax|jef|1.17.2 git-graph|mhu|1.30.0 cpptools|ms-|1.13.8 color-highlight|nau|2.5.0 rust-analyzer|rus|0.3.1325 (2 theme extensions excluded)

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.74.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[jwverzijden]

updated to: Version: 1.74.2 Commit: e8a3071ea4344d9d48ef8a4df2c097372b0c5161 Date: 2022-12-20T10:27:19.253Z Electron: 19.1.8 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Linux x64 6.0.6-76060006-generic Sandboxed: No

the issue remains in 1.74.2

[aeschli]

Is "json.schemaDownload.enable" disabled or enabled in the settings?

If you disabled it, then we won't load the schema, but show the warning so users understand why they don't get any schema support. Are you suggesting to not show such a warning in that case?

[jwverzijden]

it is set like this: "json.schemaDownload.enable": false but I do get the warning

[jwverzijden]

I mean I don't know what this schema is or why it should be downloaded from the internet..
Tthe warning doesn't help me understand that either, it only informs me how I can avoid the warning by enabling a feature that seems like it doesn't really do anything useful.

I expected that setting json.schemaDownload.enable to false would remove the warning but it doesn't. So either I get this warning or vscode downloads schemas that have no meaning to me

[neostfox]

me too, when settings.json set {"json.schemaDownload.enable":false} when open package.json it's still show warning info

[dionysius]

Disabling a feature should not produce a warning that it is disabled.

[mvasilkov]

Yep, this is a very curious UX when I specifically choose to disable an unwanted feature, and then get a persistent warning stating I have disabled the feature.

As with all other settings, this shouldn't be a warning.

[jwverzijden]

Imagine a warning is shown for every setting that is not on the default value. I would have over a thousand warnings, completely useless and drowning out actual relevant/useful warnings.

Please remove the warning if the feature is disabled. There are many closed issues with the same request for different schemas, @aeschli why not spend 5 minutes and remove this 1 line of code?

[jwverzijden]

or you know add another option so I can choose if I want to see this warning.