Open fxzxmic opened 1 year ago
In fact, busybox bash/ash does not support the builtin
command. I've found the way to set /bin/ash
as the default shell of vscode instead of the automatically detected /bin/bash
, so I don't know if this problem still needs to be fixed.
Thanks, it's still an issue then. We should detect if it's busybox either before injecting the shell integration or at the start of the script.
I'll create another issue for the case when there's no .bashrc
file so that gets verified
Check whether $BASH_VERSION
exists? This is probably the easiest way.
When I delete the code for reading .bashrc
and the builtin
command, it still reports an error.
It seems that busybox bash/ash is not compatible with this script.
Perhaps there could be an injection script for busybox bash/ash?
This is available for contributions. I believe all this needs is an if
here to exit early if it is busybox:
It needs to be tested of course and be a low risk change for regular bash.
Perhaps we should exit the script when we detect that this is not a true bash, or only perform some necessary injections. Otherwise, it would be too complicated to fully adapt to Busybox's bash.
Steps to Reproduce:
I use busybox bash as
/bin/bash
(still busybox ash in essence), which is why there is no.bashrc
. I hope vs code server can judge whether it is a real bash before using it, if not, treat the bash as ash.Does this issue occur when you try this locally?: No Does this issue occur when you try this locally and all extensions are disabled?: No