New remote X11 Forwarding breaks DISPLAY environment var

[delyada]

Type: Bug

Hi! Either the new version of Dev Containers 0.275.(0|1) extension, or VS Code 1.75, overrides our DISPLAY environment variable with an erroneous value of :1 instead of the expected good value of :0.

Here's what I tried in devcontainer.json:

"containerEnv": {
    // "DISPLAY": "${localEnv:DISPLAY}"
    // "DISPLAY": ":0"
}

Uncommenting either line, or leaving both commented and rebuilding the dev container always yields:

echo $DISPLAY
:1

But only :0 is the proper value, according to this WSLg wiki docs.

The newer Dev Containers version 0.275.1 release doesn't fix it either.

The previous Dev Containers version 0.266.1 works fine with these settings, but only if I also rollback VS Code to 1.74.x:

"containerEnv": {
 // "DISPLAY": "${localEnv:DISPLAY}", // This sets it to `1` which is wrong...
    "DISPLAY": ":0"
}

So it looks like either Dev Containers 0.275.(0|1), or VS Code 1.75, overrides our DISPLAY environment variable with an erroneous value.

Thanks a lot for, hopefully, fixing this soon. In the meantime, we can still use the previous versions...

The regression has already been reported in the Remote repo and I repost it here because I'm not sure if something in VS Code wouldn't have changed to be the real cause of the issue, because if I keep VS Code 1.75 and rollback just the extension, it doesn't fix the issue.

Note that this 1.74.3 version is what I rollbacked to to be able to continue my work. :) VS Code version: Code 1.74.3 (97dec172d3256f8ca4bfb2143f3f76b503ca0534, 2023-01-09T16:59:02.252Z) OS version: Windows_NT x64 10.0.22621 Modes: Sandboxed: No Remote OS version: Linux x64 5.15.79.1-microsoft-standard-WSL2

System Info

|Item|Value| |---|---| |CPUs|AMD Ryzen 9 3950X 16-Core Processor (32 x 3493)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|63.91GB (43.31GB free)| |Process Argv|--crash-reporter-id 2f445cef-1bbb-4af3-ab10-26eb64ae26f7| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|Dev Container: Yada 2023-01-16 Rebuild ✨| |OS|Linux x64 5.15.79.1-microsoft-standard-WSL2| |CPUs|AMD Ryzen 9 3950X 16-Core Processor (32 x 3493)| |Memory (System)|31.30GB (27.30GB free)| |VM|0%|

Extensions (32)

Extension|Author (truncated)|Version ---|---|--- remotehub|Git|0.50.0 theme-monokai-pro-vscode|mon|1.2.0 remote-containers|ms-|0.266.1 remote-wsl|ms-|0.75.1 remote-repositories|ms-|0.28.0 material-product-icons|PKi|1.4.1 vscode-icons|vsc|12.2.0 better-comments|aar|3.0.2 aws-toolkit-vscode|ama|1.62.0 vscode-zipfs|arc|3.0.0 calva|bet|2.0.331 joyride|bet|0.0.32 emojisense|bie|0.9.1 vscode-github-actions|csc|0.24.4 vscode-eslint|dba|2.4.0 portal|djb|0.35.1 gitlens|eam|13.2.0 prettier-vscode|esb|9.10.4 babashka-tasks|fbe|0.1.1 vscode-yarn|gam|2.1.0 vscode-pull-request-github|Git|0.58.0 vscode-cfn-lint|kdd|0.24.2 clojure-snippets|leo|0.0.6 aws-cli-configure|mar|0.3.0 git-graph|mhu|1.30.0 vscode-mjml|mjm|1.0.5 vscode-docker|ms-|1.23.3 playwright|ms-|1.0.6 vsliveshare|ms-|1.0.5828 abracadabra|nic|6.19.0 vscode-yaml|red|1.11.0 intellicode-api-usage-examples|Vis|0.2.7

A/B Experiments

``` vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263cf:30335440 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30410667 cppdebug:30492333 vscaac:30438847 vsclangdc:30486549 c4g48928:30535728 dsvsc012cf:30540253 azure-dev_surveyone:30548225 vsccc:30610678 pyindex848:30577860 nodejswelcome1cf:30587006 2e4cg342:30602488 pyind779:30657576 f6dab269:30613381 pythonsymbol12:30657548 a9j8j154:30646983 ```

[vscodenpa]

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.75.0. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

[chrmarti]

Continuing in https://github.com/microsoft/vscode-remote-release/issues/7983.