search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
161.05k stars 28.26k forks source link

Support find widget in WebviewViewProvider #173643

Open chouzz opened 1 year ago

chouzz commented 1 year ago

VSCode already has an options(https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.d.ts#L8620) to enable find widget in webview panel, but seems there is no way to enable it via webviewViewProvider(https://github.com/microsoft/vscode/blob/main/src/vscode-dts/vscode.d.ts#L8892)

Hope VSCode can provide an option to enable find widget for WebviewViewProvider!

mjbvz commented 1 year ago

What's the use case?

chouzz commented 1 year ago

The same use case as call hierarchy panel. For myself, I would like to enable find widget to find text in my webview.

mjbvz commented 1 year ago

What type of content does your webview show?

chouzz commented 1 year ago

For myself, I would like to show call hierarchy or find all reference results for symbols. If there are lots of results, find widget should help user find symbols in the panel.

This is the use case for me, but I think there are many other use cases if the panel shows lots of content. It will be very useful.

I could build a find widget by myself, but it's nice if vscode support this built-in, because webview panel supports this option, it makes sense also support for WebviewViewProvider.

mjbvz commented 1 year ago

@chouzz Can you use a tree view instead of a webview view? Call hierarchy and find all references are both good fits for that API

chouzz commented 1 year ago

I can't, my extension should be an alternative to tree view. I would like to implement something like https://yaobinouyang.gallerycdn.vsassets.io/extensions/yaobinouyang/codeatlas/1.3.34/1635120555850/273052/1/main.png

VSCodeTriageBot commented 1 year ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

galenlin commented 1 year ago

@mjbvz Same issue here. My webview show results of adb logcat with textarea by WebViewProvider (contributed to panel), needs a find widget to search specify log.

VSCodeTriageBot commented 1 year ago

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

triwav commented 1 year ago

This feature would be very helpful for the BrightScript Language extension as well.

VSCodeTriageBot commented 1 year ago

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!