microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.46k stars 28.1k forks source link

Pressing enter on list view find widget doesn't navigate to next #174377

Open rebornix opened 1 year ago

rebornix commented 1 year ago

Type: Bug

In all other find widgets, the focus stays in the find widget and moves to next find result, while in list view, it focuses the result, it makes it impossible to navigate between results.

VS Code version: Code - Insiders 1.76.0-insider (Universal) (af4a70d991053dcbf64d9a86c76a02dced81d9c4, 2023-02-14T05:25:12.636Z) OS version: Darwin x64 22.3.0 Modes: Sandboxed: Yes

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|4, 4, 4| |Memory (System)|32.00GB (0.02GB free)| |Process Argv|--enable-proposed-api ms-vscode.vscode-notebook-history --enable-proposed-api vscode.notebook-editing --enable-proposed-api vscode.vscode-test-resolver --enable-proposed-api donjayamanne.kusto --enable-proposed-api donjayamanne.jupyterpowertools --enable-proposed-api rebornix.better-jupyter-errors --enable-proposed-api rchiodo.jupyter-tools --crash-reporter-id 1a907bbd-fa02-4595-81e0-63e1648afb31| |Screen Reader|no| |VM|0%|
Extensions (86) Extension|Author (truncated)|Version ---|---|--- tsl-problem-matcher|amo|0.6.2 comment-tagged-templates|bie|0.3.1 github-markdown-preview|bie|0.3.0 markdown-emoji|bie|0.3.0 markdown-footnotes|bie|0.1.1 markdown-mermaid|bie|1.17.4 markdown-preview-github-styles|bie|1.0.1 vscode-github-actions|csc|0.24.4 vscode-svgviewer|css|2.0.0 vscode-eslint|dba|2.4.0 prettier-java|dot|0.1.1 gitlens|eam|13.2.0 EditorConfig|Edi|0.16.4 vscode-npm-script|eg2|0.3.29 prettier-vscode|esb|9.10.4 codespaces|Git|1.13.8 copilot|Git|1.72.8614 vscode-pull-request-github|Git|0.58.1 go|gol|0.37.1 vscode-graphql|Gra|0.8.5 vscode-graphql-syntax|Gra|1.0.6 vscode-mocha-test-adapter|hbe|2.14.1 vscode-test-explorer|hbe|2.21.1 vscode-drawio|hed|1.6.6 handydandy-notebook|jak|0.1.4 beancount|Len|0.9.1 fluent-icons|mig|0.0.18 vscode-fluent-icons|mig|0.0.1 theme-monokai-pro-vscode|mon|1.2.0 vscode-azurefunctions|ms-|1.10.1 vscode-azureresourcegroups|ms-|0.5.6 vscode-azurestaticwebapps|ms-|0.11.4 vscode-docker|ms-|1.23.3 vscode-language-pack-qps-ploc|MS-|1.75.2023020809 vscode-language-pack-zh-hans|MS-|1.75.2023020809 csharp|ms-|1.25.4 isort|ms-|2022.8.0 python|ms-|2023.3.10411009 vscode-pylance|ms-|2023.2.21 jupyter|ms-|2023.2.1000451018 jupyter-keymap|ms-|1.0.0 jupyter-renderers|ms-|1.0.15 notebook-renderers|ms-|0.0.1 vscode-jupyter-cell-tags|ms-|0.1.6 vscode-jupyter-slideshow|ms-|0.1.5 remote-containers|ms-|0.279.0 remote-ssh|ms-|0.97.2023020215 remote-ssh-edit|ms-|0.84.0 azure-account|ms-|0.11.3 azure-repos|ms-|0.26.0 hexeditor|ms-|1.9.11 js-debug-nightly|ms-|2023.2.317 live-server|ms-|0.5.2023020901 powershell-preview|ms-|2023.2.0 remote-explorer|ms-|0.3.2023020609 remote-repositories|ms-|0.28.0 test-adapter-converter|ms-|0.1.6 vscode-github-issue-notebooks|ms-|0.0.128 vscode-js-profile-flame|ms-|1.0.5 vscode-markdown-notebook|ms-|0.0.26 vscode-notebook-history|ms-|0.0.1 vscode-selfhost-test-provider|ms-|0.3.13 vscode-typescript-tslint-plugin|ms-|1.3.4 vsliveshare|ms-|1.0.5828 debugger-for-chrome|msj|4.13.0 vetur|oct|0.36.1 excalidraw-editor|pom|3.4.0 geo-data-viewer|Ran|2.6.0 vscode-data-preview|Ran|2.3.0 better-jupyter-errors|reb|0.0.1 toggle|reb|0.0.2 typing-practice|reb|0.0.1 vscode-chat-iw|reb|0.0.1 vscode-code-renderer|reb|0.0.2 vscode-xml|red|0.24.0 kuskus-extensions-pack|ros|1.0.10 kuskus-kusto-language-server|ros|1.0.31 kuskus-kusto-syntax-highlighting|ros|1.1.21 vsc-nwjs|rua|1.0.18 swift-lang|ssw|1.0.0 tldraw-vscode|tld|1.27.0 luna-paint|Tyr|0.16.0 vscode-lldb|vad|1.8.1 vscode-swiftlint|vkn|1.8.3 notebook-editing|vsc|1.0.0 vscode-test-resolver|vsc|0.0.1 (7 theme extensions excluded)
A/B Experiments ``` vsliv695:30137379 vsins829:30139715 vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30422396 pythontb:30258533 pythonptprofiler:30281269 vsdfh931cf:30280410 vshan820:30294714 pythondataviewer:30285072 vscod805:30301674 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30404738 cppdebug:30492333 vsclangdf:30492506 c4g48928:30535728 dsvsc012cf:30540253 pynewext54:30618038 pylantcb52:30590116 pyindex848:30611229 nodejswelcome1:30587009 pyind779:30611226 pythonsymbol12:30651887 a9j8j154:30646983 6233i204:30659907 pythonb192cf:30661257 ```
joaomoreno commented 1 year ago

Sadly, list focus doesn't render by default unless the list itself has DOM focus. This means that even if we moved list focus with Enter, it would not be a visible change. I am not really looking forward to changing this UI state. Tempted to close this as designed.

musjj commented 2 months ago

Has there been any changes to this ever since, or at least some workarounds? I'm also experiencing the same issue with ctrl+f in the file explorer view.