search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.74k stars 28.72k forks source link

vscode web incorrectly opens uri resolved from IExternalUriResolver #175164

Open jeanp413 opened 1 year ago

jeanp413 commented 1 year ago

This is related to https://github.com/microsoft/vscode/issues/85930 and https://github.com/microsoft/vscode/issues/140907, there's already a TODO about this in openerService but there's no workaround like in the other cases as the exposed interface only accepts and returns an URI

Steps to repro https://github.com/gitpod-io/gitpod/issues/16494

cc @jrieken

VSCodeTriageBot commented 9 months ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

bpasero commented 9 months ago

@jeanp413 can you clarify if there is a bug or feature request associated to VS Code that will improve VS Code or is this mainly to fix an upstream issue by an unsupported fork of VS Code? Asking because I also see a PR linked to this issue which I would not accept unless it also addresses a real issue in VS Code today.

jeanp413 commented 9 months ago

@bpasero It's an actual issue of vscode, see https://github.com/microsoft/vscode/issues/85930 and https://github.com/microsoft/vscode/issues/140907 as an example, 140907 fix got reverted because it broke vscode and a workaround was pushed instead for the extension api, this issue is about the embedder api

VSCodeTriageBot commented 8 months ago

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!