microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.62k stars 28.67k forks source link

Revert change no longer possible inline #175535

Closed DFelten closed 1 year ago

DFelten commented 1 year ago

Type: Bug

It's no longer possible to revert changes inline. The dialog appears, but when selecting revert change nothing happens.

CleanShot 2023-02-27 at 14 46 33@2x

VS Code version: Code - Insiders 1.76.0-insider (ead95b4a7014d12ddcb2dd6ddcb16e73f1e4cd67, 2023-02-24T22:20:45.098Z) OS version: Darwin arm64 22.3.0 Modes: Sandboxed: Yes

System Info |Item|Value| |---|---| |CPUs|Apple M1 Max (10 x 24)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|8, 8, 8| |Memory (System)|32.00GB (1.18GB free)| |Process Argv|--crash-reporter-id 511166e9-0c5e-4225-a6af-efd2d90c3f8d| |Screen Reader|no| |VM|0%|
Extensions (78) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|3.0.2 codesnap|adp|1.3.4 vscode-m3u|af4|1.0.0 TabOut|alb|0.2.2 Bookmarks|ale|13.3.1 project-manager|ale|12.7.0 flutter-snippets|ale|3.0.0 toggle-excluded-files|eam|1.7.0 clipboard-history|Anj|1.0.7 melos-code|bla|0.6.0 vscode-intelephense-client|bme|1.9.5 ccs-flutter-color|cir|1.0.2 gitignore|cod|0.9.0 php-namespace-resolver|ctf|0.4.3 vscode-mysql-client2|cwe|6.2.2 vscode-mac-color-picker|dae|1.1.0 markdown-table-prettify|dar|3.6.0 dart-code|Dar|3.59.20230214 flutter|Dar|3.58.0 vscode-markdownlint|Dav|0.49.0 githistory|don|0.6.19 gitlens|eam|13.3.1 bloc|Fel|6.6.2 mason|Fel|0.1.10 flutter-coverage|flu|0.0.4 shell-format|fox|7.2.5 copilot|Git|1.75.8985 copilot-labs|Git|0.11.742 vscode-pull-request-github|Git|0.58.2 gitlab-workflow|Git|3.60.0 todo-tree|Gru|0.0.224 terraform|has|2.25.4 json-to-dart|hir|3.5.8 rest-client|hum|0.25.1 monkey-patch|ioc|0.1.23 pubspec-assist|jer|2.3.2 shortcut-menu-bar|jer|3.0.4 intellij-idea-keybindings|k--|1.5.5 indent-to-bracket|LAK|1.2.2 flutter-intl|loc|1.19.1 syntax-project-pbxproj|mar|0.1.3 flutter-snippets|Mar|1.0.5 Kotlin|mat|1.7.1 rainbow-csv|mec|3.5.0 git-graph|mhu|1.30.0 dart-barrel-file-generator|miq|6.0.0 diff-merge|mos|0.7.0 vscode-docker|ms-|1.24.0 vscode-language-pack-de|MS-|1.76.2023022209 remote-containers|ms-|0.281.0 live-server|ms-|0.4.5 vsliveshare-pack|ms-|0.4.0 vscode-flutter-freezed-helper|mth|0.1.0 sqltools|mtx|0.27.1 sqltools-driver-mysql|mtx|0.5.1 awesome-flutter-snippets|Nas|4.0.1 vscode-yaml-sort|Pas|6.4.1 vscode-versionlens|pfl|1.5.0 material-icon-theme|PKi|4.24.0 remove-comments|pli|1.2.2 vscode-thunder-client|ran|2.4.3 vscode-yaml|red|1.11.0 vscode-sort-json|ric|1.20.0 command-variable|rio|1.49.1 flutter-riverpod-snippets|rob|1.2.1 vscode-coverage-gutters|rya|2.10.3 lcov-lang|Ser|1.0.1 swift-lang|ssw|1.1.0 freezed-model-gen|Sus|1.0.1 better-search|tra|0.0.6 errorlens|use|3.7.0 vscode-lldb|vad|1.8.1 vscode-wakatime|Wak|24.0.7 vscode-todo-highlight|way|1.0.5 php-debug|xde|1.32.0 vscode-surround|yat|1.5.0 markdown-all-in-one|yzh|3.5.0 material-theme|zhu|3.15.6 (3 theme extensions excluded)
A/B Experiments ``` vsliv695:30137379 vsins829:30139715 vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492cf:30256198 vslsvsres303:30308271 pythonvspyl392:30422396 pythontb:30258533 vsc_aa:30263845 pythonptprofiler:30281269 vshan820:30294714 pythondataviewer:30285072 vscod805cf:30301675 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30404738 cppdebug:30492333 vsclangdf:30492506 c4g48928:30535728 dsvsc012cf:30540253 pynewext54:30618038 pylantcb52:30590116 pyindex848:30611229 nodejswelcome1:30587009 pyind779:30611226 pythonsymbol12:30651887 showlangstatbar:30659908 pythonb192cf:30661257 pythonms35:30671666 ```
ssoft-wankun commented 1 year ago

SAME

ssoft-wankun commented 1 year ago

when you are using a workspace this may happens.

larshp commented 1 year ago

I've been having similar issues, not using workspaces. With different file types

I think this started after updating to 1.76.0

update: I've seen it both do nothing, and repeating changes

VS Code version: Code 1.76.0 (92da9481c0904c6adfe372c12da3b7748d74bdcb, 2023-03-01T10:22:44.506Z) OS version: Windows_NT x64 10.0.19045 Modes: Sandboxed: Yes

System Info |Item|Value| |---|---| |CPUs|AMD Ryzen 7 5700G with Radeon Graphics (16 x 3800)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|31.30GB (16.63GB free)| |Process Argv|--crash-reporter-id 02afd9d6-9908-4a43-8260-a7532db9d9bb| |Screen Reader|no| |VM|0%|
Extensions (28) Extension|Author (truncated)|Version ---|---|--- vscode-openapi|42C|4.15.16 tsl-problem-matcher|amo|0.6.2 asciidoctor-vscode|asc|2.9.8 asyncapi-preview|asy|0.5.0 vscode-eslint|dba|2.4.0 xml|Dot|2.5.1 EditorConfig|Edi|0.16.4 prettier-vscode|esb|9.10.4 html-preview-vscode|geo|0.2.5 vscode-drawio|hed|1.6.6 cds|hud|0.7.2 rest-client|hum|0.25.1 vscode-env|Iro|0.1.0 vscode-abap|lar|0.5.7 vscode-abap-file-formats|lar|0.1.3 vscode-abaplint|lar|0.6.199 vscode-source-map|lar|0.1.6 vscode-duplicate|mrm|1.2.1 hexeditor|ms-|1.9.11 vsliveshare|ms-|1.0.5832 vscode-abap-remote-fs|mur|1.6.2 winregistry|mur|0.0.1 vscode-versionlens|pfl|1.5.0 vscode-yaml|red|1.11.0 dot|Ste|0.0.1 code-spell-checker|str|2.18.0 pdf|tom|1.2.2 vscode-proto3|zxh|0.5.5
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscorecescf:30445987 pythondataviewer:30285071 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30410667 cppdebug:30492333 vsclangdc:30486549 c4g48928:30535728 dsvsc012cf:30540253 azure-dev_surveyone:30548225 pyindex848:30662994 nodejswelcome1cf:30587006 282f8724:30602487 pyind779:30671433 89544117:30613380 pythonsymbol12:30671437 vsctsb:30662444 pythonb192cf:30669361 funwalk2:30676043 pythonms35cf:30676801 ```
hakula139 commented 1 year ago

In my case, instead of nothing happens, it repeats the last change (but not the expected one).

Before reverting:

image

After reverting:

image
StefanBrand commented 1 year ago

Workaround if you install VSCode on Ubuntu with snap: sudo snap revert code.

lszomoru commented 1 year ago

Closing as duplicate of https://github.com/microsoft/vscode/issues/176051