Open aradalvand opened 1 year ago
gjsjohnmurray
commented
1 year ago I think the adoption needs to be in the opposite direction. The "Visual Studio Dark 2019" theme isn't built-in to VS Code, but contributed by an extension. The authors of that extension could add, say, "Visual Studio Dark 2023“ derived from the new built-in "Dark+ V2".
aradalvand
commented
1 year ago Ah you're right, I didn't realize "Visual Studio Dark 2019" actually belongs to a third-party extension. My bad. It belongs to the OmniSharp extension, it turns out. That said, I think my point still stands.
I think the adoption needs to be in the opposite direction.... The authors of that extension could add, say, "Visual Studio Dark 2023“ derived from the new built-in "Dark+ V2".
They might end up doing that but that's kind of irrelevant to my suggestion here. Besides the fact that the syntax highlighting of that theme doesn't really look great in any other language other than C#.
Why wouldn't the new soon-to-be-default Dark+ V2 theme improve C# syntax highlighting when it's entirely possible and very easily doable? Languages like Rust, etc. have been improved in terms of syntax highlighting in the default VS Code theme over the years, but not C#.
The "Visual Studio Dark 2019" theme has always had much richer C# syntax highlighting than the default Dark+ theme. This is what Dark+ looks like:
This is what the "Visual Studio Dark 2019" theme looks like:
As you can obviously see, things like namespaces, interfaces, object properties, etc. have specific and distinguishable colors in the "Visual Studio Dark 2019" theme.
A new theme has been recently added called "Dark+ V2"; which is an improved version of the old "Dark+" theme.
I think this is a good opportunity to enhance the C# syntax highlighting in VS Code. Especially given that the "Visual Studio Dark 2019" theme has already had better syntax highlighting for a long time, it may be just a matter of copying the relevant rules and pasting them over to Dark+ V2.