microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.79k stars 29.11k forks source link

[Accessibility] Support task completion/failure audio cues in Output #176521

Open jooyoungseo opened 1 year ago

jooyoungseo commented 1 year ago

CC @meganrogge

Many extensions, such as microsoft/vscode-arduino, use Output view and display compile results like below:

image

Could you please support task completion and failure audio cues in output view as well? Currently, it is very tedious to read through the results line by line.

meganrogge commented 1 year ago

Seems like a reasonable request, though I'm not sure what would be involved here. @sandy081 do you think this would be possible?

cc @isidorn

vscodenpa commented 1 year ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

sandy081 commented 1 year ago

Output view uses editor in the background. @alexdima Does the output view has to do anything special to enable accessibility features ?

meganrogge commented 1 year ago

@jooyoungseo , to confirm, are you requesting that the audio gets played when you run the command depending on success or failure?

if so, I think we'd need extension API to support this

jooyoungseo commented 1 year ago

@meganrogge -- Yes, that's exactly correct.

meganrogge commented 1 year ago

@benmcmorran you have more context on what goes on with this particular extension. thoughts on the below?

I spoke with @isidorn and he brought up some great points:

  1. Could the arduino extension use a task for this so that no additional steps are needed for the task failure/success audio cues to happen?
  2. If not, the arduino extension should consider playing our task completion / failure sounds within the extension instead of API. An example of an extension that plays audio cues is Liveshare.
benmcmorran commented 1 year ago

The Arduino extension currently does not use a task for this, but I agree that that would be a sensible refactoring and there are similar requests on the issue tracker (e.g. https://github.com/microsoft/vscode-arduino/issues/1376).

In the short term, I think your second option makes sense.

meganrogge commented 1 year ago

@benmcmorran thanks for your reply. are either of those something you plan to do in the near future? It seems like an important feature