microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.11k stars 28.82k forks source link

drag selection going outside of search box moves caret to document #176523

Open pbaksa opened 1 year ago

pbaksa commented 1 year ago

Type: Bug

When I want to modify the start of a search term in the small search window, my instinct is that I delete by drag-selecting it. This is much quicker than doing shift-home by keyboard. The good thing is it doesn't require precise mouse movement, once the drag-select starts I can finish the selection anywhere left of the search box. After that I can quickly type new text. This worked perfectly until the last update. Now if the mouse moves to the part of the window below breadcrumbs that shows code sctructure, the caret is moved to the document, and my typing goes into the document instead of the search box. If I finish the drag by going down to the document, this doesn't happen (but that is too far down in most cases to be quick).

VS Code version: Code 1.76.0 (92da9481c0904c6adfe372c12da3b7748d74bdcb, 2023-03-01T10:22:44.506Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: Yes

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|30.91GB (15.80GB free)| |Process Argv|c:\\Dev\\BPet-AENG-DEV-FCS\\LibSrc\\BuilderFiles\\... --crash-reporter-id beeacb82-76dc-4358-bba1-7d7debef436f| |Screen Reader|no| |VM|0%|
Extensions (43) Extension|Author (truncated)|Version ---|---|--- overtype|ada|0.2.0 Bookmarks|ale|13.3.1 project-manager|ale|12.7.0 alignment|ann|0.3.0 vscode-color|ans|0.4.5 close-all|ben|1.0.2 docs-view|bie|0.0.11 npm-intellisense|chr|1.4.4 gitignore|cod|0.9.0 vscode-svgviewer|css|2.0.0 vscode-eslint|dba|2.4.0 git-extension-pack|don|0.1.3 githistory|don|0.6.20 xml|Dot|2.5.1 gitlens|eam|13.3.2 vscode-npm-script|eg2|0.3.29 vscode-npm|fkn|3.3.0 vscode-pull-request-github|Git|0.60.0 gdl|Gra|1.26.2 better-cpp-syntax|jef|1.17.2 json-escaper|jos|1.1.2 markdown-viewer|jul|1.0.0 private-extension-manager|jul|1.4.9 guid|kos|0.0.1 rainbow-csv|mec|3.5.0 perforce|mjc|4.15.7 perl-debug|mor|0.6.3 language-gettext|mro|0.2.2 isort|ms-|2022.8.0 python|ms-|2023.4.0 vscode-pylance|ms-|2023.3.10 jupyter|ms-|2023.2.1000592019 jupyter-keymap|ms-|1.1.0 jupyter-renderers|ms-|1.0.15 vscode-jupyter-cell-tags|ms-|0.1.6 vscode-jupyter-slideshow|ms-|0.1.5 cpptools|ms-|1.14.4 hexeditor|ms-|1.9.11 formatdump|pba|0.0.5 tmlanguage|ped|0.12.0 vscode-lldb|vad|1.8.1 vscode-todo-highlight|way|1.0.5 vscode-open-in-github|ziy|1.3.6
A/B Experiments ``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 pythonvspyl392:30443607 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263cf:30335440 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593:30376534 pythonvs932:30410667 cppdebug:30492333 vscaac:30438847 vsclangdc:30486549 c4g48928:30535728 dsvsc012cf:30540253 azure-dev_surveyone:30548225 pyindex848:30662994 nodejswelcome1:30587005 282f8724:30602487 pyind779:30671433 89544117:30613380 pythonsymbol12:30671437 a9j8j154:30646983 vsctsb:30677850 vscodeenable:30660116 pythonb192cf:30669361 ```
amunger commented 9 months ago

dragging text doesn't work at all in find (it always just unexpectedly drops it into the editor), so it should probably just be disabled for that input.