search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.14k stars 29.28k forks source link

will crash after searching at extension panel #177046

Closed HomyeeKing closed 1 month ago

HomyeeKing commented 1 year ago

Does this issue occur when all extensions are disabled?: No

I search something at the extension detail page, then switch the tab, vscode got crash and exit

only can reproduce w/ the search operation(command + f), disable all the extension will be fine

Version: 1.76.1 (Universal)
Commit: 5e805b79fcb6ba4c2d23712967df89a089da575b
Date: 2023-03-08T16:32:09.831Z
Electron: 19.1.11
Chromium: 102.0.5005.196
Node.js: 16.14.2
V8: 10.2.154.26-electron.0
OS: Darwin arm64 22.3.0
Sandboxed: No

Steps to Reproduce:

https://user-images.githubusercontent.com/49113249/224913712-5d54a2cb-d6f4-4a7f-a9da-39e8effca8c1.mov

mjbvz commented 1 year ago

Please explain what that video is showing

vscodenpa commented 1 year ago

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

HomyeeKing commented 1 year ago

I search something at the extension detail page, then switch the tab, vscode got crash and exit

only can reproduce w/ the search operation(command + f), disable all the extension will be fine

bpasero commented 1 year ago

This looks possibly like a crash from the iframe search changes we did?

@HomyeeKing Can you please follow the steps in https://github.com/Microsoft/vscode/wiki/Native-Crash-Issues to get at more details around the crash and attach the result here? Thanks!

cc @deepak1556

HomyeeKing commented 1 year ago

no offend, doesn't the dump file contain some private information？ can you reproduce the issue at local and get the dmp yourself?

bpasero commented 1 year ago

It should not contain private information, for example it does not contain any memory, but @deepak1556 can confirm.

HomyeeKing commented 1 year ago

pending.zip

rzhao271 commented 1 year ago

Looks like there's a regression in the iframe search code symbolicated-58-2.log

rzhao271 commented 1 year ago

Repro steps

  1. In an extension detail view, press Ctrl+F to open the find widget.
  2. Search for some term.
  3. Open another tab.
  4. Switch back to the tab with the extension detail view.
  5. :bug: The program crashes.
jlocans commented 11 months ago

You can reproduce the issue also without switching tabs.

  1. Open any extension details
  2. Search for something in extension details page
  3. Click on a different extension in extension's sidebar.
  4. Crash.

Makes searching for keywords in different extension pages quite frustrating.

softopti commented 10 months ago

Please explain what that video is showing

Do you still need additional information ?

RamyRafik commented 8 months ago

Any updates on this issue?

191962 (Closed as a dupe of this) is giving me a really hard time, specially when it happens while a build/watcher is running.

drasikhov commented 3 months ago

Any updates? It's very annoying bug. Imagine you need to go through long documentation written in markdown:

  1. You open it in the preview mode (either in a new tab or by side).
  2. Try to search for something on preview page.
  3. Switch to some other tab and then switch back to preview.
  4. VSCode crashed.
gjsjohnmurray commented 3 months ago

@rzhao271 I just confirmed that the simple repro in https://github.com/microsoft/vscode/issues/177046#issuecomment-1821088181 still crashes today's Insiders. Perhaps once you're through the current endgame you can take a fresh look at this and try to get it fixed. In my experience it's very rare for VS Code to crash as comprehensively as it does with this repro.

rzhao271 commented 3 months ago

Thanks for the ping. I just noticed that Sandeep closed some duplicates of this issue in the last few months, too. Considering this bug most likely has to do with the patched version of Electron that VS Code uses, I'd like to see if I can get this assigned as a plan item for next iteration.

EhabY commented 1 month ago

Is there a workaround for custom webviews such that VS Code does not crash even when enabling the "Find Widget"?

I don't want to disable this feature since it is very useful for our webviews...

Prateek-Wayne commented 1 month ago

Today I also faced this issue when I open preview for markdown file and then do some search then vs code crashes

rzhao271 commented 1 month ago

The current workaround is to close the find widget before switching away from the Markdown preview to prevent a crash. I am reviewing some implementation details but have not had the time to create a patch in VS Code's Electron yet.

gjsjohnmurray commented 1 month ago

No longer reproducible after Electron 32 bump 👍

Version: 1.95.0-insider Commit: af6645a661a5402af586154207ee2ea3742f3bea Date: 2024-10-04T12:46:44.894Z Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.95.0-insider Chrome/128.0.6613.162 Electron/32.1.2 Safari/537.36

mro95 commented 1 week ago

I'm not sure if this is the same issue, but when I often switch tabs, the whole window will freeze.

Version: 1.94.2 Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427 Date: 2024-10-09T16:08:44.566Z Electron: 30.5.1 ElectronBuildId: 10262041 Chromium: 124.0.6367.243 Node.js: 20.16.0 V8: 12.4.254.20-electron.0 OS: Linux x64 6.11.4-amd64 (wayland)

rzhao271 commented 1 week ago

@mro95 if you mean editor tabs, that definitely sounds like a different issue. Could you file a new issue and attach a gif or video of the issue, please?

0xcoinymous commented 1 week ago

I faced this issue today. when I move between a readme and its preview, the vs code crashed. it happens so many times and still is happening.

gjsjohnmurray commented 1 week ago

@0xcoinymous what version are you using?

0xcoinymous commented 1 week ago

@0xcoinymous what version are you using?

Version: 1.94.2 (system setup) Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427 Date: 2024-10-09T16:08:44.566Z Electron: 30.5.1 ElectronBuildId: 10262041 Chromium: 124.0.6367.243 Node.js: 20.16.0 V8: 12.4.254.20-electron.0 OS: Windows_NT x64 10.0.19045

gjsjohnmurray commented 1 week ago

Please update to the current release, 1.95.1