search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.72k stars 28.15k forks source link

vscode.dev: Support routes in PWA applications #178204

Open 0xcc1e opened 1 year ago

0xcc1e commented 1 year ago

hello, I’m trying to make app shortcut from vscode server in IPadOS, but it redirect to vscode.dev ![Uploading 80A77949-DBEB-4F86-A0B0-3E63E6C4D54F.jpeg…]() 1B681B4A-F652-4028-B05E-3419CB604B5B

bpasero commented 1 year ago

What is the problem here?

0xcc1e commented 1 year ago

hi again, the problem is when I add vscode.dev/tunnel/mytunnelname as pwa in my device, the shortcut will redirect me vscode.dev instead of my own tunnel! as you can see in image the url of shortcut is vscode.dev not vscode.dev/tunnel/mytunnelname.

0xcc1e commented 1 year ago

as I understand the problem is something related to manifest.json and the url specified there.

bpasero commented 1 year ago

I understand. Today the manifest is quite static, in that it has "start_url": "/". I would think the ask here is to somehow respect the specific route a user is on vscode.dev and make the PWA specific to that route. I am not sure this is possible though, having dynamic PWA manifests...