search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.67k stars 29.06k forks source link

Have terminal support Unicode version 14 #178677

Open erf opened 1 year ago

erf commented 1 year ago

I'm working on a terminal app and i noticed that the width of some characters e.g. the red heart emoji "❤️" is only one character, whilst in Unicode 14 it takes up 2 columns, and this messes up the cursor position for me as I'm using a package to calculate the character width based on the latest standard.

I can read in the settings that you only support Unicode version 6 and 11 and would like to suggest that you also support Unicode version 14 (or even 15?).

Relevant setting:

terminal.integrated.unicodeVersion
luv-deluxe commented 1 year ago

@erf In powershell console I have image

but in integrated VS one I see image

Is there a chance it is connected with this issue?

Tyriar commented 1 year ago

Unicode v15 support is likely coming with https://github.com/xtermjs/xterm.js/pull/4519

@luv-deluxe the unicode version only determines the width of the characters, your issue is tracked in https://github.com/xtermjs/xterm.js/issues/2693