search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.71k stars 29.45k forks source link

Enter key does not perform default action anymore #178788

Closed dstpierre closed 1 year ago

dstpierre commented 1 year ago

Type: Bug

Does not navigate to line, now need to use down-arrow to pick the "Go to line" option and than Enter.

Same for opening file:

Does not open file, need to use arrow to "select" first option in list.

VS Code version: Code 1.77.0 (7f329fe6c66b0f86ae1574c2911b681ad5a45d63, 2023-03-29T10:02:16.981Z) OS version: Windows_NT x64 10.0.19044 Modes: Sandboxed: No Remote OS version: Linux x64 5.10.16.3-microsoft-standard-WSL2

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz (4 x 3312)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_renderer: enabled_on
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|undefined| |Memory (System)|15.89GB (8.99GB free)| |Process Argv|--folder-uri=vscode-remote://wsl+Ubuntu-22.04/home/dstpierre/src/remotely/remotely-fm-worker --remote=wsl+Ubuntu-22.04 --crash-reporter-id 7ffcd57e-272c-4083-8aeb-17ee48dd8ae6| |Screen Reader|no| |VM|0%| |Item|Value| |---|---| |Remote|WSL: Ubuntu-22.04| |OS|Linux x64 5.10.16.3-microsoft-standard-WSL2| |CPUs|Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz (4 x 3312)| |Memory (System)|12.39GB (11.51GB free)| |VM|0%|
Extensions (4) Extension|Author (truncated)|Version ---|---|--- codespaces|Git|1.14.2 remote-wsl|ms-|0.77.0 go|gol|0.38.0 volar|Vue|1.2.0
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 pythondataviewer:30285071 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 cmake_vspar411:30581797 vsaa593cf:30376535 pythonvs932:30410667 cppdebug:30492333 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 pynewext54:30695312 azure-dev_surveyone:30548225 vscccc:30610679 nodejswelcome1cf:30587006 2e4cg342:30602488 pyind779:30671433 89544117:30613380 pythonsymbol12:30671437 a9j8j154:30646983 6233i204:30672705 vsccsb:30677849 functionswalk:30687959 pythonms35:30701012 ```
dstpierre commented 1 year ago

seems related to #178782

luke-meadows commented 1 year ago

Same issue here

TylerLeonhardt commented 1 year ago

I can't reproduce this. Can you please attach the contents of your settings.json? Also, do you see "screen reader optimized" in your status bar?

ulugbekna commented 1 year ago

Could you please try the following:

If you are having trouble understanding the output, please feel free to paste here and we'll be happy to help :-)

schwartx commented 1 year ago

I can't reproduce this. Can you please attach the contents of your settings.json? Also, do you see "screen reader optimized" in your status bar?

the same issue. but after i turn off "editor.accessibilitySupport", the problem goes away.

dstpierre commented 1 year ago

@TylerLeonhardt here's my settings, and yes I do use a screen reader / have the screen reader optimized label on status bar.

{
  "security.workspace.trust.enabled": false,
  "editor.accessibilitySupport": "on",

  "editor.cursorStyle": "block",
  "editor.cursorSurroundingLines": 10,
  "editor.renderLineHighlight": "all",
  "editor.insertSpaces": false,
  "editor.tabSize": 2,
  "editor.fontSize": 16,
  "editor.formatOnType": false,
  "editor.rulers": [
    80,
    120
  ],
  "workbench.editor.showTabs": false,
  "search.exclude": {
    "**/node_modules": true,
    "**/bower_components": true,
    "**/vendor": true
  },
  "files.exclude": {
    "**/.git": true,
    "**/.svn": true,
    "**/.hg": true,
    "**/CVS": true,
    "**/.DS_Store": true,
    "**/node_modules": true
  },
  "files.trimTrailingWhitespace": false,
  "files.autoSave": "off",
  "workbench.startupEditor": "newUntitledFile",
  "editor.minimap.enabled": false,
  "[elm]": {
    "editor.formatOnSave": true,
    "editor.insertSpaces": true,
    "editor.tabSize": 4
  },
  "window.menuBarVisibility": "hidden",
  "workbench.colorTheme": "Default High Contrast",
  "window.titleBarStyle": "native",
  "editor.codeLens": false,
  "workbench.colorCustomizations": {
    "editorBracketMatch.background": "#ff0000",
    "editorIndentGuide.activeBackground": "#999999",
    "editorIndentGuide.background": "#666666"
  },
  "go.useLanguageServer": true,
  "go.toolsManagement.autoUpdate": true,
  "[svelte]": {
    "editor.defaultFormatter": "svelte.svelte-vscode"
  },
  "typescript.updateImportsOnFileMove.enabled": "never",
  "emmet.includeLanguages": {
    "erb": "html"
  },
  "[python]": {
    "editor.formatOnType": true
  }
}
dstpierre commented 1 year ago

@ulugbekna here's the output of the Keyboard logger:

2023-04-02 08:49:53.860 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'ms-vscode.vscode-selfhost-test-provider' wants API proposal 'testContinuousRun' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2023-04-02 08:49:53.872 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'ms-vscode.remote-repositories' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2023-04-02 08:49:53.872 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'github.vscode-pull-request-github' wants API proposal 'contribEditorGutterMenu' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2023-04-02 08:49:53.875 [warning] Via 'product.json#extensionEnabledApiProposals' extension 'ms-toolsai.jupyter' wants API proposal 'notebookControllerKind' but that proposal DOES NOT EXIST. Likely, the proposal has been finalized (check 'vscode.d.ts') or was abandoned.
2023-04-02 08:49:55.195 [info] Invoking resolveAuthority(wsl)...
2023-04-02 08:49:55.196 [info] [LocalProcess0][resolveAuthority(wsl,1)][0ms] obtaining proxy...
2023-04-02 08:49:55.196 [info] [LocalProcess0][resolveAuthority(wsl,1)][0ms] invoking...
2023-04-02 08:49:56.201 [info] [LocalProcess0][resolveAuthority(wsl,1)][1004ms] waiting...
2023-04-02 08:49:56.397 [info] [LocalProcess0][resolveAuthority(wsl,1)][1201ms] returned 127.0.0.1:56574
2023-04-02 08:49:56.398 [info] resolveAuthority(wsl) returned '127.0.0.1:56574' after 1202 ms
2023-04-02 08:49:56.401 [info] Creating a socket (renderer-Management-5e0c9e1b-15a6-4f03-9bf9-41520ec56d5f)...
2023-04-02 08:49:56.402 [info] Creating a socket (renderer-ExtensionHost-3e821108-dfca-49bf-96b7-bd77fac6c220)...
2023-04-02 08:49:56.591 [info] Creating a socket (renderer-Management-5e0c9e1b-15a6-4f03-9bf9-41520ec56d5f) was successful after 190 ms.
2023-04-02 08:49:56.847 [info] Creating a socket (renderer-ExtensionHost-3e821108-dfca-49bf-96b7-bd77fac6c220) was successful after 444 ms.
2023-04-02 08:49:56.985 [warning] [Vue.volar]: Cannot register 'typescript.tsdk'. This property is already registered.
2023-04-02 08:49:58.285 [info] [perf] Render performance baseline is 55ms
2023-04-02 08:50:27.715 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-04-02 08:50:27.716 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-04-02 08:50:27.717 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2023-04-02 08:50:27.717 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2023-04-02 08:50:27.717 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-04-02 08:50:27.865 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-04-02 08:50:27.866 [info] [KeybindingService]: | Resolving ctrl+P
2023-04-02 08:50:27.867 [info] [KeybindingService]: \ From 2 keybinding entries, matched workbench.action.quickOpen, when: no when condition, source: built-in.
2023-04-02 08:50:27.868 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: KeyP, keyCode: 80, key: p
2023-04-02 08:50:27.869 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: KeyP, keyCode: 46 ('P')
2023-04-02 08:50:27.869 [info] [KeybindingService]: | Resolving ctrl+P
2023-04-02 08:50:27.870 [info] [KeybindingService]: \ From 2 keybinding entries, matched workbench.action.quickOpen, when: no when condition, source: built-in.
2023-04-02 08:50:27.871 [info] [KeybindingService]: + Invoking command workbench.action.quickOpen.
2023-04-02 08:50:28.041 [info] [KeybindingService]: + Ignoring single modifier ctrl due to it being pressed together with other keys.
2023-04-02 08:50:28.604 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyM, keyCode: 77, key: m
2023-04-02 08:50:28.605 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyM, keyCode: 43 ('M')
2023-04-02 08:50:28.605 [info] [KeybindingService]: | Resolving M
2023-04-02 08:50:28.606 [info] [KeybindingService]: \ From 1 keybinding entries, no when clauses matched the context.
2023-04-02 08:50:28.705 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyA, keyCode: 65, key: a
2023-04-02 08:50:28.706 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyA, keyCode: 31 ('A')
2023-04-02 08:50:28.706 [info] [KeybindingService]: | Resolving A
2023-04-02 08:50:28.707 [info] [KeybindingService]: \ No keybinding entries.
2023-04-02 08:50:28.823 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyI, keyCode: 73, key: i
2023-04-02 08:50:28.824 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyI, keyCode: 39 ('I')
2023-04-02 08:50:28.824 [info] [KeybindingService]: | Resolving I
2023-04-02 08:50:28.825 [info] [KeybindingService]: \ No keybinding entries.
2023-04-02 08:50:28.911 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyN, keyCode: 78, key: n
2023-04-02 08:50:28.912 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyN, keyCode: 44 ('N')
2023-04-02 08:50:28.912 [info] [KeybindingService]: | Resolving N
2023-04-02 08:50:28.912 [info] [KeybindingService]: \ No keybinding entries.
2023-04-02 08:50:29.415 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: Period, keyCode: 190, key: .
2023-04-02 08:50:29.415 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: Period, keyCode: 84 ('.')
2023-04-02 08:50:29.415 [info] [KeybindingService]: | Resolving .
2023-04-02 08:50:29.416 [info] [KeybindingService]: \ No keybinding entries.
2023-04-02 08:50:29.665 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyG, keyCode: 71, key: g
2023-04-02 08:50:29.666 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyG, keyCode: 37 ('G')
2023-04-02 08:50:29.667 [info] [KeybindingService]: | Resolving G
2023-04-02 08:50:29.667 [info] [KeybindingService]: \ No keybinding entries.
2023-04-02 08:50:29.756 [info] [KeybindingService]: / Received  keydown event - modifiers: [], code: KeyO, keyCode: 79, key: o
2023-04-02 08:50:29.756 [info] [KeybindingService]: | Converted keydown event - modifiers: [], code: KeyO, keyCode: 45 ('O')
2023-04-02 08:50:29.757 [info] [KeybindingService]: | Resolving O
2023-04-02 08:50:29.757 [info] [KeybindingService]: \ No keybinding entries.

Like I said, simple CTRL+P, typing file name, ENTER before it worked, now I have to manually select the first item in the list.

Same for the Developer: Toggle Key... you have me tried, I did CTRL+SHIFT+P and typed to filter the list did Enter, nope I have to manually select the item.

Unusable I'd say.

TylerLeonhardt commented 1 year ago

/duplicate https://github.com/microsoft/vscode/issues/176081

vscodenpa commented 1 year ago

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!