microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.01k stars 29.2k forks source link

Allow display prop on markdown span style #180496

Open yoavbls opened 1 year ago

yoavbls commented 1 year ago

Style attribute added to span tags in https://github.com/microsoft/vscode/pull/97793 Currently, it allows setting color and background-color but many times the background color doesn't apply because span is display: inline by default and doesn't have an actual width and height. Adding display prop to the allowed styles will fix that and also will open up many other (safe) options for layoutting.

e.g, in pretty-ts-errors I had to use codicon classes to apply background-color and make things inlined. That classes bring unwanted styles like user-select: none that prevent selecting and copying the content. Now it's a huge deal for tens of thousands of developers that can't copy the types from their errors.

CleanShot 2023-04-21 at 13 37 42@2x

I know that no one wants to keep adding styles to the sanitized regex and it opens the barrier for other requests like this but display prop is different. It is not a niche CSS prop, it is one of the most essential props in CSS and one of the few things that markdown can't do.

I made a pull request that add it, I hope it helps: https://github.com/microsoft/vscode/pull/180498

yoavbls commented 1 year ago

Hi there! I just wanted to mention that JetBrains released their alternative solution and their code blocks are copyable.

CleanShot 2023-07-29 at 19 40 35@2x

We don't want to stay behind, It could be so nice if you'll approve this little line in my PR 🙏🏼 https://github.com/microsoft/vscode/pull/180498/files

vscodenpa commented 10 months ago

:slightly_smiling_face: This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

Number-3434 commented 2 months ago

Any new updates yet??