microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.26k stars 29.3k forks source link

Accessibility: Make Tab key focus restricted to the currently open view #181139

Open jooyoungseo opened 1 year ago

jooyoungseo commented 1 year ago

CC @meganrogge and @isidorn

For blind users, overlaid views might be very confusing if they lack distinct focus boundaries.

I believe pressing the Tab/Shift+Tab keys within Ctrl+F should remain in this view and cycle through related controls, unless users explicitly close the view.

Ctrl+F view is just one of the examples.

Current Behavior

Consecutive Tab/Shift+Tab presses fall to the editor area.

Expected/Suggested Behavior

Tab key focus is restricted to the currently open view.

Related Resource

https://stackoverflow.com/questions/50178419/how-can-restrict-the-tab-key-press-only-within-the-modal-popup-when-its-open

meganrogge commented 1 year ago

I believe we have historically wanted to make tabbing flow all the way through the app. As such, I am wondering if this would be disruptive to muscle memory. Would we do this in other components - like the panel - as well?

@isidorn thoughts?

isidorn commented 1 year ago

@meganrogge correct. The idea of tab navigation is to allow users to go all the way through the app.

I suggest that we leave this open as a feature request and see if we get similar feedback from other users.

meganrogge commented 1 year ago

@jooyoungseo now that we tried this with the terminal (with limited success), do you think we can close this?

I believe that managing tab focus mode for each scope is a little confusing

jooyoungseo commented 9 months ago

@meganrogge This is what I discussed in our last meeting.