search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.87k stars 29.15k forks source link

First terminal does not follow default. #181515

Closed tbenthompson closed 1 year ago

tbenthompson commented 1 year ago

Does this issue occur when all extensions are disabled?: Yes/No

Steps to Reproduce:

  1. Open a new VSCode window using Codespaces.
  2. The initial terminal window opens a bash terminal. If I kill that terminal and open a new terminal, I get zsh as expected.

I have in my settings.json:

  "terminal.integrated.defaultProfile.linux": "zsh",

I believe this is a duplicate of these closed issues:

Tyriar commented 1 year ago

I was expecting this would get fixed as part of https://github.com/microsoft/vscode/pull/175844, cc @jeanp413

jeanp413 commented 1 year ago

@Tyriar It got reopened by Alex, but it only repros using codespaces extension now, before I was able to repro with test resovler extension and remote ssh extension which works as expected now, not sure what's special about codespaces extension as the remote connection logic is the same :thinking:

jeanp413 commented 1 year ago

Ah I can repro now, will take a look, it's because codespaces takes > 20s to resolve the remote

Edit: There's a this._profilesReadyBarrier = new AutoOpenBarrier(20000); :laughing:

jeanp413 commented 1 year ago

PR https://github.com/microsoft/vscode/pull/181832

Tyriar commented 1 year ago

/duplicate https://github.com/microsoft/vscode/issues/175107