search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.39k stars 28.62k forks source link

Signing in does not work for tunnels on insiders.vscode.dev #183792

Closed hediet closed 1 year ago

hediet commented 1 year ago

Testing #183698

I ran code-insiders tunnel and then opened the link that was printed. Then I was prompted to log in to github:

chrome_Ai7zOmjlDS

Generally signing in works, so it seems like a tunnel issue:

chrome_XL5vgkM3yN

aeschli commented 1 year ago

Opening a tunnel triggers the login flow, but it looks like the tunnel does not react to the login being complete. I tested that opening a tunnel works when doing from the remote explorer. There. the login happens first (in order to show all available tunnels).After that oping a tunnel succeeds.

connor4312 commented 1 year ago

This looks like a problem in the GH auth extension (or potentially GH side) as it did not detect access was granted, cc @TylerLeonhardt. Btw, tunnels now uses the standard auth flow via the GH auth extension rather than the embedder side auth with the introduction of web resolvers.

TylerLeonhardt commented 1 year ago

/duplicate https://github.com/microsoft/vscode/issues/182217

they also see with Codespaces.

VSCodeTriageBot commented 1 year ago

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

TylerLeonhardt commented 1 year ago

Workaround is to open https://insiders.vscode.dev install the Remote Tunnels extension if it's not installed, and then open the Remote explorer and sign in to Remote Tunnels first.