search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.89k stars 29.17k forks source link

Nonce does not appear to work on fish shell #183972

Open connor4312 opened 1 year ago

connor4312 commented 1 year ago

Testing https://github.com/microsoft/vscode/issues/181522

Other shells are okay, but fish shell did not appear to have a nonce, and prompted for confirmation when rerunning a command

image
Tyriar commented 1 year ago

@connor4312 do you have an old shell integration setup in your ~/.config/fish/fish.config?

connor4312 commented 1 year ago

I don't think so, these are its contents:

if status is-interactive
    # Commands to run in interactive sessions can go here
end
set -gx VOLTA_HOME "$HOME/.volta"
set -gx PATH "$VOLTA_HOME/bin" $PATH
Tyriar commented 11 months ago

Code pointer:

https://github.com/microsoft/vscode/blob/d70a46b6bd65aade0248f900a6e67a85f1c2cde2/src/vs/workbench/contrib/terminal/browser/media/fish_xdg_data/fish/vendor_conf.d/shellIntegration.fish#L64-L68

To verify/reproduce this:

  1. Open fish shell, make sure shell integration is enabled
  2. Run a command
  3. Click the blue circle to the left of the prompt and select Rerun Command, 🐛 it should run immediately and not show a confirmation dialog