search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
161.92k stars 28.46k forks source link

git bash terminal is acting wierd in vscode #184719

Closed Tom89757 closed 1 year ago

Tom89757 commented 1 year ago

Does this issue occur when all extensions are disabled?: Yes

Version: 1.80.0-insider (user setup) Commit: db6bcdf309cc1565c502a54b73c33a63bdabfbd8 Date: 2023-06-09T05:21:13.157Z Electron: 22.5.5 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.19045

Steps to Reproduce:

  1. install oh-my-zsh according to install zsh windows git bash with plugins=(extract zsh-autosuggestions zsh-syntax-highlighting wd sudo z tldr).
  2. use p10k theme as my zsh theme.
  3. everything is ok when I open and use a git bash terminal prompt.
  4. my git bash terminal is acting wierd when I use it as my vscode terminal. When I type some word, backspace, and retype some characters, it acts like below: image It's a bit similiar like My terminal is acting weird in vs-code, there is a space between every character?, but different.

Thank you for your reply.

SergioChizhikov commented 1 year ago

I see a similar problem when upgrading to version 1.79

Version: 1.78.2 (user setup) Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435 Date: 2023-05-10T14:39:26.248Z Electron: 22.5.2 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.19044 Sandboxed: Yes

Before (version 1.78.2 ): 2023-06-09 19_21_56-template_main php - flagf - Visual Studio Code After upgrade:

2023-06-09 19_38_47-Release Notes_ 1 79 0 - flagf - Visual Studio Code

meganrogge commented 1 year ago

does disabling shell integration fix it? terminal.integrated.shellIntegration.enabled

Tom89757 commented 1 year ago

does disabling shell integration fix it? terminal.integrated.shellIntegration.enabled

disabling "terminal.integrated.shellIntegration.enabled" or "terminal.integrated.shellIntegration.decorationsEnabled" or both does not work. Besides, using wsl2 (Ubuntu) with oh-my-zsh works.

Tom89757 commented 1 year ago

new wierd actions. I keep typing l and s, some [?1 appears. I keep typing f, cursor jumps to new line before line end. image

Tom89757 commented 1 year ago

Maybe I can turn to use wsl as my default terminal. I have tried for a while and it satisfies my need well. Thanks for your reply

meganrogge commented 1 year ago

does this reproduce in windows terminal?

meganrogge commented 1 year ago

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to our code. As such, I will go ahead and close it. Please try to reproduce in Windows Terminal and report to microsoft/terminal with repro steps.

If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here. Thanks for understanding.

/label upstream terminal-conpty windows

Tom89757 commented 1 year ago

does this reproduce in windows terminal?

Windows terminal means cmd or powershell? I don't know if powershell or cmd can install oh-my-zsh but I'll try.

Tom89757 commented 1 year ago

does this reproduce in windows terminal?

Windows terminal means cmd or powershell? I don't know if powershell or cmd can install oh-my-zsh but I'll try.

if you means wsl2, it works well.

Tyriar commented 1 year ago

@Tom89757 there's a link to Windows Terminal in the comment above.

Tom89757 commented 1 year ago

@Tom89757 there's a link to Windows Terminal in the comment above.

Thanks for your reply. I understand what you mean. I update my git from 2.33 to 2.41 and add it to windows terminal. It works well in terminal and also in vscode. It seems to be a git version issue.