microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
160.88k stars 28.23k forks source link

Hover Color Setting Affects Both File Explorer and Notifications #185074

Open DevArqSangoi opened 1 year ago

DevArqSangoi commented 1 year ago

Type: Bug

1) Open the settings.json file in VS Code.

2) Add a color customization for "list.hoverBackground" within "workbench.colorCustomizations". For example: "workbench.colorCustomizations": { "list.hoverBackground": "#ff0000" }

3) Hover over items in the File Explorer and the Toast Notifications that slide up from the bottom-right of the workbench. Observe that the hover background color is the same for both.

Expected result: The hover of the Notifications should be configurable separately from the File Explorer hover, possibly through a separate "notifications." color configuration group.

Actual result: The set hover color affects both the File Explorer and the Toast Notifications, making it impossible to style them independently.

VS Code version: Code 1.79.1 (4cb974a7aed77a74c7813bdccd99ee0d04901215, 2023-06-12T16:14:05.102Z) OS version: Windows_NT x64 10.0.22621 Modes: Unsupported

System Info |Item|Value| |---|---| |CPUs|AMD Ryzen 9 5950X 16-Core Processor (32 x 3400)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|31.91GB (17.37GB free)| |Process Argv|--crash-reporter-id 9c3f3097-a467-458a-8bdf-330f26ad959c| |Screen Reader|no| |VM|0%|
Extensions: none
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492:30256859 vslsvsres303:30308271 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscorecescf:30445987 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 pythonvs932:30410667 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 pynewext54:30695312 azure-dev_surveyone:30548225 282f8724:30602487 pyind779:30671433 f6dab269:30613381 pythonsymbol12:30671437 showlangstatbar:30737416 vsctsb:30748421 pythonms35:30701012 03d35959:30757346 pythonfmttext:30731395 pythoncmvfstrcf:30756944 f8hc8238:30694864 fixhidewlkth:30730051 hideindicator:30766889 pythongtdpath:30739704 dh2dc718:30763024 pythonnosm12tcf:30765602 ```
daviddossett commented 1 year ago

I think that's intentional but tagging @bpasero for any other input.

bpasero commented 1 year ago

Not really intentional but simply not implemented. We use lists in 100 components of our UI and I think when you change a generic color for the list, it will apply to all 100 components unless these have specific overrides. I would not be surprised if there are other cases like this one.

javifm86 commented 1 month ago

I think it would be nice to have that override, I think notification component have enough importance. I created a theme and I would like to increase the contrast in notifications when user hovering, but I don't want to mess the other 99 components (file explorer for example). It is not a big deal but it would be nice to have it.