microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.35k stars 28.91k forks source link

Allow theme specific config for `editor.rulers` #185131

Closed sedrubal closed 1 year ago

sedrubal commented 1 year ago

It is already possible to have language specific options for editor.rulers:

  "[git-commit]": {
    "editor.rulers": [
      {
        "column": 72,
        "color": "#F00"
      },
    ]
  },

It would be great to allow theme specific settings like this:

  "[Default Dark Modern]": {
    "editor.rulers": [
      {
        "column": 80,
        "color": "#540"
      },
      {
        "column": 100,
        "color": "#530"
      },
      {
        "column": 120,
        "color": "#520"
      }
    ]
  },
  "[Default Light Modern]": {
    "editor.rulers": [
      {
        "column": 80,
        "color": "#FED"
      },
      {
        "column": 100,
        "color": "#FDC"
      },
      {
        "column": 120,
        "color": "#FCB"
      }
    ]
  },
Tyriar commented 1 year ago

@hediet maybe we should we have rulerNColor theme keys?

vscodenpa commented 1 year ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vscodenpa commented 1 year ago

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

vscodenpa commented 1 year ago

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!