search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.74k stars 29.1k forks source link

`security.allowedUNCHosts`: Should not be case sensitive #185309

Closed schittli closed 1 year ago

schittli commented 1 year ago

Type: Bug

Hello

of course (at least on Windows, but probably on Linux, too), UNC Paths are not case sensitive. You will connect to exactly the same Share with those UNC Paths: (Note upper case S and lower case s) \\Server\share \\server\share

Therefore, security.allowedUNCHosts should not be case sensitive, too, but it is:

  1. If a File is opened in vscode and uses the UNC-Path \\Server\share\file
  2. and you add "security.allowedUNCHosts": [ "server" ]
  3. then vscode will keep reporting that Sever is not found in allowedUNCHosts on startup.

Thanks a lot, kind regards, Thomas

VS Code version: Code 1.78.2 (b3e4e68a0bc097f0ae7907b217c1119af9e03435, 2023-05-10T14:39:26.248Z) OS version: Windows_NT x64 10.0.19045 Modes: Sandboxed: No

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz (16 x 2304)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|63.71GB (47.46GB free)| |Screen Reader|no| |VM|0%|
Extensions (63) Extension|Author (truncated)|Version ---|---|--- Bookmarks|ale|13.3.1 vscode-color|ans|0.4.5 asciidoctor-vscode|asc|2.9.8 export-your-extensions|Bha|1.0.2 insert-unicode|bru|0.14.0 vscode-better-align|cho|1.4.2 vscode-html-css|ecm|1.13.1 prettier-vscode|esb|9.13.0 change-case|Fin|0.0.6 outline-map|Ger|1.0.1 todo-tree|Gru|0.0.226 helium-icon-theme|hel|1.0.0 expand-region-vue|hua|0.1.27 Ionide-fsharp|Ion|7.7.0 better-shellscript-syntax|jef|1.6.1 vscode-todo-highlight|jgc|2.0.8 intellij-idea-keybindings|k--|1.5.9 expand-region|let|0.1.4 regionfolder|map|1.0.22 themeinfo|McN|0.11.0 rainbow-csv|mec|3.7.0 csharp|ms-|1.25.9 dotnet-interactive-vscode|ms-|1.0.4313020 vscode-dotnet-pack|ms-|1.0.12 isort|ms-|2022.8.0 python|ms-|2023.8.0 vscode-pylance|ms-|2023.6.20 jupyter|ms-|2023.4.1011241018 jupyter-keymap|ms-|1.1.0 jupyter-renderers|ms-|1.0.15 vscode-jupyter-cell-tags|ms-|0.1.8 vscode-jupyter-slideshow|ms-|0.1.5 powershell|ms-|2023.6.0 tmlanguage|ped|0.13.0 explorer-exclude|Pet|1.3.2 themestar|Pix|1.1.1 material-icon-theme|PKi|4.28.0 vscode-css-peek|pra|4.2.0 pester-test|psp|2023.4.0 text-power-tools|qcz|1.40.2 panda-lang|RoR|0.0.1 highlight-words|rsb|0.1.4 codeui|rya|1.1.0 text-marker|ryu|1.11.0 multi-command|ryu|1.6.0 vscode-extensions-explorer|san|1.0.33 vscode-theme-quick-switch|San|0.1.3 code-settings-sync|Sha|3.4.3 whichthemeisthat|sja|0.0.1 auto-comment-blocks|sty|1.1.1 vscode-inline-bookmarks|tin|0.1.0 mindcode|Tom|0.0.3 vscode-counter|uct|3.2.1 errorlens|use|3.11.1 highlight-logical-line|use|0.1.0 intellicode-api-usage-examples|Vis|0.2.7 vscodeintellicode|Vis|1.2.30 vscode-icons|vsc|12.4.0 gistfs|vsl|0.4.1 crs-al-language-extension|wal|1.5.25 vscode-jumpy|wma|0.3.1 material-theme|zhu|3.15.17 open-in-other-group|zop|0.1.0 (22 theme extensions excluded)
vscodenpa commented 1 year ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

bpasero commented 1 year ago

It is, since: https://github.com/microsoft/vscode/issues/182277

Restart to see the effect after changing the setting.