microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.44k stars 29.35k forks source link

No color on suggest icon with ipynb #186905

Open LYB030 opened 1 year ago

LYB030 commented 1 year ago

Does this issue occur when all extensions are disabled?: Yes/No

version: 1.79.2 (user setup) : 695af097c7bd098fbf017ce3ac85e09bbc5dda06 日期: 2023-06-14T08:57:04.379Z Electron: 22.5.7 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Windows_NT x64 10.0.22621

Steps to Reproduce:

image you can see this is no color in suggest icon even the lightbulb is no yellow,but it work fine in .py file: image

rebornix commented 1 year ago

It might be list view color override

LYB030 commented 1 year ago

It might be list view color override

do you mean the theme color of vscode?

rebornix commented 1 year ago

This is yet another issue with list widget's css rules being too generic. With the introduction of https://github.com/microsoft/vscode/commit/f07184772ad02eaa06ab1641714deee2bbb3853f#diff-a1e616a504f30625266d85e2b1c082a0e4811404775786b684aa1dbfcef19422 , we always set all codicon to be "inactive" if it's inside a focused list item, other than asking each list view user to set the CSS rules themselves. This means when we have nested list view, all inner list view's codicon's color are removed.

In this issue, we have a suggest widget inside a monaco editor, which is embedded in a list item. The css rules being applied:

.monaco-list .monaco-list-row.focused .codicon {
    color: var(--vscode-list-inactiveSelectionIconForeground);
}

.monaco-editor .codicon.codicon-symbol-constructor, .monaco-workbench .codicon.codicon-symbol-constructor {
    color: var(--vscode-symbolIcon-constructorForeground);
}

Unfortunately .monaco-list .monaco-list-row.focused .codicon always takes effect ;( @joaomoreno any suggestion for how we can handle this properly, from https://github.com/microsoft/vscode/issues/126514 it doesn't seem to be trivial at all.

rille111 commented 4 months ago

Still same issue. No colors of method, properties when coding Python in notebook files ..

kingkong404 commented 3 months ago

Also having this issue.

mjbvz commented 2 months ago

Main suggest icon colors should be fixed by https://github.com/microsoft/vscode/pull/228173

Image

Need to confirm but I think the lightbulb is still incorrectly colored