search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.51k stars 28.65k forks source link

Fish shell colors broken with latest update #187803

Closed gkatsanos closed 1 year ago

gkatsanos commented 1 year ago

Does this issue occur when all extensions are disabled?: Yes/No

Welcome to fish, the friendly interactive shell
Type help for instructions on how to use fish
set_color: Unknown color 'py[learning]'
set_color: Unknown color '~/r/v/requests-frontend'
set_color: Unknown color 'py[learning]'
set_color: Unknown color '~/r/v/requests-frontend'
set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '
set_color: Unknown color '~/r/v/requests-frontend'
set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '
set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '
fish -v
fish, version 3.6.1
Tyriar commented 1 year ago

Can you try enabling trace logging mode (F1 > Set Log Level > Trace) and pasting in the content from the "Terminal" channel in the Output panel? This will tell us what the shell process is telling the terminal to do which will identify whether it's an issue with rendering or the process telling us the wrong thing.

/label "info-needed"

gkatsanos commented 1 year ago

@Tyriar 

2023-07-14 10:57:19.482 [trace] terminalMultiLineLinkDetector#detect text ["Welcome to fish, the friendly interactive shell"]
2023-07-14 10:57:19.482 [trace] terminalLocalLinkDetector#detect text ["Welcome to fish, the friendly interactive shell"]
2023-07-14 10:57:19.482 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:19.483 [trace] terminalMultiLineLinkDetector#detect text ["Type help for instructions on how to use fish"]
2023-07-14 10:57:19.483 [trace] terminalLocalLinkDetector#detect text ["Type help for instructions on how to use fish"]
2023-07-14 10:57:19.483 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:19.485 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:19.485 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:19.485 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:19.492 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:19.492 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:19.493 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:19.493 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:19.501 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:19.501 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:19.501 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:19.509 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:19.509 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:19.509 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:19.509 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:19.518 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:19.518 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:19.518 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:19.534 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:19.534 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:19.534 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:19.543 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:19.543 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:19.543 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:19.560 [trace] terminalMultiLineLinkDetector#detect text ["    set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:19.560 [trace] terminalLocalLinkDetector#detect text ["    set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:19.560 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:20.851 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:20.851 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:20.851 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:20.886 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:20.886 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:20.887 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:21.172 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:21.172 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:21.173 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:21.173 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:21.192 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:21.192 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:21.192 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:21.217 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:21.218 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:21.218 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:21.218 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:21.234 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:21.234 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:21.234 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:21.261 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:21.261 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:21.261 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:21.261 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:21.496 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:21.496 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:21.497 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:21.518 [trace] terminalMultiLineLinkDetector#detect text ["Type help for instructions on how to use fish"]
2023-07-14 10:57:21.518 [trace] terminalLocalLinkDetector#detect text ["Type help for instructions on how to use fish"]
2023-07-14 10:57:21.519 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:21.543 [trace] terminalMultiLineLinkDetector#detect text ["Welcome to fish, the friendly interactive shell"]
2023-07-14 10:57:21.544 [trace] terminalLocalLinkDetector#detect text ["Welcome to fish, the friendly interactive shell"]
2023-07-14 10:57:21.544 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:22.162 [trace] terminalInstance#dispose (instanceId: 1) []
2023-07-14 10:57:22.209 [debug] Terminal process exit ["instanceId",1,"code",null,"processState",5]
2023-07-14 10:57:23.522 [trace] terminalInstance#ctor (instanceId: 2) [{}]
2023-07-14 10:57:23.536 [debug] Unbinding from mouse events. []
2023-07-14 10:57:23.539 [debug] Buffer content tracker: [0," lines cached"]
2023-07-14 10:57:23.539 [debug] Viewport content update complete,  [0," lines in the viewport"]
2023-07-14 10:57:23.539 [debug] Buffer content tracker: set  [0," lines"]
2023-07-14 10:57:23.559 [trace] Webgl was loaded []
2023-07-14 10:57:23.633 [debug] Buffer content tracker: [0," lines cached"]
2023-07-14 10:57:23.633 [debug] Viewport content update complete,  [0," lines in the viewport"]
2023-07-14 10:57:23.633 [debug] Buffer content tracker: set  [0," lines"]
2023-07-14 10:57:23.637 [debug] terminalInstance added capability [1]
2023-07-14 10:57:23.667 [debug] Terminal process ready (shellProcessId: 57690) []
2023-07-14 10:57:23.667 [debug] terminalInstance added capability [3]
2023-07-14 10:57:24.548 [debug] parsing data "Welcome to fish, the friendly interactive shell
Type help(B for instructions on how to use fish
" [[87,101,108,99,111,109,101,32,116,111,32,102,105,115,104,44,32,116,104,101,32,102,114,105,101,110,100,108,121,32,105,110,116,101,114,97,99,116,105,118,101,32,115,104,101,108,108,13,10,84,121,112,101,32,27,91,51,50,109,104,101,108,112,27,40,66,27,91,109,32,102,111,114,32,105,110,115,116,114,117,99,116,105,111,110,115,32,111,110,32,104,111,119,32,116,111,32,117,115,101,32,102,105,115,104,13,10]]
2023-07-14 10:57:24.554 [debug] parsing data "[?2004h" [[27,91,63,50,48,48,52,104]]
2023-07-14 10:57:24.554 [debug] parsing data "]633;P;Cwd=/Users/gkatsanos/repos/visable/requests-frontend" [[27,93,54,51,51,59,80,59,67,119,100,61,47,85,115,101,114,115,47,103,107,97,116,115,97,110,111,115,47,114,101,112,111,115,47,118,105,115,97,98,108,101,47,114,101,113,117,101,115,116,115,45,102,114,111,110,116,101,110,100,7]]
2023-07-14 10:57:24.554 [debug] terminalInstance added capability [0]
2023-07-14 10:57:24.555 [debug] parsing data "]633;D" [[27,93,54,51,51,59,68,7]]
2023-07-14 10:57:24.555 [debug] terminalInstance added capability [2]
2023-07-14 10:57:24.556 [debug] CommandDetectionCapability#handleCommandFinished [0,2,null,{"commandFinishedMarker":{"line":2,"isDisposed":false,"_disposables":[{"_listeners":[null],"_disposed":false},{},{},{},{}],"_id":11,"_onDispose":{"_listeners":[null],"_disposed":false}}}]
2023-07-14 10:57:24.645 [debug] parsing data "set_color: Unknown color 'py[learning]'
" [[115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,112,121,91,108,101,97,114,110,105,110,103,93,39,13,10]]
2023-07-14 10:57:24.646 [debug] parsing data "set_color: Unknown color '~/r/v/requests-frontend'
set_color: Unknown color 'py[learning]'
" [[115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,126,47,114,47,118,47,114,101,113,117,101,115,116,115,45,102,114,111,110,116,101,110,100,39,13,10,115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,112,121,91,108,101,97,114,110,105,110,103,93,39,13,10]]
2023-07-14 10:57:24.646 [debug] parsing data "set_color: Unknown color '~/r/v/requests-frontend'
" [[115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,126,47,114,47,118,47,114,101,113,117,101,115,116,115,45,102,114,111,110,116,101,110,100,39,13,10]]
2023-07-14 10:57:24.692 [debug] parsing data "set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '
set_color: Unknown color '~/r/v/requests-frontend'
set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '
" [[115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,57504,32,69,88,80,76,45,51,50,57,49,45,105,109,112,108,101,109,101,110,116,105,110,103,45,69,80,45,108,97,110,100,105,110,103,45,112,97,103,101,32,39,13,10,115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,126,47,114,47,118,47,114,101,113,117,101,115,116,115,45,102,114,111,110,116,101,110,100,39,13,10,115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,57504,32,69,88,80,76,45,51,50,57,49,45,105,109,112,108,101,109,101,110,116,105,110,103,45,69,80,45,108,97,110,100,105,110,103,45,112,97,103,101,32,39,13,10]]
2023-07-14 10:57:24.692 [debug] parsing data "set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '
" [[115,101,116,95,99,111,108,111,114,58,32,85,110,107,110,111,119,110,32,99,111,108,111,114,32,39,57504,32,69,88,80,76,45,51,50,57,49,45,105,109,112,108,101,109,101,110,116,105,110,103,45,69,80,45,108,97,110,100,105,110,103,45,112,97,103,101,32,39,13,10]]
2023-07-14 10:57:24.693 [debug] parsing data "]0;~/r/v/requests-frontend(B
" [[27,93,48,59,126,47,114,47,118,47,114,101,113,117,101,115,116,115,45,102,114,111,110,116,101,110,100,7,27,91,51,48,109,27,40,66,27,91,109,13]]
2023-07-14 10:57:24.693 [debug] parsing data "]633;A(B  (B (B(B (B]633;B
" [[27,93,54,51,51,59,65,7,27,40,66,27,91,109,32,32,27,40,66,27,91,109,32,27,40,66,27,91,109,27,40,66,27,91,109,32,27,40,66,27,91,109,27,93,54,51,51,59,66,7,27,91,75,13,27,91,52,67]]
2023-07-14 10:57:24.693 [debug] CommandDetectionCapability#handlePromptStart [0,10]
2023-07-14 10:57:24.694 [debug] CommandDetectionCapability#handleCommandStart [4,10]
2023-07-14 10:57:25.328 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:25.330 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:25.330 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:25.387 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:25.388 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:25.388 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:25.878 [trace] terminalMultiLineLinkDetector#detect text ["    "]
2023-07-14 10:57:25.878 [trace] terminalLocalLinkDetector#detect text ["    "]
2023-07-14 10:57:25.879 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:26.840 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:26.840 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:26.840 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:26.856 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:26.856 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:26.857 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:26.873 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:26.873 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:26.873 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:26.873 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:26.889 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:26.890 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color ' EXPL-3291-implementing-EP-landing-page '"]
2023-07-14 10:57:26.890 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:26.906 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:26.906 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:26.906 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:26.907 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:26.924 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:26.924 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:26.924 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:26.941 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:26.941 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color '~/r/v/requests-frontend'"]
2023-07-14 10:57:26.941 [trace] terminalLocalLinkDetector#detect parsedLinks [[{"path":{"index":26,"text":"~/r/v/requests-frontend"}}]]
2023-07-14 10:57:26.941 [trace] terminalLocalLinkDetector#detect linkCandidates [["~/r/v/requests-frontend"]]
2023-07-14 10:57:26.987 [trace] terminalMultiLineLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:26.987 [trace] terminalLocalLinkDetector#detect text ["set_color: Unknown color 'py[learning]'"]
2023-07-14 10:57:26.987 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]
2023-07-14 10:57:28.423 [trace] terminalMultiLineLinkDetector#detect text ["Welcome to fish, the friendly interactive shell"]
2023-07-14 10:57:28.423 [trace] terminalLocalLinkDetector#detect text ["Welcome to fish, the friendly interactive shell"]
2023-07-14 10:57:28.424 [trace] terminalLocalLinkDetector#detect parsedLinks [[]]

at your service!

tylertian123 commented 1 year ago

I'm facing this exact same issue and I've managed to pinpoint the fish commands that cause the issue. This doesn't really have anything to do with the colours themselves but rather variable scoping.

Personally I'm using the agnoster theme and I'm assuming @gkatsanos is using something similar. The prompt function calls a bunch of functions like these:

function prompt_dir -d "Display the current directory"
  prompt_segment $color_dir_bg $color_dir_str (prompt_pwd)
end

And through experimentation I found that $color_dir_bg is not set when I'm in the VS Code terminal, leading prompt_segment to interpret the PWD as a color, which is what gives the error. These color variables were supposed to be set earlier in the script:

set -q color_user_bg; or set color_user_bg black
set -q color_user_str; or set color_user_str yellow
set -q color_dir_bg; or set color_dir_bg blue
set -q color_dir_str; or set color_dir_str black
# ...

I think it has something to do with scoping since one workaround I found was to change all the set color_* to set -g color_. So for some reason, a plain set without global scoping doesn't make the variables available to the other functions in the script when in the VS Code terminal.

eblumstengel-dbkg commented 1 year ago

Same problem for me, started immediately after the latest upgrade on MacOS (Monterey 12.5), MacBook Pro M1 machine. Is there a way to revert to a previous version?

Edit: Version info from the VSCode Update:

ersion: 1.80.1 Commit: 74f6148eb9ea00507ec113ec51c489d6ffb4b771 Date: 2023-07-12T17:20:23.298Z (5 days ago) Electron: 22.3.14 ElectronBuildId: 21893604 Chromium: 108.0.5359.215 Node.js: 16.17.1 V8: 10.8.168.25-electron.0 OS: Darwin x64 21.6.0

Edit again:

I could resolve the issue by using 

omf update

(using oh my fish with "bob the fish" as theme) and after closing the terminal and starting a new one, the shell is now working again as before (colors, git branches etc.)

Tyriar commented 1 year ago

@tylertian123 does disabling shell integration workaround the issue?

"terminal.integrated.shellIntegration.enabled": false
tylertian123 commented 1 year ago

@Tyriar Yes, the issue seems to disappear if shell integration is turned off.

@eblumstengel-dbkg I also tried running omf update and that solved my issue as well. I'm using the agnoster theme myself. There is apparently a commit in the theme at https://github.com/oh-my-fish/theme-agnoster/commit/0262111883b47cd09fb08dec65beeef8657936d4 which adds the -g flags exactly like the workaround I found. The commit message mentions something about the theme being wrapped by other scripts and so the variables get declared in a different scope.

By the way my version info is exactly the same as @eblumstengel-dbkg except I'm on Ubuntu 20.04, Linux 5.15.0-76-generic.

kelvinthh commented 1 year ago

I am having the same issue on macOS with Fish shell.

 set_color: Unknown color '...'
set_color: Unknown color ' ... 📁'
set_color: Unknown color '...'
set_color: Unknown color ' ... 📁'
gkatsanos commented 1 year ago

@kelvinthh I fixed it by uninstalling and reinstalling my omf theme. https://github.com/oh-my-fish/oh-my-fish#omf-remove-name.

Tyriar commented 1 year ago

Thanks @tylertian123 for looking into this. As mentioned in their comment you should update your fish packages with omf update which will set certain variables as global which will work correctly when fish_prompt gets wrapped.