microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.05k stars 29.21k forks source link

Open Changes with Revision not working with a commit id #187999

Closed TrevorBenson closed 1 year ago

TrevorBenson commented 1 year ago

Type: Bug

When opening the Open Changes menu it provides three options.

  1. Open changes with previous version
  2. Open changes with Revision
  3. Open changes with Branch or Tag

Selecting Open changes with Revision

The window pops up and says in the prompt Choose a commit to compare with, and below that it has a list of options for Choose a Branch or Tag, Choose a Stash, and 2 commits.

When pasting a commit into the prompt, it does not do anything. When selecting a branch or tag from the dropdown below the prompt, it changes, and entering the first part of a tag starts to filter a large list of known tags.

Selecting Open changes with Branch or Tag

The window pops up and says in the prompt Choose a branch or tag to compare with (or enter a reference using #) , and below that has a large list of branches to select from.

When pasting a commit into the prompt (with or without pretending #) it shows the commit message, date of the commit, and commit short id/hash.


I've marked this Visual Studio Code because I believe these are default menus, but have included enabled extensions in case something installed actually provides or modifies this functionality in some way.

VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T13:39:48.236Z) OS version: Linux x64 6.3.12-200.fc38.x86_64 Modes:

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 3999)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: disabled_software
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: disabled_off| |Load (avg)|1, 2, 2| |Memory (System)|30.98GB (17.37GB free)| |Process Argv|--unity-launch --crash-reporter-id 580bece0-b191-4d8a-b8bf-253607cede2d| |Screen Reader|no| |VM|0%| |DESKTOP_SESSION|gnome| |XDG_CURRENT_DESKTOP|GNOME| |XDG_SESSION_DESKTOP|gnome| |XDG_SESSION_TYPE|x11|
Extensions (45) Extension|Author (truncated)|Version ---|---|--- better-comments|aar|3.0.2 markdown-mermaid|bie|1.19.0 git-diff-and-merge-tool|dav|1.0.5 gitlens|eam|14.1.0 hadolint|exi|1.1.2 codespaces|Git|1.14.10 copilot|Git|1.96.255 copilot-chat|Git|0.4.0 copilot-labs|Git|0.14.884 vscode-github-actions|git|0.25.8 vscode-pull-request-github|Git|0.68.1 haskell|has|2.4.0 workspacesort|ici|1.6.2 language-haskell|jus|3.6.0 saltstack|kor|0.0.9 git-graph|mhu|1.30.0 vscode-docker|ms-|1.25.2 vscode-kubernetes-tools|ms-|1.3.13 black-formatter|ms-|2023.4.1 flake8|ms-|2023.6.0 pylint|ms-|2023.6.0 python|ms-|2023.12.0 vscode-pylance|ms-|2023.7.20 jupyter|ms-|2023.6.1101941928 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.17 vscode-jupyter-cell-tags|ms-|0.1.8 vscode-jupyter-slideshow|ms-|0.1.5 remote-containers|ms-|0.299.0 remote-ssh|ms-|0.102.0 remote-ssh-edit|ms-|0.86.0 remote-wsl|ms-|0.80.2 vscode-remote-extensionpack|ms-|0.24.0 remote-explorer|ms-|0.4.1 remote-server|ms-|1.3.0 ansible|red|2.4.78 vscode-openshift-connector|red|1.5.0 vscode-redhat-account|red|0.1.0 vscode-yaml|red|1.13.0 sourcery|sou|1.6.0 rst-vscode|tht|3.0.1 shellcheck|tim|0.32.6 io|tru|3.4.4 gitblame|wad|10.4.0 vscode-wakatime|Wak|24.2.0
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593cf:30376535 pythonvs932:30410667 py29gd2263cf:30789497 vsclangdf:30486550 c4g48928:30535728 dsvsc012:30540252 pynewext54:30695312 azure-dev_surveyone:30548225 vsccc:30610678 2e4cg342:30602488 pyind779:30671433 89544117:30613380 pythonsymbol12:30671437 2i9eh265:30646982 showlangstatbar:30737416 vsctsb:30748421 pythonms35:30701012 03d35959:30757346 pythonfmttext:30731395 pythoncmvfstrcf:30756944 fixshowwlkth:30771522 hideindicator:30785051 pythongtdpath:30769146 i26e3531:30780429 pythonnosm12tcf:30779713 pythonidxpt:30784022 pythonnoceb:30776495 e537b577:30786199 dsvsc013cf:30789518 ```
vscodenpa commented 1 year ago

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.80.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

TrevorBenson commented 1 year ago

I've updated VS Code to version 1.80.1 and the behavior is identical, the Open Changes with Revision menu does not work with a commit hash, while the Open Changes with Branch or Tag does work with a commit hash.

TrevorBenson commented 1 year ago

The Command Pallete make me suspect the functionality actually comes from a github extensions. I have a few github related extensions which may be interacting with each other. I will try to test a fresh vscode with individual extensions to see which one seems to be causing the behavior.

gjsjohnmurray commented 1 year ago

The Start Extension Bisect command can help you.

lszomoru commented 1 year ago

/gifPlease

vscodenpa commented 1 year ago

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

TrevorBenson commented 1 year ago

I'm going to mark this issue as closed. I tried both flatpak and codespaces and the behavior was to open the changes of the current file immediately. I also tried adding one plugin at a time, but none made a new menu appear.

I reverted to my main vscode program which has all the same plugins enabled as when originally reported. The menu's no longer appear when I select Git: Open Changes, just the current changes to the file.

Running details:

Version: 1.81.1
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:18:39.991Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Linux x64 6.4.10-200.fc38.x86_64

Even though the behavior was originally consistent after both restarting and restoring default settings, I am no longer able to reproduce it in v1.81.1 with whatever differences in plugin versions running currently, so will now close out this issue.