Bug :git smart commit not properly work

[Gobinath-B]

Type: Bug

This issue causes when we enable git : smart commitfeature.

The users enable this feature to automatically stage all the changes when we save the files.

Steps to reproduce the issue:

• open vs code and enable git: smart commit feature .
• open two files example: index.html and app.js
• publish the repository on git hub
• edit the two files and save only one file
• now in source control tab you can see that the changes you made was automatically staged and ready to commit.
• when you put the commit message and click commit button it pop a window that tells that a unsaved file is there and have a option "save all and commit" button
• when we click that button the unsaved file gets saved, staged, committed and pushed to git hub origin with that commit message we put previously. but the file we saved earlier stayed on changes area .
• It didn't get s staged, committed and pushed by git smart commit feature

Proof of concept:

Here i enable the smart commit feature.

I open two files named index.html and app.js and made changes on that two files

• when i saved a file automatically the changes are staged and ready to commit.
• This window poped up when i put commit message and click commit button on source control tab. because i didn't saved another file.
• this window has an option save all and commit that means save the unsaved file and stage the changes and commit and push with saved files.

• After clicked the save all and commit button , the unsaved file gets saved, staged, committed and push to git hub with the commit message we put earlier.
• But the saved file stayed on the changes area.it didn't get committed and pushed to git hub

VS Code version: Code 1.81.1 (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:22:42.175Z) OS version: Windows_NT x64 10.0.22621 Modes:

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i3-10110U CPU @ 2.10GHz (4 x 2592)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|7.84GB (0.93GB free)| |Process Argv|--crash-reporter-id f0f6cacc-020e-44fc-8872-27a4dd1ddf48| |Screen Reader|no| |VM|0%|

Extensions (49)

Extension|Author (truncated)|Version ---|---|--- npm-intellisense|chr|1.4.4 path-intellisense|chr|2.8.4 doxdocgen|csc|1.4.0 c-cpp-compile-run|dan|1.0.49 vscode-eslint|dba|2.4.2 es7-react-js-snippets|dsz|4.4.3 EditorConfig|Edi|0.16.4 vscode-npm-script|eg2|0.3.29 prettier-vscode|esb|10.1.0 vscode-pull-request-github|Git|0.70.0 search-node-modules|jas|1.3.0 better-cpp-syntax|jef|1.17.2 vscode-codemetrics|kis|1.26.1 node-module-intellisense|lei|1.5.0 vscode-azurefunctions|ms-|1.12.3 vscode-azureresourcegroups|ms-|0.7.5 isort|ms-|2023.10.1 python|ms-|2023.14.0 vscode-pylance|ms-|2023.8.20 jupyter|ms-|2023.7.1002162226 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.17 vscode-jupyter-cell-tags|ms-|0.1.8 vscode-jupyter-slideshow|ms-|0.1.5 remote-containers|ms-|0.304.0 remote-ssh|ms-|0.105.2023080715 remote-ssh-edit|ms-|0.86.0 remote-wsl|ms-|0.81.0 azure-account|ms-|0.11.5 cmake-tools|ms-|1.15.31 cpptools|ms-|1.16.3 cpptools-extension-pack|ms-|1.3.0 remote-explorer|ms-|0.4.1 vscode-github-issue-notebooks|ms-|0.0.129 vscode-selfhost-test-provider|ms-|0.3.16 vsliveshare|ms-|1.0.5877 vsliveshare-audio|ms-|0.1.93 debugger-for-chrome|msj|4.13.0 vscode-for-node-js-development-pack|nod|2.0.1 vscode-thunder-client|ran|2.10.2 LiveServer|rit|5.7.9 es7-react-js-snippets|rod|1.9.3 code-settings-sync|Sha|3.4.3 bootstrap4-vscode|the|6.1.0 cmake|twx|0.0.17 vscode-icons|vsc|12.5.0 vscode-import-cost|wix|3.3.0 Live-Postman|wyc|1.0.1 JavaScriptSnippets|xab|1.8.0 (1 theme extensions excluded)

A/B Experiments

``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 pythonvs932:30410667 py29gd2263cf:30792227 vscaat:30438848 vsclangdf:30486550 c4g48928:30535728 dsvsc012:30540252 pynewext54:30695312 azure-dev_surveyone:30548225 vsccc:30803844 3biah626:30602489 f6dab269:30613381 a9j8j154:30646983 showlangstatbar:30737416 a2ce3375:30757347 pythonfmttext:30731395 pythoncmv:30756943 fixshowwlkth:30771522 showindicator:30805244 pythongtdpath:30769146 i26e3531:30792625 gsofa:30804715 pythonnosmt12:30797651 pythonidxpt:30805730 pythonnoceb:30805159 dsvsc013:30795093 dsvsc014:30804076 diffeditorv1:30812748 ```

[Gobinath-B]

@gjsjohnmurray try to reproduce this issue and label this as a bug

[gjsjohnmurray]

@Gobinath-B I am a volunteer here, trusted by the VS Code team to help manage the workload, for example by consolidating duplicate issues. In this case I will leave further investigation to the team member who the issue has been assigned to. Thanks in advance for your understanding.

[Gobinath-B]

@gjsjohnmurray yeah i could understood,thank you.

[lszomoru]

@Gobinath-B, thank you very much for filling this issue. This does indeed look like a bug and will look to fixing in during the September milestone.

[Gobinath-B]

@lszomoru , Actually I fix this issue and raised a pull request .Please review the code and merge it.

190326

[lszomoru]

Will do. Thank you very much for the pull request.

[Gobinath-B]

@lszomoru thank you so much for your response

[lszomoru]

Fix will be available in the Insiders release on Monday (2023-08-28).