ghost text hover screen cheese

microsoft / vscode

Visual Studio Code

https://code.visualstudio.com

MIT License

164.36k stars 29.31k forks source link

ghost text hover screen cheese #191597

Open jrieken opened 1 year ago

jrieken commented 1 year ago

open https://github.com/microsoft/vscode/blob/3059063b805ed0ac10a6d9539e213386bfcfb852/src/vs/workbench/contrib/snippets/browser/snippetsFile.ts#L63
type mark
wait for ghost text
trigger hover via keybinding
🧀 the hover looks bad, there is nothing between the arrows and a lone "any" atop

jrieken commented 1 year ago

I believe I understand what's happening.

There is a missing separator between the any hover and ghost hover
The "N/M" takes forever to resolve and we don't show a "1/?" in the meantime

hediet commented 1 year ago

The "N/M" takes forever to resolve and we don't show a "1/?" in the meantime

This actually used to be the case (https://github.com/microsoft/vscode/issues/172142). But maybe there is also a bug that it never resolves (#189058).

There is a missing separator between the any hover and ghost hover

I agree.

jrieken commented 1 year ago

This actually used to be the case (https://github.com/microsoft/vscode/issues/172142). But maybe there is also a bug that it never resolves (https://github.com/microsoft/vscode/issues/189058).

Yeah, it never resolves but I would argue that it is bad to even shortly not show anything. If folks don't like 1/? show something else that's simpler to understand but looks less buggy, like "1/1" (which updates once the data is there)