microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.75k stars 29.1k forks source link

Double hotkey stopped working #192213

Closed cybairfly closed 10 months ago

cybairfly commented 1 year ago

Type: Bug

Hello, I was previously able to map file search to double invocation of the command pallete but have not been able to do so since some updates. The bindings are set for Ctrl+Space to open the Command line and then Ctrl+Space once more within the command line (when=isQuickOpen) to open the file search and this stopped working. There don't seem to be any apparent conflicts causing this.

VS Code version: Code 1.81.1 (6c3e3dba23e8fadc360aed75ce363ba185c49794, 2023-08-09T22:22:42.175Z) OS version: Windows_NT x64 10.0.19045 Modes:

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|7.89GB (1.62GB free)| |Process Argv|--crash-reporter-id c0ae5d34-0f45-449e-81f9-33203de9c53d| |Screen Reader|yes| |VM|0%|
Extensions (51) Extension|Author (truncated)|Version ---|---|--- multi-cursor-case-preserve|Car|1.0.5 path-intellisense|chr|2.8.4 regex|chr|0.4.0 codeium|Cod|1.2.83 vscode-eslint|dba|2.4.2 devdocs|dei|0.2.0 css-flexbox-cheatsheet|dzh|3.3.3 gitlens|eam|14.2.1 LogFileHighlighter|emi|2.16.0 vscode-todo-plus|fab|4.19.1 git-project-manager|fel|1.8.2 file-icons|fil|1.1.0 vscode-jest-runner|fir|0.4.66 code-runner|for|0.12.0 json-utility|Gan|1.0.1 remotehub|Git|0.60.0 gitlab-workflow|Git|3.76.0 glitch|gli|0.1.8 todo-tree|Gru|0.0.226 debug-visualizer|hed|2.4.0 vscode-drawio|hed|1.6.6 vscode-npm-dependency|how|1.2.2 rest-client|hum|0.25.1 open-in-browser|igo|1.0.2 node-module-intellisense|lei|1.5.0 blockman|leo|1.7.5 json-to-ts|Mar|1.7.5 git-graph|mhu|1.30.0 formate|Mik|1.2.1 dotenv|mik|1.0.1 mongodb-vscode|mon|1.2.1 remote-wsl|ms-|0.81.0 azure-repos|ms-|0.36.0 live-server|ms-|0.4.9 remote-repositories|ms-|0.38.1 color-highlight|nau|2.5.0 vscode-versionlens|pfl|1.6.0 postman-for-vscode|Pos|0.6.2 vscode-data-preview|Ran|2.3.0 vscode-thunder-client|ran|2.11.3 LiveServer|rit|5.7.9 vscode-javascript-booster|sbu|14.0.1 rewrap|stk|1.16.3 errorlens|use|3.13.0 vscode-fold-level|vik|0.0.14 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.2.30 vscode-conventional-commits|viv|1.25.0 vscode-todo-highlight|way|1.0.5 local-history|xyz|1.8.1 json|Zai|2.0.2
A/B Experiments ``` vsliv368cf:30146710 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vswsl492:30256859 vstes516:30244333 vslsvsres303:30308271 vserr242cf:30382550 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscoreces:30445986 vscod805cf:30301675 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 pythonvs932:30410667 py29gd2263cf:30792227 vsclangdc:30486549 c4g48928:30535728 dsvsc012cf:30540253 pynewext54:30695312 azure-dev_surveyone:30548225 vsccc:30803844 282f8724:30602487 f6dab269:30613381 showlangstatbar:30737416 03d35959:30757346 pythonfmttext:30731395 fixshowwlkth:30771522 showindicator:30805244 pythongtdpath:30769146 i26e3531:30792625 pythonnosmt12:30797651 pythonidxptcf:30805731 pythonnoceb:30805159 dsvsc013:30795093 dsvsc014:30804076 diffeditorv2:30821572 ```
cybairfly commented 1 year ago

PS: Extensions have no role in this, tested.

cybairfly commented 1 year ago

image

Remapping all the other hotkeys besides the two mentioned above to another combination temporarily did not help either.

cybairfly commented 1 year ago

Looks like a bad design decision somewhere along the way, and a conflict between these commands: "command": "workbench.action.quickOpen", "command": "workbench.action.showCommands",

Basically, they should be doing different things but instead are colliding with one another.

cybairfly commented 1 year ago

Not even this is working, while previously none of such convoluted setups was necessary, it just worked plain and simple.

    {
        "key": "ctrl+space",
        "command": "workbench.action.showCommands",
        "when": "!inQuickOpen"
    },
    {
        "key": "ctrl+space",
        "command": "runCommands",
        "args": {
          "commands": [
            "workbench.action.closeQuickOpen",
            "workbench.action.quickOpen"
          ]
        },
        "when": "inQuickOpen"
    },
cybairfly commented 11 months ago

Hello?

ulugbekna commented 10 months ago

Duplicate of https://github.com/microsoft/vscode/issues/186120