microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.86k stars 29.51k forks source link

Implement [Alt]+[Spacebar] Windows menu #193102

Closed mfinky closed 1 year ago

mfinky commented 1 year ago

Please, implement the (standard) Windows menu when we press [Alt]+[Spacebar].
This will let us (for instance) minimize vscode using just keyboard instead of mouse.

Thanks!

DonJayamanne commented 1 year ago

@deepak1556 is this a feature request or a bug?

mfinky commented 1 year ago

I may not have the authority to classify it. To me, it is both. Considering Being VSCode is a Windows application, I expect it to adhere to Windows standards. Namely, when a user presses [Alt]+[Space], the application shall open the system menu, offering {Resize, Move, Size, Minimize, Close}. In that regard, it is a bug; as it does not pass a test that I consider standard for a Windows application.

If the above is rejected to be considered a bug by anyone, please consider it a feature request. I would like to enhance that VsCode should not react to a mouse click on the left top corner but to the keyboard shortcut! It has to do with accessibility. In my case, and I assume there will be other users on the same situation, I have a limitation to using a mouse and I use keyboard as much as I can. Being able to use a keyboard shortcut to maximize, minimize, etc. a window is of great importance to me.

Thanks, Marcelo

From: Don Jayamanne @.> Sent: Saturday, September 23, 2023 04:26 To: microsoft/vscode @.> Cc: Finkielsztein, Marcelo @.>; Author @.> Subject: [External] Re: [microsoft/vscode] Implement [Alt]+[Spacebar] Windows menu (Issue #193102)

@deepak1556https://urldefense.com/v3/__https:/github.com/deepak1556__;!!MtWvt2UVEQ!BpFU9vG3dgPUDOOLV0dJSoe66YnTN2uiNkxhbJ68g008PgDi7cvFHJ5pq406Xq0D6wRaGYkimNi_OYgRElVV0vOCPM3gSWQ$ is this a feature request or a bug?

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/microsoft/vscode/issues/193102*issuecomment-1732264867__;Iw!!MtWvt2UVEQ!BpFU9vG3dgPUDOOLV0dJSoe66YnTN2uiNkxhbJ68g008PgDi7cvFHJ5pq406Xq0D6wRaGYkimNi_OYgRElVV0vOCyLhl1sk$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AB5RW2OIZD5LXU2D6N3BAGTX32TJ5ANCNFSM6AAAAAA4X7RNJI__;!!MtWvt2UVEQ!BpFU9vG3dgPUDOOLV0dJSoe66YnTN2uiNkxhbJ68g008PgDi7cvFHJ5pq406Xq0D6wRaGYkimNi_OYgRElVV0vOCqrdipDk$. You are receiving this because you authored the thread.Message ID: @.**@.>>

mfinky commented 1 year ago

I also want to add: VS Code is the the most impressive IDE I have ever used! Endless gratitude to the authors! I consider myself a quite advanced user, with experience in editors like Visual Studio pro (including jetbrains), Visual Studio Community Edition, Eclipse, jEdit, the built-in PowerShell ISE, and others like Notepad++, VIM (sigh), IBM SEU, and I must be forgetting others.

Congratulations and THANK YOU !!! Marcelo

deepak1556 commented 1 year ago

I can see the context menu open with Alt + Space using both custom "window.titleBarStyle": "custom" and native titlebar "window.titleBarStyle": "native".

The context menu for custom titlebar was implemented in https://github.com/microsoft/vscode/issues/156222 and for native titlebar it was always present.

@mfinky can you share a screen capture of the steps that demonstrate the issue, please also include your settings.json in this issue thread. Thanks!

deepak1556 commented 1 year ago

/gifPlease

vscodenpa commented 1 year ago

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

mfinky commented 1 year ago

Hello,

I have just added … "window.titleBarStyle":"custom" … as last line to my settings.json file and after restarting VS-code the feature works. With “native” also works. Without this line it does not work for me.

I am including the full settings.json as requested, but I had to edit and delete lines from this file because I realized there were compromising values exposed in clear text. Like p s s w r d s , server names, and things like that.

{ "security.workspace.trust.untrustedFiles": "open", "redhat.telemetry.enabled": false, "python.defaultInterpreterPath": "*****", "[python]": { "editor.defaultFormatter": "ms-python.python", "editor.cursorBlinking": "expand", "editor.cursorSurroundingLines": 5, "editor.formatOnType": true }, "git.suggestSmartCommit": false, "[bat]": { "emmet.triggerExpansionOnTab": true, "breadcrumbs.showVariables": true, "editor.cursorBlinking": "smooth", "editor.cursorSmoothCaretAnimation": "on", "editor.cursorStyle": "line", "editor.cursorSurroundingLines": 5, "outline.showVariables": true, }, "editor.fontLigatures": false , "workbench.colorCustomizations": { "editor.background": "#112233" , "titleBar.activeBackground": "#002277" , "titleBar.inactiveBackground": "#333333" , "menu.border": "#ffffff" },

"diffEditor.ignoreTrimWhitespace": false,
"oracledevtools.bookmarkFileFolder": ""*********",
"oracledevtools.download.otherFolder": ""*********",
"oracledevtools.connectionConfiguration.configFilesFolder": ""*********",
"oracledevtools.connectionConfiguration.walletFileFolder": ""*********",
"code-runner.clearPreviousOutput": true,
"[powershell]": {
    "editor.cursorBlinking": "expand",
    "editor.cursorSurroundingLines": 3
},
"editor.minimap.enabled": false,
"oracledevtools.OracleCloudInfrastructure.profiles": [
    {
        "profileName": "DEFAULT",
        "tenancyID": ""*********",
        "tenancyName": ""*********"
    }
],
"oracledevtools.defaultConnection": "",
"oracledevtools.connections": [
    {
        "authenticationType": 2,
        "dBAPrivilege": "None",
        "userID": "EDW_BUS_"********* ",
        "passwordSaved": true,
        "password": ""*********",
        "dataSource": ""*********",
        "connectionType": 1,
        "tnsAdmin": ""*********",
        "name": ""*********",
        "currentSchema": ""
    },
    }
],
"oracledevtools.formatterSettings": {
    "identifierCasing": "Same as Intellisense",
    "keywordCasing": "Same as Intellisense",
    "1-LineLongComments": "Don't format",
    "lineBreaksBetweenStatements": "Double break",
    "lineBreakOnComma": "Before",
    "lineBreakOnConcatenation": "Before",
    "lineBreakOnBooleanConnectors": "Before",
    "lineBreakOnANSI-joins": true,
    "lineBreakBeforeLineComments": false,
    "lineBreakAfterSelect/From/Where": true,
    "lineBreaksOnIf/Case/While": "Indented actions, inlined conditions",
    "whiteSpaceAroundOperators": "Don't format",
    "whiteSpaceAfterCommas": true,
    "whiteSpaceAroundParenthesis": "Don't format"
},
"mssql.connections": [
    {
    }
],
"update.showReleaseNotes": false,
"sqltools.useNodeRuntime": true,
"oracledevtools.intellisense.suggestions.keywordCasing": "Lowercase",
"editor.linkedEditing": true,
"window.zoomLevel": 2,
"workbench.colorTheme": "Default Dark+",
"terminal.integrated.automationProfile.windows": {

},
"terminal.integrated.defaultProfile.windows": "Command Prompt",
"window.commandCenter": true,
"window.titleBarStyle":"custom"

}

Thank you, Marcelo Finkielsztein

From: Robo @.> Sent: Monday, September 25, 2023 22:07 To: microsoft/vscode @.> Cc: Finkielsztein, Marcelo @.>; Mention @.> Subject: [External] Re: [microsoft/vscode] Implement [Alt]+[Spacebar] Windows menu (Issue #193102)

I can see the context menu open with Alt + Space using both custom "window.titleBarStyle": "custom" and native titlebar "window.titleBarStyle": "native".

The context menu for custom titlebar was implemented in #156222 and for native titlebar it was always present.

@mfinky can you share a screen capture of the steps that demonstrate the issue, please also include your settings.json in this issue thread. Thanks!

mfinky commented 1 year ago

I can see the context menu open with Alt + Space using both custom "window.titleBarStyle": "custom" and native titlebar "window.titleBarStyle": "native".

The context menu for custom titlebar was implemented in #156222 and for native titlebar it was always present.

@mfinky can you share a screen capture of the steps that demonstrate the issue, please also include your settings.json in this issue thread. Thanks!

please see my reply above. when i added "window.titleBarStyle":"custom" as last line to my settings.json file the feature started to work.

Thanks, Marcelo

mfinky commented 1 year ago

added "window.titleBarStyle":"custom" as last line to my settings.json file the feature started to work.