Put density related options under the same namespace: tabs, notebooks

[bpasero]

We should consider to begin a new settings namespace for moving settings that are related to compactness of the workbench. Another candidate for this is: notebook.compactView.

One idea would be window.density and then properties within to configure per component. But as a user you can set window.density: compact to toggle them all.

Related: https://github.com/microsoft/vscode/issues/168671

//cc @rebornix @Tyriar @daviddossett

[benibenj]

window.density sounds good to me. Would this mean the tabHeight setting will be called: windows.density.editor.tabHeight or windows.density.tabHeight ?

Also, what should the options be? I liked compact & default (instead of normal which we are currently using for tabHeight)

[bpasero]

My feeling is that I would not have more layers of settings after window.density but just one. So for example window.density.editorTabHeight so that as a user you either configure window.density: <option> or individual settings one level below.

@rebornix would window.density.notebookCompactView work for you?

https://github.com/microsoft/vscode/issues/168671 talks about default, comfortable and compact, so I like the idea of using default instead of normal.

[rebornix]

window.density.notebookCompactView is good, I think it makes sense to have it under a density setting other than notebook.

[bpasero]

Ok, updating the issue then, I think we should do both for September if possible.

[rebornix]

I didn't get a chance to take a look yesterday. Considering that we need update the setting and also do the migration work (from notebook.compactView to window.density.notebookCompactView), I would prefer to handle this in October.

An alternative is we add window.density.notebookCompactView and for this month, we support both and call out in the setting description in notebook.compactView that we are deprecating. What do you think @bpasero @benibenj ?

[bpasero]

I think October is fine. We are not having other window.density work planned near term anyway.

The change for tabs landed meanwhile.

[heartacker]

cry