search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
164.67k stars 29.44k forks source link

Notebook goto symbol: improve styling for highlighting symbol #194118

Open isidorn opened 1 year ago

isidorn commented 1 year ago

Testing #194053

  1. Open notebook. Open outline
  2. Notice how the yellow rendering is done around the cells.
  3. The UI looks bad. The yellow colour should also be applied inside the cell. Same how we do it in the regular editor

Screenshot 2023-09-26 at 12 13 07

amunger commented 1 year ago

Not that it looks all that much better, but it should highlight the line if the symbols were gathered correctly image

Did you have a kernel selected? (were you able to run a cell?) Make sure you're on the latest version Make sure notebook.gotoSymbols.showAllSymbols is set

isidorn commented 1 year ago

I was not having pylance. But yes, now it looks a bit worse even with that extra yellow line 😊

Do we need design help here?

amunger commented 1 year ago

yes, I could definitely use some design help. I can also bring it up in the UX sync

isidorn commented 1 year ago

fyi @daviddossett