Open isidorn opened 1 year ago
Open for suggestion. It uses the default 35px that we use for view and editor titled. Without CC it's 28px.
Maybe this would be a candidate for the new window.density
namespace and offer a setting. With window.density.editorTabHeight
you can set to compact
to reduce tab height to 22px
.
Later the idea would be that a user could set window.density: compact
and all associated components would respect that.
I hacked some css and decreased width to 28px and I think it looks decent. There are probably bugs I am missing. So I am not sure if this really needs the extra space we give it?
@bpasero I think that is a fine solution if we do not find a good default.
Yeah I am all up for reducing the default height, though 35px
is a good default we use elsewhere. Then we have 22px
for e.g. status bar.
If the compact version would be a small as 22px
(not sure thats possible), then we could do that behind a setting.
Please be aware that the pixels below the CC act as a grab handle for dragging the window, given that we can't (yet?) drag it from within the CC itself.
@gjsjohnmurray thanks. But area left and right of the cc can still be used to drag. So I am not very concerned about this.
@isidorn you're on Mac, and for Windows users it's sometimes a bit limited:
22px might be too aggressive btw. It would require us to shrink all buttons and menu items more than in other places
@jrieken what do you think about 28px? @gjsjohnmurray good point we should check all platforms.
But can we not implement the same way Slack implemented it?
35px would be alright if it didn't increase to 42px when "window.zoomLevel": -.5
. The titlebar doesn't scale with everything else.
Love the command center, but my biggest issue is the height in pixels. It just takes too much of my screen real estate. Could we save a couple of pixels to make it look lean? This way the title area looks too bloated compared to other apps.
@hediet had similar concerns
fyi @hbons @joaomoreno