microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.18k stars 28.84k forks source link

Command center - make it leaner? #194313

Open isidorn opened 1 year ago

isidorn commented 1 year ago

Love the command center, but my biggest issue is the height in pixels. It just takes too much of my screen real estate. Could we save a couple of pixels to make it look lean? This way the title area looks too bloated compared to other apps.

@hediet had similar concerns

fyi @hbons @joaomoreno

Screenshot 2023-09-27 at 17 28 21

jrieken commented 1 year ago

Open for suggestion. It uses the default 35px that we use for view and editor titled. Without CC it's 28px.

bpasero commented 1 year ago

Maybe this would be a candidate for the new window.density namespace and offer a setting. With window.density.editorTabHeight you can set to compact to reduce tab height to 22px.

Later the idea would be that a user could set window.density: compact and all associated components would respect that.

isidorn commented 1 year ago

I hacked some css and decreased width to 28px and I think it looks decent. There are probably bugs I am missing. So I am not sure if this really needs the extra space we give it?

@bpasero I think that is a fine solution if we do not find a good default.

Screenshot 2023-09-27 at 18 08 51

bpasero commented 1 year ago

Yeah I am all up for reducing the default height, though 35px is a good default we use elsewhere. Then we have 22px for e.g. status bar.

If the compact version would be a small as 22px (not sure thats possible), then we could do that behind a setting.

gjsjohnmurray commented 1 year ago

Please be aware that the pixels below the CC act as a grab handle for dragging the window, given that we can't (yet?) drag it from within the CC itself.

isidorn commented 1 year ago

@gjsjohnmurray thanks. But area left and right of the cc can still be used to drag. So I am not very concerned about this.

gjsjohnmurray commented 1 year ago

@isidorn you're on Mac, and for Windows users it's sometimes a bit limited:

image

jrieken commented 1 year ago

22px might be too aggressive btw. It would require us to shrink all buttons and menu items more than in other places

Screenshot 2023-09-27 at 18 13 59
isidorn commented 1 year ago

@jrieken what do you think about 28px? @gjsjohnmurray good point we should check all platforms.

abhijit-chikane commented 11 months ago

152578 I think the main reason you kept it to 35px is already discuss here in this issue.

But can we not implement the same way Slack implemented it?

DerekZiemba commented 5 months ago

35px would be alright if it didn't increase to 42px when "window.zoomLevel": -.5. The titlebar doesn't scale with everything else.

image