Diff hidden lines doesn't work correctly with workspace search and replace

[thisjustin816]

Type: Bug

1. Have the diff editor hidden lines setting enabled
2. Use the workspace search and expand it to do a replace

the left side is not aligned with the right side because the left has hidden lines but the right does not

VS Code version: Code 1.82.3 (fdb98833154679dbaa7af67a5a29fe19e55c2b73, 2023-10-02T10:51:22.294Z) OS version: Windows_NT x64 10.0.23555 Modes:

System Info

|Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz (12 x 2592)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|31.75GB (16.20GB free)| |Process Argv|--folder-uri file:///d%3A/PSSiOpsFeed/PSUtils --crash-reporter-id 50c76677-d175-4d77-87f8-f82b2959c282| |Screen Reader|no| |VM|0%|

Extensions (66)

Extension|Author (truncated)|Version ---|---|--- better-comments|aar|3.0.2 vscode-opennewinstance|chr|0.0.12 npm-intellisense|chr|1.4.4 path-intellisense|chr|2.8.4 vscode-zonefile|Com|0.0.4 azure-devops-snippets|dam|1.0.6 vscode-markdownlint|Dav|0.52.0 docs-markdown|doc|1.0.3 githistory|don|0.6.20 xml|Dot|2.5.1 gitlens|eam|14.3.0 vscode-nupkg|eri|1.0.1 prettier-vscode|esb|10.1.0 git-project-manager|fel|1.8.2 copilot|Git|1.122.462 copilot-chat|Git|0.7.1 copilot-labs|Git|0.15.1019 remotehub|Git|0.60.0 vscode-codeql|Git|1.9.1 json2ts|Gre|0.0.6 vscode-test-explorer|hbe|2.21.1 rest-client|hum|0.25.1 reg|ion|1.1.0 ts-extension-pack|loi|0.3.0 vscode-swissknife|lui|1.8.1 azure-pipelines|ms-|1.228.0 vscode-azureappservice|ms-|0.25.0 vscode-azureresourcegroups|ms-|0.7.5 vscode-azurevirtualmachines|ms-|0.6.5 vscode-bicep|ms-|0.21.1 vscode-cosmosdb|ms-|0.19.4 csharp|ms-|2.4.4 vscode-dotnet-runtime|ms-|1.8.0 data-workspace-vscode|ms-|0.5.0 mssql|ms-|1.21.0 sql-database-projects-vscode|ms-|1.3.1 azure-account|ms-|0.11.5 azure-repos|ms-|0.36.0 azurecli|ms-|0.5.0 cpptools|ms-|1.17.5 cpptools-extension-pack|ms-|1.3.0 live-server|ms-|0.4.9 powershell|ms-|2023.6.0 remote-repositories|ms-|0.38.1 test-adapter-converter|ms-|0.1.8 vsliveshare|ms-|1.0.5883 azurerm-vscode-tools|msa|0.15.11 material-icon-theme|PKi|4.30.1 material-product-icons|PKi|1.6.0 tsimporter|pmn|2.0.1 vscode-commons|red|0.0.6 vscode-yaml|red|1.14.0 glassit|s-n|0.2.6 arm-snippets|sam|1.4.19 vscode-table-formatter|shu|1.2.1 vscode-zipexplorer|sle|0.3.1 code-spell-checker|str|3.0.1 move-ts|str|1.12.0 pdf|tom|1.2.2 vscode-mermaid-editor|tom|0.19.1 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.2.30 vscode-conventional-commits|viv|1.25.0 vscode-icons|vsc|12.5.0 vscode-typescript-vue-plugin|Vue|1.8.15 markdown-all-in-one|yzh|3.5.1

[andreamah]

What is the setting ID for the diff editor hidden lines setting?

[thisjustin816]

I’m actually not sure. It was a recent change and I assumed there was a setting for it that I just couldn’t find.

-- Justin Beeson (He/Him) DevOps Engineer @. @.> https://github.com/thisjustin816 https://github.com/thisjustin816 https://www.linkedin.com/in/justinbeeson/ https://www.linkedin.com/in/justinbeeson/

Sent with Shortwave https://www.shortwave.com?utm_medium=email&utm_content=signature&utm_source=amJlZXNvbjgxNkBnbWFpbC5jb20=

On Wed Oct 4, 2023, 05:18 PM GMT, Andrea Mah @.***> wrote:

What is the setting ID for the diff editor hidden lines setting? — Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode/issues/194807#issuecomment-1747328479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJZZKT3NNBXSB35VKPVEBRLX5WK6DAVCNFSM6AAAAAA5S3LV6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGMZDQNBXHE. You are receiving this because you authored the thread.Message ID: @.***>

[andreamah]

@hediet Do you know what this setting is?

[siegelaaron94]

Why did this feature get turned on by default with this latest release? It's horrible and needs to give you more context to evaluate code changes. Like, three lines of context, in what codebases/languages is that enough information to evaluate a diff?

[hediet]

Why did this feature get turned on by default with this latest release?

This feature did not get turned on by default.