microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
163.2k stars 28.85k forks source link

[Accessibility] Accessible View does not get dynamically updated in Jupyter Notebook cell output #195581

Open jooyoungseo opened 11 months ago

jooyoungseo commented 11 months ago

Type: Bug

CC @meganrogge

When screen reader users augment current Notebook cell output in Accessible View via alt+F2, dynamic content does not get updated in the buffer, such as downloading progress on pip/conda packages and any computational progressive print.

VS Code version: Code - Insiders 1.84.0-insider (4678919d52909efc7c4ab958a2e5c8f45d50ffc3, 2023-10-13T05:34:13.175Z) OS version: Windows_NT x64 10.0.22621 Modes: Remote OS version: Linux x64 4.18.0-477.27.1.el8_8.x86_64

System Info |Item|Value| |---|---| |CPUs|11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz (8 x 2611)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|15.71GB (6.98GB free)| |Process Argv|--crash-reporter-id b05b88e5-8894-4031-ae34-fa034ebddea9| |Screen Reader|yes| |VM|0%| |Item|Value| |---|---| |Remote|SSH: dt-login.delta.ncsa.illinois.edu| |OS|Linux x64 4.18.0-477.27.1.el8_8.x86_64| |CPUs|AMD EPYC 7763 64-Core Processor (128 x 2445)| |Memory (System)|251.60GB (135.58GB free)| |VM|0%|
Extensions (98) Extension|Author (truncated)|Version ---|---|--- aiprm-lang|AIP|0.0.2 Bookmarks|ale|13.4.2 spellright|ban|3.0.118 mermaid-markdown-syntax-highlighting|bpr|1.5.2 codespaces|Git|1.15.4 remotehub|Git|0.62.0 overleaf-workshop|iam|0.3.0 easy-snippet|inu|0.6.3 scheme|jea|0.2.0 better-cpp-syntax|jef|1.17.2 lilypond-snippets|lhl|0.1.1 jupyter-keymap|ms-|1.1.2 remote-containers|ms-|0.318.0 remote-ssh|ms-|0.106.5 remote-ssh-edit|ms-|0.86.0 remote-wsl|ms-|0.81.8 vscode-remote-extensionpack|ms-|0.24.0 azure-repos|ms-|0.38.0 remote-repositories|ms-|0.40.0 vscode-serial-monitor|ms-|0.10.0 multi-command|ryu|1.6.0 errorlens|use|3.14.0 Bookmarks|ale|13.4.2 openscad|Ant|1.2.2 zoterolatex|bna|0.4.1 mermaid-markdown-syntax-highlighting|bpr|1.5.2 doxdocgen|csc|1.4.0 vscode-markdownlint|Dav|0.52.0 vscode-eslint|dba|2.4.2 vscode-quick-select|dba|0.2.9 vscode-deno|den|3.26.0 gitlens|eam|14.3.0 EditorConfig|Edi|0.16.4 prettier-vscode|esb|10.1.0 vscode-google-translate|fun|1.4.13 codespaces|Git|1.15.4 copilot|Git|1.126.491 copilot-chat|Git|0.9.2023101301 remotehub|Git|0.62.0 vscode-github-actions|git|0.26.2 vscode-pull-request-github|Git|0.75.2023101209 cslpreview|igo|0.2.2 path-autocomplete|ion|1.25.0 latex-workshop|Jam|9.14.1 lilypond-syntax|jea|0.1.1 scheme|jea|0.2.0 better-cpp-syntax|jef|1.17.2 vscode-lua-format|Koi|1.3.8 lilypond-formatter|lhl|0.2.3 lilypond-pdf-preview|lhl|0.2.8 lilypond-snippets|lhl|0.1.1 vslilypond|lhl|1.7.3 git-graph|mhu|1.30.0 vscode-docker|ms-|1.26.1 black-formatter|ms-|2023.4.1 flake8|ms-|2023.8.0 isort|ms-|2023.10.1 python|ms-|2023.18.0 vscode-pylance|ms-|2023.10.20 jupyter|ms-|2023.10.1002871100 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.17 vscode-jupyter-cell-tags|ms-|0.1.8 vscode-jupyter-slideshow|ms-|0.1.5 azure-repos|ms-|0.38.0 cmake-tools|ms-|1.15.31 cpptools|ms-|1.17.5 cpptools-extension-pack|ms-|1.3.0 js-debug-nightly|ms-|2023.10.1217 remote-repositories|ms-|0.40.0 vscode-github-issue-notebooks|ms-|0.0.130 vscode-selfhost-test-provider|ms-|0.3.19 vscode-serial-monitor|ms-|0.10.0 vsliveshare|ms-|1.0.5883 autodocstring|njp|0.6.1 pandocciter|not|0.10.3 shiny-python|Pos|0.1.5 shinyuieditor|pos|0.5.0 quarto|qua|1.103.0 r-debugger|RDe|0.5.4 java|red|1.23.0 vscode-xml|red|0.26.1 r|REd|2.8.2 multi-command|ryu|1.6.0 vscode-deepl|soe|1.0.6 lua|sum|3.7.0 latex-utilities|tec|0.4.10 cmake|twx|0.0.17 errorlens|use|3.14.0 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.2.30 vscode-java-debug|vsc|0.54.0 vscode-java-dependency|vsc|0.23.1 vscode-java-pack|vsc|0.25.14 vscode-java-test|vsc|0.40.0 vscode-maven|vsc|0.42.0 markdown-all-in-one|yzh|3.5.1 grammarly|znc|0.22.1 (2 theme extensions excluded)
A/B Experiments ``` vsliv695:30137379 vsins829:30139715 vsliv368:30146709 vsreu685:30147344 python383cf:30185419 vspor879:30202332 vspor708:30202333 vspor363:30204092 vstes627:30244334 vslsvsres303:30308271 pythontb:30258533 pythonptprofiler:30281269 vshan820:30294714 vscod805cf:30301675 bridge0708:30335490 bridge0723:30353136 vsaa593:30376534 pythonvs932:30404738 py29gd2263:30784851 vsclangdf:30492506 c4g48928:30535728 dsvsc012:30540252 pynewext54:30618038 a9j8j154:30646983 showlangstatbar:30737417 ecj1e332:30687743 pythonfmttext:30716741 fixshowwlkth:30771523 showindicator:30805243 pythongtdpath:30726887 i26e3531:30792625 welcomedialog:30812478 pythonnosmt12:30779711 pythonidxpt:30768918 pythonnoceb:30776497 copilotsettingt:30808721 asynctok:30821568 dsvsc013:30777762 dsvsc014:30777825 diffeditorv2:30786206 pythonmpswarning:30859870 dsvsc015:30821418 pythontestfixt:30859590 pythonregdiag:30859652 pyreplss2:30858576 pythonmypyd1:30859725 pythoncet0:30859736 ```
meganrogge commented 11 months ago

@jooyoungseo not sure how complicated this would be to do.

@amunger , we do this for the terminal. Thoughts?

VSCodeTriageBot commented 11 months ago

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

amunger commented 11 months ago

I'll have to take a look at how the terminal is doing it, but I don't see why we wouldn't be able to do something similar for notebook outputs.

meganrogge commented 11 months ago

Here's where we do this for the terminal

https://github.com/microsoft/vscode/blob/2ebefa547dbfe57c3889ab062ce1eeb88b27d177/src/vs/workbench/contrib/terminalContrib/accessibility/browser/terminal.accessibility.contribution.ts#L100-L111