Panel badge should adopt style of activity bar

[bpasero]

They now look quite different:

I would suggest a consistent style and color for all.

[sandy081]

Got color, but can you elaborate on style?

[bpasero]

Maybe just the positioning, it seems quite far away from the label. I guess we cannot really do the overlay...

I wonder why we never went with icons for the panel? or maybe icon and text and the badge could be over the icon?

[bpasero]

I think a wrongly referenced commit message.

[sandy081]

I wonder why we never went with icons for the panel? or maybe icon and text and the badge could be over the icon?

Yeah, this is a very good thought

CC @hbons @daviddossett

[daviddossett]

I think this would be partly due to the difference between activityBarBadge.background and badge.background in our default themes. Aligning them could help here—I was already thinking of reverting back to that anyway.

Maybe just the positioning, it seems quite far away from the label.

Any specific reasoning for the gap between text and badge in panel tabs @Tyriar?

[Tyriar]

@daviddossett I think it's just been like that forever, before my time 🙂

[moritztim]

I would love to have Icons in the panel! Here's a mockup of the color scheme (Dark+ theme): I think a border would be needed between the side bars and the panel In comparison to the current color scheme, the mockup is definitely an improvement, imo.

[moritztim]

Mistakenly referenced in f1b7a36601d8d0508704f3402ee9376128afcbcc

[joaomoreno]

These will be aligned with https://github.com/microsoft/vscode/issues/227076

[gjsjohnmurray]

These will be aligned with #227076

This has brought us the option for icons instead of labels 👍, but the badge appearance hasn't been aligned with that of the side bars.

[sandy081]

That's correct and I can confirm