search

microsoft / vscode

Visual Studio Code
https://code.visualstudio.com
MIT License
162.98k stars 28.78k forks source link

Getting incorrect language features in diff editor, from GHPRI #196083

Open joaomoreno opened 11 months ago

joaomoreno commented 11 months ago

When reviewing a PR and opening a file which was modified in it, you will get TypeScript language features in the right-hand side editor that are incorrect. Feels like a regression to me.

https://github.com/microsoft/vscode/assets/22350/c1b0418a-4c77-4ddd-bea4-e499b6b056c5

@hediet @alexr00 @mjbvz It's hard to gauge who should own this, sorry for the multiple assignment.

alexr00 commented 11 months ago

The old behavior was to get no language features.

@mjbvz, the scheme for this file is pr. Is the typescript extension now providing language features for unknown schemes?

hediet commented 11 months ago

This is very unlikely a diff editor issue, as the diff editor just composes normal editors that open the provided ITextModel. If you reveal the file itself, you should see the same issue.