Source Control not picking up changes unless I click Refresh

Daviid-P commented 1 year ago

Does this issue occur when all extensions are disabled?: Yes

Version: 1.83.1 (user setup) Commit: f1b07bd25dfad64b0167beb15359ae573aecd2cc Date: 2023-10-10T23:48:05.904Z Electron: 25.8.4 ElectronBuildId: 24154031 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.22621

Not sure why, I have git.autorefresh set to true in global settings and workspace settings json.

emanual4real commented 12 months ago

I'm having the same issue on WSL but not on Windows. I disabled extensions and found out that this one was causing the issue on WSL, Nx Console (nrwl.angular-console)

Version: 1.84.0 (user setup) Commit: d037ac076cee195194f93ce6fe2bdfe2969cc82d Date: 2023-11-01T11:29:04.398Z Electron: 25.9.2 ElectronBuildId: 24603566 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.22621

Daviid-P commented 12 months ago

I'm having the same issue on WSL but not on Windows. I disabled extensions and found out that this one was causing the issue on WSL, Nx Console (nrwl.angular-console)

Version: 1.84.0 (user setup) Commit: d037ac0 Date: 2023-11-01T11:29:04.398Z Electron: 25.9.2 ElectronBuildId: 24603566 Chromium: 114.0.5735.289 Node.js: 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.22621

Thanks for the info, but I tried without any extension enabled and still got the error.

lszomoru commented 10 months ago

/gifPlease

vscodenpa commented 10 months ago

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.

If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.

Happy coding!

Daviid-P commented 10 months ago

Code_A3Q3rN4x86

Is it normal that I lose this header

When I only have one repository active? After deleting the changes the file is no longer modified but I can't click refresh since it's missing.

lszomoru commented 10 months ago

@Daviid-P, thanks for the additional information and the recording. Could you please use the "Developer: Toggle Developer Tools" command from the command palette and see if there are any relevant errors these.

Yes, it is expected that when you only have one repository selected, the repository row is not being shown. If you would like to have that always shown you can enable it using the following setting - scm.alwaysShowRepositories.

Daviid-P commented 10 months ago

@Daviid-P, thanks for the additional information and the recording. Could you please use the "Developer: Toggle Developer Tools" command from the command palette and see if there are any relevant errors these.

Yes, it is expected that when you only have one repository selected, the repository row is not being shown. If you would like to have that always shown you can enable it using the following setting - scm.alwaysShowRepositories.

This happened once after clicking refresh, however I couldn't reproduce it a second time so it might not be related and just happened to happen at the same time I clicked refresh.

But when I make changes, press ctrl + s or click refresh no errors pop out on the dev console.

lszomoru commented 10 months ago

Today's VS Code Insiders release (version details below) contains a fix for an issue that can result in the list of changes not being refreshed. Could you please try it out and let me know if it resolves the issue. Thanks!

Version: 1.86.0-insider (Universal)
Commit: a017b12b9caa3475675cfe6fda014fcf5af388c9
Date: 2023-12-19T05:38:28.077Z
Electron: 27.1.3
ElectronBuildId: 25612240
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Darwin arm64 23.1.0

Daviid-P commented 10 months ago

Version: 1.86.0-insider (user setup)
Commit: a017b12b9caa3475675cfe6fda014fcf5af388c9
Date: 2023-12-19T05:37:59.567Z
Electron: 27.1.3
ElectronBuildId: 25612240
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Windows_NT x64 10.0.22621

Code_-_Insiders_UvLAmgIBt8

I installed insiders, synced settings with stable and opened my workspace. Instantly the Source Control showed me 28 changes. Then I modified .htaccess, saved, no update on the Source Control list. This is shown in Developer Tools.

Code_-_Insiders_EwKGeN41an

When clicking refresh the change shows up in the list and no more output is shown in developer tools.

Daviid-P commented 10 months ago

Code_-_Insiders_4RAtts4p2G

It also seems like Discarding Changes has stopped updating the open editor. (I could've sworn this worked before even with my error but I just tried on stable and it does not)

Forgot to do it in the GIF but Show trailing/leading Whitespaces Differences show no difference either.

wyattPD commented 10 months ago

I am also hitting this issue. It's very annoying because I use VS Code as my git GUI and if I forget to refresh I get misleading information about my current state.

It seems if I don't refresh nothing changes in the Source Control tab (even the "current branch" in the bottom left is wrong until I refresh)

Version: 1.85.1 (Universal)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:48:06.308Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 22.4.0

Daviid-P commented 10 months ago

For some reason if I click commit and it fails due to PHPCS Code Sniffer and PHPCBF fixes automatically modifying the file, then it seems like source control is automatically picking up those changes

lszomoru commented 9 months ago

There are couple of more fixes that went in during the last weeks so I would really appreciate if you could try again the latest VS Code Insiders and see if you are still able to reproduce the issue. Thanks!

Version: 1.86.0-insider (Universal)
Commit: aed5f4d65d2dbfda2c98abd7eb371751016838ab
Date: 2024-01-17T07:05:12.529Z
Electron: 27.2.1
ElectronBuildId: 26149897
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Darwin arm64 23.2.0

wyattPD commented 9 months ago

I no longer repro! I actually stopped repro'ing a few weeks ago (sorry for not updating)

I didn't change anything (that I'm aware of) the problem just sort of... went away?

Version: 1.85.1 (Universal)
Commit: 0ee08df0cf4527e40edc9aa28f4b5bd38bbff2b2
Date: 2023-12-13T09:48:06.308Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 22.4.0

Daviid-P commented 9 months ago

Seems to still be happening to me.

Version: 1.86.0-insider (user setup)
Commit: feff7c8a7e1c82320380f42d898a1e03051fefb7
Date: 2024-01-26T03:26:40.730Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Windows_NT x64 10.0.22631

I wonder if this is some kind of PC configuration thing.

Code_-_Insiders_KFzMCIxvq2

This is right after saving

Code_-_Insiders_Zwycfddd3J

Any other actions don't show any other logs in Developer Console, just saving the file will repeat those messages.

lszomoru commented 9 months ago

@Daviid-P, could you please check to make sure that the git.autorefresh setting is enabled? If the setting is enabled, we should look at whether file system events are being fired as that is what drives the refresh of the "Source Control" view.

Enable trace logging for the git extension and reproduce the issue:

Invoke the "Developer: Set Log Level..." command from the command palette
Pick the "Git" extension from the list of extension
Pick "Trace" as the log level
Modify a file, and save it
Share the content of the git output window

Daviid-P commented 9 months ago

@lszomoru

Here's a video, git.autorefresh is enabled in main settings and in workspace settings.

https://github.com/microsoft/vscode/assets/7734808/e09bd59b-cbff-4311-b72e-b5b74c089cb3

Output in text

2024-01-29 09:44:05.875 [trace] [svte] Scan visible text editors. autoRepositoryDetection=true
2024-01-29 09:44:05.875 [trace] [svte] Repository for editor resource c:\xampp7\htdocs\Dolibarr16.0.3\.htaccess already exists: c:\xampp7\htdocs\Dolibarr16.0.3
2024-01-29 09:44:06.106 [trace] Operation start: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-01-29 09:44:06.134 [trace] Operation start: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-01-29 09:44:06.535 [info] > git ls-files --stage -- C:\xampp7\htdocs\Dolibarr16.0.3\.htaccess [401ms]
2024-01-29 09:44:06.700 [info] > git show --textconv :.htaccess [594ms]
2024-01-29 09:44:06.701 [trace] Operation end: Show (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-01-29 09:44:06.900 [info] > git cat-file -s 4b1bdc607f3da528598634acfb8b8117c41c8fda [340ms]
2024-01-29 09:44:06.900 [trace] Operation end: GetObjectDetails (blocking: false, readOnly: true; retry: false; showProgress: false)
2024-01-29 09:44:23.510 [trace] Operation start: Refresh (blocking: false, readOnly: false; retry: false; showProgress: true)
2024-01-29 09:44:23.965 [info] > git config --get commit.template [435ms]
2024-01-29 09:44:24.011 [info] > git for-each-ref --format=%(refname)%00%(upstream:short)%00%(objectname)%00%(upstream:track)%00%(upstream:remotename)%00%(upstream:remoteref) --ignore-case refs/heads/custom refs/remotes/custom [413ms]
2024-01-29 09:44:24.728 [info] > git status -z -uall [703ms]
2024-01-29 09:44:24.737 [trace] Operation end: Refresh (blocking: false, readOnly: false; retry: false; showProgress: true)

lszomoru commented 9 months ago

Thanks! The logs do confirm that there is not file system event so we would have to try to get to the bottom of that. Could you please follow the steps in the wiki, and share the logs that are being generated? Thanks!

Daviid-P commented 9 months ago

@lszomoru Found this

log.ts:397 TRACE [File Watcher (parcel)] ignoring a path for watching who's realpath failed to resolve: c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\** (error: Error: ENOENT: no such file or directory, access 'c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\**')

log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (parcel)] ignoring a path for watching who's realpath failed to resolve: c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\** (error: Error: ENOENT: no such file or directory, access 'c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\**')
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage

This is after modifying a file and saving, then clicking refresh on source control.

Daviid-P commented 9 months ago

TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage

This seems periodic, even if I do nothing.

TRACE [File Watcher (parcel)] ignoring a path for watching who's realpath failed to resolve: c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\** (error: Error: ENOENT: no such file or directory, access 'c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\**')

This one happens right after clicking refresh

Daviid-P commented 9 months ago

My settings

C:\Users\dpareja\AppData\Roaming\Code\User\settings.json

"files.watcherExclude": {
  "": true,
  "**/.git/objects/**": true,
  "**/.git/subtree-cache/**": true,
  "**/.hg/store/**": true,
  "**/.tx/**": true,
  "**/.vscode/**": true,
  "**/node_modules/*/**": true
},
"files.watcherInclude": [
  "**/htdocs/**"
],

lszomoru commented 9 months ago

@Daviid-P, what is the path of the file that you have modified, and saved? @bpasero, any idea what is happening here? Thank you!

bpasero commented 9 months ago

This issue could originate from a problem with file watching. Let me explain how file watching works in VSCode first and then provide some details how to get more logging data from how file watching behaves in your case.

Synopsis VSCode has different strategies for file watching depending on your workspace and setup:

no folder opened: files in opened editors are watched via node.js fs.watch
folder opened: folder is watched recursively for all changes via parcel, opened editors with files not within the folder are watched via node.js fs.watch

If you are connected to a remote (SSH, WSL, Docker), the file watcher will run within the target file system. As such, even though you maybe on Windows where VSCode runs, if the remote is Linux, the file watcher will run in the Linux environment.

Platforms Depending on the platform you are on, file watching is differently implemented:

macOS: using fsevents services
Windows: using ReadDirectoryChangesW method
Linux: using inotify

Specifically on Linux, watching a large folder recursively can result in VSCode consuming too many file handles. If that is the case, you will see a warning notification with instructions how to solve that.

Limitations File watching comes with a set of limitations:

symbolic links are not followed automatically but you can explicitly add symbolic links to be watched via the files.watcherInclude setting
mapped network drives or third party file system drivers are not guaranteed to produce file events
in general, the operating system may decide to drop file events at any time, there is no 100% guarantee

Settings Please review your settings to see if maybe a folder is excluded by accident. Specifically, the files.watcherExclude setting is relevant.

Logging (local) !!! This is ONLY when you open a local workspace, for remote see below !!! We provide logging for file events when you enable verbose logging. Steps are:

open VSCode on the local workspace that shows the issue
select View | Command Palette...
select Developer - Set Log Level...
pick Trace
select Help | Toggle Developer Tools
select Console
filter the output by typing File Watcher into the filter box
attach the output when doing the operation that exhibits the issue

Logging (remote) !!! This is ONLY when you open a remote workspace (WSL, Docker, SSH), for local see above !!! We provide logging for file events when you enable verbose logging. Steps are:

open VSCode on the remote workspace that shows the issue
select View | Command Palette...
select Developer - Set Log Level...
pick Trace
select View | Output
select Log (Remote Server) from the dropdown
attach the output when doing the operation that exhibits the issue

lszomoru commented 9 months ago

@bpasero, logs have been provided here using the instructions from the wiki. Did I miss something?

bpasero commented 9 months ago

Not sure if related, but you cannot configure a glob pattern for the files.watcherInclude setting. That setting is meant to watch extra paths in the workspace if they are symbolic links, which normally are not followed.

Daviid-P commented 9 months ago

TRACE [File Watcher (parcel)] ignoring a path for watching who's realpath failed to resolve: c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\** (error: Error: ENOENT: no such file or directory, access 'c:\xampp7\htdocs\Dolibarr16.0.3\**\htdocs\**') I removed files.watcherInclude, the error is gone but the main problem persists.

@lszomoru the full path is C:\xampp7\htdocs\Dolibarr16.0.3\.htaccess

Daviid-P commented 9 months ago

log.ts:397 TRACE writeTextAreaState(reason: focusgain)
log.ts:397 TRACE writeTextAreaState(reason: selection changed)
log.ts:397 TRACE [History stack global-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: user)
log.ts:397 TRACE [History stack global-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: user)
log.ts:397 TRACE [History stack global-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: user)
log.ts:397 TRACE [History stack global-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack global-default]: index: 1, navigating: false
- group: 0, editor: untitled:Untitled-1, selection: line: 58-58, col:  48-62
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 12-12, col:  1-1

log.ts:397 TRACE [text file model] resolve() - enter file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] resolveFromFile() file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
3log.ts:397 TRACE CommandService#executeCommand _setContext
log.ts:397 TRACE [text file model] resolveFromContent() - enter file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] doUpdateTextModel() file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [History stack global-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack global-default]: index: 1, navigating: false
- group: 0, editor: untitled:Untitled-1, selection: line: 58-58, col:  48-62
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 12-12, col:  1-1

log.ts:397 TRACE [History stack edits-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack edits-default]: index: 0, navigating: false
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 12-12, col:  1-1

log.ts:397 TRACE [text file model] onModelContentChanged() - enter file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] onModelContentChanged() - new versionId 3 file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE CommandService#executeCommand _setContext
log.ts:397 TRACE KeybindingService#dispatch Enter [ No matching keybinding ]
log.ts:397 TRACE CommandService#executeCommand type
log.ts:397 TRACE [text file model] onModelContentChanged() - enter file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] onModelContentChanged() - new versionId 4 file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] onModelContentChanged() - model content changed and marked as dirty file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [backup tracker] scheduling backup file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess 
log.ts:397 TRACE [backup tracker] clearing pending backup creation file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess 
log.ts:397 TRACE [backup tracker] scheduling backup file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess 
log.ts:397 TRACE writeTextAreaState(reason: selection changed)
log.ts:397 TRACE [History stack global-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack global-default]: index: 1, navigating: false
- group: 0, editor: untitled:Untitled-1, selection: line: 58-58, col:  48-62
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 13-13, col:  1-1

log.ts:397 TRACE [History stack edits-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack edits-default]: index: 0, navigating: false
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 13-13, col:  1-1

log.ts:397 TRACE [History stack global-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: user)
log.ts:397 TRACE [History stack global-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: user)
log.ts:397 TRACE [History stack global-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: user)
log.ts:397 TRACE [History stack global-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack global-default]: index: 1, navigating: false
- group: 0, editor: untitled:Untitled-1, selection: line: 58-58, col:  48-62
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 13-13, col:  1-1

3log.ts:397 TRACE CommandService#executeCommand _setContext
log.ts:397 TRACE KeybindingService#dispatch Ctrl+S [ Will dispatch command workbench.action.files.save ]
log.ts:397 TRACE CommandService#executeCommand workbench.action.files.save
log.ts:397 TRACE [text file model] save() - enter file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] doSave(4) - enter with versionId 4 file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:407 DEBUG _performTextEdits [{"resource":{"$mid":1,"fsPath":"c:\\xampp7\\htdocs\\Dolibarr16.0.3\\.htaccess","_sep":1,"external":"file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess","path":"/c:/xampp7/htdocs/Dolibarr16.0.3/.htaccess","scheme":"file"},"textEdit":{"range":{"startLineNumber":1,"startColumn":1,"endLineNumber":1,"endColumn":1},"text":"","eol":0}}]
log.ts:397 TRACE FORMAT#computeMoreMinimalEdits file:///c:/xampp7/htdocs/Dolibarr16.0.3/.htaccess 0.7000000476837158
log.ts:397 TRACE [History stack global-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack global-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack global-default]: index: 1, navigating: false
- group: 0, editor: untitled:Untitled-1, selection: line: 58-58, col:  48-62
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 13-13, col:  1-1

log.ts:397 TRACE [History stack edits-default]: notifyNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: notifyNavigation() not ignoring (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: onSelectionAwareEditorNavigation() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: edit)
log.ts:397 TRACE [History stack edits-default]: replace() (editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, event: <none>)
log.ts:397 TRACE [History stack edits-default]: index: 0, navigating: false
- group: 0, editor: file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess, selection: line: 13-13, col:  1-1

log.ts:397 TRACE [text file model] onModelContentChanged() - enter file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] onModelContentChanged() - new versionId 5 file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] onModelContentChanged() - model content changed and marked as dirty file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [backup tracker] clearing pending backup creation file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess 
log.ts:397 TRACE [backup tracker] scheduling backup file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess 
log.ts:397 TRACE [text file model] doSave(5) - before write() file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] handleSaveSuccess(5) - setting dirty to false because versionId did not change file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [backup tracker] clearing pending backup creation file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess 
log.ts:397 TRACE [backup tracker] discarding backup file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess 
log.ts:397 TRACE [text file model] save() - exit file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:437   ERR [Extension Host] warning: in the working copy of '.htaccess', LF will be replaced by CRLF the next time Git touches it
console.ts:137 [Extension Host] warning: in the working copy of '.htaccess', LF will be replaced by CRLF the next time Git touches it (at console.<anonymous> (c:\Users\dpareja\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:57439))
p @ console.ts:137
$logExtensionHostMessage @ mainThreadConsole.ts:39
S @ rpcProtocol.ts:458
Q @ rpcProtocol.ts:443
M @ rpcProtocol.ts:373
L @ rpcProtocol.ts:299
(anonymous) @ rpcProtocol.ts:161
y @ event.ts:1127
fire @ event.ts:1158
fire @ ipc.net.ts:650
x.onmessage @ localProcessExtensionHost.ts:376
localProcessExtensionHost.ts:273 Extension Host
localProcessExtensionHost.ts:274 warning: in the working copy of '.htaccess', LF will be replaced by CRLF the next time Git touches it
log.ts:397 TRACE CommandService#executeCommand _setContext
log.ts:407 DEBUG Comments: URIs of continue on comments to add to storage .
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:407 DEBUG User data changed
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:407 DEBUG User data changed
log.ts:407 DEBUG Comments: URIs of continue on comments to add to storage .
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:407 DEBUG User data changed
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
 DEBUG User data changed

Dev console without filewatcher filter.

This is when I press Ctrl - S

TRACE [text file model] save() - exit file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:437   ERR [Extension Host] warning: in the working copy of '.htaccess', LF will be replaced by CRLF the next time Git touches it
console.ts:137 [Extension Host] warning: in the working copy of '.htaccess', LF will be replaced by CRLF the next time Git touches it (at console.<anonymous> (c:\Users\dpareja\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\workbench\api\node\extensionHostProcess.js:140:57439))
p @ console.ts:137
$logExtensionHostMessage @ mainThreadConsole.ts:39
S @ rpcProtocol.ts:458
Q @ rpcProtocol.ts:443
M @ rpcProtocol.ts:373
L @ rpcProtocol.ts:299
(anonymous) @ rpcProtocol.ts:161
y @ event.ts:1127
fire @ event.ts:1158
fire @ ipc.net.ts:650
x.onmessage @ localProcessExtensionHost.ts:376
localProcessExtensionHost.ts:273 Extension Host
localProcessExtensionHost.ts:274 warning: in the working copy of '.htaccess', LF will be replaced by CRLF the next time Git touches it
log.ts:407 DEBUG Comments: URIs of continue on comments to add to storage .

This is after clicking refresh on Source COntrol

TRACE writeTextAreaState(reason: focusgain)
log.ts:397 TRACE [text file model] resolve() - enter file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE [text file model] resolveFromFile() file:///c%3A/xampp7/htdocs/Dolibarr16.0.3/.htaccess
log.ts:397 TRACE CommandService#executeCommand git.refresh
log.ts:397 TRACE CommandService#executeCommand _setContext
log.ts:397 TRACE MainThreadFileSystemEventService#$unwatch(): request to stop watching (session: 0.21452719236572748)
log.ts:397 TRACE MainThreadFileSystemEventService#$watch(): request to start watching uncorrelated (extension: vscode.git, path: file:///c:/xampp7/htdocs/Dolibarr16.0.3/.git/refs/remotes/origin/custom, recursive: false, session: 0.5655823283244321)
7log.ts:397 TRACE CommandService#executeCommand _setContext

bpasero commented 9 months ago

@Daviid-P for me to understand, you edit the file C:\xampp7\htdocs\Dolibarr16.0.3\.htaccess but the SCM view does not show the change? What workspace folder are you opening?

Daviid-P commented 9 months ago

@bpasero correct, the Source Control (Ctrl + Shift + G) does not pick up the changed file until I press Refresh.

My workspace folder is C:\xampp7\htdocs\Dolibarr16.0.3\

I use the extension Workspace Switcher.

In my file C:\Users\dpareja\Documents\vscode\workspaces\Dolibarr16.0.3.code-workspace I have

{
  "folders": [
    {
      "name": "Base",
      "path": "c:\\xampp7\\htdocs\\Dolibarr16.0.3"
    },
}

And inside C:\xampp7\htdocs\Dolibarr16.0.3\.vscode\settings.json

I only have

{
  "[javascript]": {
    "editor.formatOnSave": true,
    "editor.formatOnSaveMode": "file",
    "editor.defaultFormatter": "vscode.typescript-language-features"
  },
  "[html]": {
    "editor.formatOnSave": true,
    "editor.formatOnSaveMode": "file",
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[json]": {
    "editor.formatOnSave": true,
    "editor.formatOnSaveMode": "file",
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "python.formatting.provider": "black",
  "cmake.configureOnOpen": false
}

Daviid-P commented 9 months ago

Not sure if related but if I make changes, refresh and then click "Discard changes", the file I have open doesn't get automatically updated, if I change tabs to a different file and go back then it gets updated and the discarded changes are gone.

bpasero commented 9 months ago

Does it reproduce when you just open C:\xampp7\htdocs\Dolibarr16.0.3 as a folder and disable the extensions you have installed such as the switcher one?

Daviid-P commented 9 months ago

@bpasero

Yes, Reloaded with extensions disabled and still reproduced the error.

Opened new window and opened folder C:\xampp7\htdocs\Dolibarr16.0.3 and still reproduced the error.

This video is recorded with extensions disabled and opened C:\xampp7\htdocs\Dolibarr16.0.3 via Open Folder Ctrl+K Ctrl+O

It's too big (17MB) to post here so I added it to a repo. https://github.com/Daviid-P/VideoTooBig/raw/main/Code_-_Insiders_cAcWf2nWXu.mp4

bpasero commented 9 months ago

Does this reproduce with any file in that folder and other folders as well or only this specific case?

Daviid-P commented 9 months ago

It reproduces with any file, any folder.

Creating a new folder C:\git_test initializing a repository from inside vscode and adding a new file yields the same results, I must click Refresh for it to update.

bpasero commented 9 months ago

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Daviid-P commented 9 months ago

@bpasero I'm using insider for all these tests.

Version: 1.86.0-insider (user setup)
Commit: 9c5eabb378c9d18a0f712d1f22fe63df3f933ade
Date: 2024-01-30T03:56:13.017Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Windows_NT x64 10.0.22631

No updates detected.

bpasero commented 9 months ago

Got it. Can we narrow down the logs to a specific test sample. Open C:\git_test, have a file test.txt, make changes in the editor and send me the verbose file watcher logs? Then we have a small isolated sample.

Daviid-P commented 9 months ago

log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [ADDED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] objects
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\objects
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\objects
log.ts:397 TRACE [File Watcher (node.js)] [DELETED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [ADDED] c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [ADDED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] objects
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\objects
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\objects
log.ts:397 TRACE [File Watcher (node.js)] [DELETED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [ADDED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index
log.ts:397 TRACE [File Watcher (node.js)] [DELETED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [ADDED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index.lock
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["rename"] index
log.ts:397 TRACE [File Watcher (node.js)] [DELETED] c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index.lock
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
log.ts:397 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
log.ts:397 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage

Recorded a video so you can see exactly what I did.

https://github.com/microsoft/vscode/assets/7734808/f45538cf-5451-4ed9-8d4a-6f52506e6805

bpasero commented 9 months ago

Can you share the beginning of the log, where it talks about which file watcher gets installed? Right when you open the folder.

Daviid-P commented 9 months ago

Closed the folder, cleared console and opened folder again.

workbench.desktop.main.js:sourcemap:655 TRACE PolicyConfiguration#updatePolicyDefinitions (1719) ['[clojure]', '[coffeescript]', '[csharp]', '[css]', '[scss]', '[less]', '[dockerfile]', '[fsharp]', '[git-commit]', '[git-rebase]', '[go]', '[html]', '[handlebars]', '[javascript]', '[json]', '[jsonc]', '[makefile]', '[markdown]', '[jade]', '[python]', '[search-result]', '[shellscript]', '[yaml]', '[dockercompose]', '[django-html]', '[dart]', 'files.watcherExclude', 'explorer.fileNesting.patterns', '[cmake]', '[cpp]', '[cuda-cpp]', '[c]', 'css.customData', 'css.completion.triggerPropertyValueCompletion', 'css.completion.completePropertyWithSemicolon', 'css.validate', 'css.hover.documentation', 'css.hover.references', 'css.lint.compatibleVendorPrefixes', 'css.lint.vendorPrefix', 'css.lint.duplicateProperties', 'css.lint.emptyRules', 'css.lint.importStatement', 'css.lint.boxModel', 'css.lint.universalSelector', 'css.lint.zeroUnits', 'css.lint.fontFaceProperties', 'css.lint.hexColorLength', 'css.lint.argumentsInColorFunction', 'css.lint.unknownProperties', 'css.lint.validProperties', 'css.lint.ieHack', 'css.lint.unknownVendorSpecificProperties', 'css.lint.propertyIgnoredDueToDisplay', 'css.lint.important', 'css.lint.float', 'css.lint.idSelector', 'css.lint.unknownAtRules', 'css.trace.server', 'css.format.enable', 'css.format.newlineBetweenSelectors', 'css.format.newlineBetweenRules', 'css.format.spaceAroundSelectorSeparator', 'css.format.braceStyle', 'css.format.preserveNewLines', 'css.format.maxPreserveNewLines', 'scss.completion.triggerPropertyValueCompletion', 'scss.completion.completePropertyWithSemicolon', 'scss.validate', 'scss.hover.documentation', 'scss.hover.references', 'scss.lint.compatibleVendorPrefixes', 'scss.lint.vendorPrefix', 'scss.lint.duplicateProperties', 'scss.lint.emptyRules', 'scss.lint.importStatement', 'scss.lint.boxModel', 'scss.lint.universalSelector', 'scss.lint.zeroUnits', 'scss.lint.fontFaceProperties', 'scss.lint.hexColorLength', 'scss.lint.argumentsInColorFunction', 'scss.lint.unknownProperties', 'scss.lint.validProperties', 'scss.lint.ieHack', 'scss.lint.unknownVendorSpecificProperties', 'scss.lint.propertyIgnoredDueToDisplay', 'scss.lint.important', 'scss.lint.float', 'scss.lint.idSelector', 'scss.lint.unknownAtRules', 'scss.format.enable', 'scss.format.newlineBetweenSelectors', 'scss.format.newlineBetweenRules', 'scss.format.spaceAroundSelectorSeparator', 'scss.format.braceStyle', 'scss.format.preserveNewLines', 'scss.format.maxPreserveNewLines', 'less.completion.triggerPropertyValueCompletion', 'less.completion.completePropertyWithSemicolon', …]
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Request to start watching: c:\Users\dpareja\AppData\Roaming\Code - Insiders\User (excludes: <none>, includes: <all>, correlationId: <none>),c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\settings.json (excludes: <none>, includes: <all>, correlationId: <none>),c:\git_test\.vscode (excludes: <none>, includes: <all>, correlationId: <none>),c:\git_test\.vscode\settings.json (excludes: <none>, includes: <all>, correlationId: <none>),c:\git_test\.vscode\tasks.json (excludes: <none>, includes: <all>, correlationId: <none>),c:\git_test\.vscode\launch.json (excludes: <none>, includes: <all>, correlationId: <none>),c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\keybindings.json (excludes: <none>, includes: <all>, correlationId: <none>)
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat 'c:\git_test\.vscode\settings.json'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat 'c:\git_test\.vscode'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat 'c:\git_test\.vscode\tasks.json'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat 'c:\git_test\.vscode\launch.json'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Started watching: 'c:\Users\dpareja\AppData\Roaming\Code - Insiders\User'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Started watching: 'c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\settings.json'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Started watching: 'c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\keybindings.json'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Request to start watching: c:\Users\dpareja\.vscode-insiders\extensions\pkief.material-icon-theme-4.33.0\dist\material-icons.json (excludes: <none>, includes: <all>, correlationId: <none>)
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Started watching: 'c:\Users\dpareja\.vscode-insiders\extensions\pkief.material-icon-theme-4.33.0\dist\material-icons.json'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Request to start watching: c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\tasks.json (excludes: <none>, includes: <all>, correlationId: <none>)
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Error: ENOENT: no such file or directory, stat 'c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\tasks.json'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (parcel)] Request to start watching: c:\git_test (excludes: **/.dart_tool,,**/.git/objects/**,**/.git/subtree-cache/**,**/.hg/store/**,**/.tx/**,**/.vscode/**,**/node_modules/*/**, includes: <all>, correlationId: <none>)
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (parcel)] Started watching: 'c:\git_test' with backend 'windows'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Request to start watching: c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\snippets (excludes: <none>, includes: <all>, correlationId: <none>)
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Started watching: 'c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\snippets'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Request to start watching: c:\git_test\.git (excludes: <none>, includes: ["**/.dart_tool/**","/**","**/.git/objects/**/**","**/.git/subtree-cache/**/**","**/.hg/store/**/**","**/.tx/**/**","**/.vscode/**/**","**/node_modules/*/**/**"], correlationId: <none>)
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] Started watching: 'c:\git_test\.git'
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] refs
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\refs
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\refs
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] index
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\index
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\index
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] info
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\git_test\.git\info
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> ignored (not included) c:\git_test\.git\info
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [raw] ["change"] globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)] [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage
workbench.desktop.main.js:sourcemap:655 TRACE [File Watcher (node.js)]  >> normalized [CHANGED] c:\Users\dpareja\AppData\Roaming\Code - Insiders\User\globalStorage

bpasero commented 9 months ago

@Daviid-P there is something in the output that confuses me:

excludes: **/.dart_tool,,**/.git/objects/**,**/.git/subtree-cache/**,**/.hg/store/**,**/.tx/**,**/.vscode/**,**/node_modules/*/**

Notice the ,, in the list, so it seems like you have some setting to configure excludes. Are you sure you are not configuring files.watcherExclude setting somewhere?

Daviid-P commented 9 months ago

Yes, on C:\Users\dpareja\AppData\Roaming\Code\User\settings.json

{
  "editor.lineNumbers": "relative",
  "explorer.confirmDelete": false,
  "git.confirmSync": false,
  "workbench.iconTheme": "material-icon-theme",
  "workbench.colorTheme": "Monokai Night",
  "workbench.colorCustomizations": {
    //"editor.selectionBackground": "#135564",
    //"editor.selectionHighlightBackground": "#135564",
    "editor.selectionBackground": "#e788ff7c", //Currently SELECTED text
    "editor.selectionHighlightBackground": "#ff00005b", //Same content as selection
    "editor.findMatchBackground": "#00cc44a8", //Current SEARCH MATCH
    "editor.findMatchHighlightBackground": "#ff7b00a1", //Other SEARCH MATCHES
    "numberedBookmarks.lineBackground": "#007700"
  },
  "files.associations": {
    ".inc": "php",
    ".phtml": "php",
    "*.inc": "php",
    "*.twig": "twig"
  },
  // "[php]": {
  //   "editor.defaultFormatter": "bmewburn.vscode-intelephense-client"
  // },
  "[txt]": {
    "editor.wordWrap": "off"
  },
  "editor.gotoLocation.alternativeTypeDefinitionCommand": "editor.action.goToTypeDefinition",
  "explorer.confirmDragAndDrop": false,
  "editor.unicodeHighlight.ambiguousCharacters": false,
  "editor.largeFileOptimizations": false,
  "terminal.integrated.enableMultiLinePasteWarning": false,
  "php.suggest.basic": false,
  "editor.wordWrap": "wordWrapColumn",
  "editor.wordWrapColumn": 90,
  "python.formatting.provider": "black",
  "[python]": {
    "editor.formatOnSave": false,
    "editor.defaultFormatter": "ms-python.black-formatter",
    "editor.formatOnType": true
  },
  "security.workspace.trust.untrustedFiles": "open",
  "editor.renderWhitespace": "all",
  "emmet.includeLanguages": {
    "django-html": "html"
  },
  "npm.keybindingsChangedWarningShown": true,
  "scm.diffDecorationsIgnoreTrimWhitespace": "true",
  "editor.fontFamily": "CaskaydiaCove NF Mono",
  "vscodeWorkspaceSwitcher.paths": [
    "C:/Users/dpareja/Documents/vscode/workspaces"
  ],
  "editor.rulers": [90],
  "[html]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[javascript]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "omnisharp.useModernNet": false,
  "editor.multiCursorLimit": 100000,
  "[php]": {
    "editor.defaultFormatter": "bmewburn.vscode-intelephense-client"
  },
  "python.analysis.autoImportCompletions": true,
  "javascript.preferences.importModuleSpecifierEnding": "js",
  "[css]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[markdown]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "[json]": {
    "editor.defaultFormatter": "esbenp.prettier-vscode"
  },
  "todo-tree.general.tags": [
    "evTODO"
  ],
  "better-comments.tags": [

    {
      "tag": "!",
      "color": "#FF2D00",
      "strikethrough": false,
      "underline": false,
      "backgroundColor": "transparent",
      "bold": false,
      "italic": false
    },
    {
      "tag": "?",
      "color": "#3498DB",
      "strikethrough": false,
      "underline": false,
      "backgroundColor": "transparent",
      "bold": false,
      "italic": false
    },
    {
      "tag": "//",
      "color": "#474747",
      "strikethrough": true,
      "underline": false,
      "backgroundColor": "transparent",
      "bold": false,
      "italic": false
    },
    {
      "tag": "todo",
      "color": "#FF8C00",
      "strikethrough": false,
      "underline": false,
      "backgroundColor": "transparent",
      "bold": false,
      "italic": false
    },
    {
      "tag": "evTODO",
      "color": "#9003FC",
      "strikethrough": false,
      "underline": false,
      "backgroundColor": "transparent",
      "bold": true,
      "italic": false
    },
    {
      "tag": "*",
      "color": "#98C379",
      "strikethrough": false,
      "underline": false,
      "backgroundColor": "transparent",
      "bold": false,
      "italic": false
    }
  ],
  "files.saveConflictResolution": "overwriteFileOnDisk",
  "jupyter.interactiveWindow.textEditor.executeSelection": true,
  "extensions.ignoreRecommendations": true,
  "security.allowedUNCHosts": [
    "127.0.0.1",
    "192.168.1.46",
    "192.168.1.9"
  ],
"editor.detectIndentation": true,
"editor.indentSize": "tabSize",
"editor.insertSpaces": false,
"editor.tabSize": 4,
"prettier.endOfLine": "auto",
"prettier.tabWidth": 4,
"prettier.useTabs": true,
"update.showReleaseNotes": false,
"remote.SSH.remotePlatform": {
  "192.168.1.131": "linux"
},
"files.watcherExclude": {
  "": true,
  "**/.git/objects/**": true,
  "**/.git/subtree-cache/**": true,
  "**/.hg/store/**": true,
  "**/.tx/**": true,
  "**/.vscode/**": true,
  "**/node_modules/*/**": true
},
"jupyter.askForKernelRestart": false,
"diffEditor.hideUnchangedRegions.enabled": true,
"diffEditor.experimental.showMoves": true,
"diffEditor.useInlineViewWhenSpaceIsLimited": false,
"terminal.integrated.enablePersistentSessions": false,
  // "editor.cursorSurroundingLines": 1000
  "scm.alwaysShowRepositories": true,
  "window.zoomLevel": 1,
  "git.openRepositoryInParentFolders": "never",
  "gitblame.inlineMessageEnabled": true,
  "editor.wrappingIndent": "deepIndent"
}

"files.watcherExclude": {
  "": true,
  "**/.git/objects/**": true,
  "**/.git/subtree-cache/**": true,
  "**/.hg/store/**": true,
  "**/.tx/**": true,
  "**/.vscode/**": true,
  "**/node_modules/*/**": true
},

and according to Timeline the "": true, line was added on October 23, 2023

And apparently right after I added

"files.watcherInclude": [
  "**/htdocs/**"
]

🤦‍♂️🤦‍♂️

microsoft / vscode

Source Control not picking up changes unless I click Refresh #196807