return of React useEffect not working properly in vscode extension development

[StephaneAdeso]

Type: Bug

I'm creating an extension for vscode in typescript, axios, rxjs and react. My extension is similar to postman or thunderclient. I am using the return of the useEffect hook to clear the subscription of an observable that collects data from an http request. The problem is that as soon as the component is loaded, the disassembly of the component is launched. I've been reviewing the code and it looks like vscode is doing something weird behind the scenes that breaks the cleanup mechanism of the useEffect hook.

https://github.com/microsoft/vscode/assets/55595063/21dc5fb0-9fbf-43c4-b0ae-40d73cb0d592

VS Code version: Code 1.83.1 (f1b07bd25dfad64b0167beb15359ae573aecd2cc, 2023-10-10T23:48:05.904Z) OS version: Windows_NT x64 10.0.22621 Modes:

System Info

|Item|Value| |---|---| |CPUs|11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 x 2304)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|31.79GB (19.00GB free)| |Process Argv|--crash-reporter-id ccedd11e-cbe3-4aab-835a-b81d8cc295d7| |Screen Reader|no| |VM|0%|

Extensions (41)

Extension|Author (truncated)|Version ---|---|--- codesnap|adp|1.3.4 tsl-problem-matcher|amo|0.6.2 ng-template|Ang|16.1.8 cssrem|cip|3.1.1 continue|Con|0.0.413 vscode-eslint|dba|2.4.2 es7-react-js-snippets|dsz|4.4.3 gitlens|eam|14.4.1 prettier-vscode|esb|10.1.0 code-runner|for|0.12.1 fetch-client|Gan|1.3.0 todo-tree|Gru|0.0.226 Angular2|joh|16.0.1 vscode-peacock|joh|4.2.2 vscode-colorize|kam|0.11.1 git-graph|mhu|1.30.0 isort|ms-|2023.10.1 python|ms-|2023.18.0 vscode-pylance|ms-|2023.10.50 live-server|ms-|0.4.11 vsliveshare|ms-|1.0.5892 vscode-versionlens|pfl|1.9.1 postman-for-vscode|Pos|0.12.1 vscode-thunder-client|ran|2.14.1 fabric8-analytics|red|0.7.0 java|red|1.24.0 vscode-xml|red|0.26.1 vscode-yaml|red|1.14.0 vs-code-prettier-eslint|rve|5.1.0 partial-diff|ryu|1.4.3 errorlens|use|3.15.0 intellicode-api-usage-examples|Vis|0.2.8 vscodeintellicode|Vis|1.2.30 vscode-java-debug|vsc|0.54.0 vscode-java-dependency|vsc|0.23.2 vscode-java-pack|vsc|0.25.15 vscode-java-test|vsc|0.40.1 vscode-maven|vsc|0.43.0 vscode-icons|vsc|12.6.0 JavaScriptSnippets|xab|1.8.0 markdown-all-in-one|yzh|3.5.1 (1 theme extensions excluded)

A/B Experiments

``` vsliv368:30146709 vsreu685:30147344 python383:30185418 vspor879:30202332 vspor708:30202333 vspor363:30204092 vslsvsres303:30308271 vserr242:30382549 pythontb:30283811 vsjup518:30340749 pythonptprofiler:30281270 vshan820:30294714 vstes263:30335439 vscorecescf:30445987 vscod805:30301674 binariesv615:30325510 bridge0708:30335490 bridge0723:30353136 vsaa593cf:30376535 pythonvs932:30410667 py29gd2263cf:30856253 vsclangdc:30486549 c4g48928:30535728 dsvsc012:30540252 pynewext54:30695312 azure-dev_surveyone:30548225 3biah626:30602489 89544117:30613380 a9j8j154:30646983 showlangstatbar:30737416 03d35959:30757346 pythonfmttext:30731395 fixshowwlkth:30771522 showindicator:30805244 pythongtdpath:30769146 i26e3531:30792625 pythonnosmt12:30797651 pythonidxpt:30866567 pythonnoceb:30805159 copilotsettingc:30859502 synctok:30869157 dsvsc013:30795093 dsvsc014:30804076 pythonmpsinfo:30842941 dsvsc015:30845448 pythontestfixtcf:30871695 pythonregdiag2:30871582 pyreplss1:30865275 pythoncet00cf:30874137 h48ei257:30870396 pythontbext0:30864172 ```

[mjbvz]

Please share a minimal, self contained code example that demonstrates the problem

[StephaneAdeso]

https://github.com/StephaneAdeso/adeso-seeker.git

[vscodenpa]

Hey @mjbvz, this issue might need further attention.

@StephaneAdeso, you can help us out by closing this issue if the problem no longer exists, or adding more information.

[vscodenpa]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!